Gain/gain.html test doesn't need expected reference wav file |
||
Issue descriptionThe test in Gain/gain.html just plays a short sine wave buffer through a gain node with different gain values. It compares the generated result against a reference file. The computations are so simple, that we don't really need a reference file. We can compute analytically what the output should be and do the comparison that way, getting rid of the reference file.
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a23ba5120eba56756fc5804491fe99a0c0b476cd commit a23ba5120eba56756fc5804491fe99a0c0b476cd Author: Raymond Toy <rtoy@chromium.org> Date: Fri Oct 20 17:20:10 2017 Remove need for reference wav file for test Instead of the reference file, we compute the expected result based on the source signal and the specified gain node gains. Also took the opportinuity to fix up some silly oversights in the test itself: * Creating 4-channel AudioBuffer when only 2 were used. * Only testing the result of the first channel. Bug: 776002 Test: Gain/gain.html Change-Id: I763b54f5145546612ceedc78053e1bcef56cc83e Reviewed-on: https://chromium-review.googlesource.com/727550 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#510476} [delete] https://crrev.com/066e7d6c680072b064f528d89259a914bc1ba0f7/third_party/WebKit/LayoutTests/webaudio/Gain/gain-expected.wav [modify] https://crrev.com/a23ba5120eba56756fc5804491fe99a0c0b476cd/third_party/WebKit/LayoutTests/webaudio/Gain/gain.html
,
Oct 25 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by rtoy@chromium.org
, Oct 20 2017Status: Started (was: Available)