User avatar animating on settings page and login screen |
|||||
Issue descriptionThe icon next to the user name on the 'People' settings page is animating. This is undesirable.
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb23482d3f768b4d23c5eb3cb0a6aefb05dd58e6 commit fb23482d3f768b4d23c5eb3cb0a6aefb05dd58e6 Author: David Reveman <reveman@chromium.org> Date: Wed Oct 18 22:23:46 2017 Settings: Disable profile image animations on manage user page. Request first frame of user image to avoid animations. Bug: 775988 Test: manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I47df758d0ce63f0d1f51cefa1e8d90340ad3ef67 Reviewed-on: https://chromium-review.googlesource.com/726303 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509896} [modify] https://crrev.com/fb23482d3f768b4d23c5eb3cb0a6aefb05dd58e6/chrome/browser/resources/settings/people_page/user_list.js
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b8a113ba6841f4b1397c504e92fe12044e10968 commit 1b8a113ba6841f4b1397c504e92fe12044e10968 Author: David Reveman <reveman@chromium.org> Date: Wed Oct 18 23:31:14 2017 Login: Stop motion stills when not selected. This updates the user image URL handler to respect frame arguments for motion stills and not only the default set of user images. Bug: 775988 Test: manual Change-Id: I25b9e5d0d3937c90b128b246ba40c63bb59a4b51 Reviewed-on: https://chromium-review.googlesource.com/726600 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509923} [modify] https://crrev.com/1b8a113ba6841f4b1397c504e92fe12044e10968/chrome/browser/ui/webui/chromeos/user_image_source.cc
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e9700f98b9f423b1dce16dc0e641057d70acca6 commit 9e9700f98b9f423b1dce16dc0e641057d70acca6 Author: David Reveman <reveman@chromium.org> Date: Thu Oct 19 00:30:11 2017 Settings: Disable profile image animations on settings page. This uses CrPngBehavior to remove any potential animations from the profile image displayed on the 'People' settings page. Bug: 775988 Test: manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib6675b648e30c409f3c53973bed219d0479f1d6f Reviewed-on: https://chromium-review.googlesource.com/726381 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#509943} [modify] https://crrev.com/9e9700f98b9f423b1dce16dc0e641057d70acca6/chrome/browser/resources/settings/people_page/compiled_resources2.gyp [modify] https://crrev.com/9e9700f98b9f423b1dce16dc0e641057d70acca6/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/9e9700f98b9f423b1dce16dc0e641057d70acca6/chrome/browser/resources/settings/people_page/people_page.js
,
Oct 19 2017
,
Oct 19 2017
ge
,
Oct 19 2017
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4001b96c7e81cc959768e4476f22e910ddaa456f commit 4001b96c7e81cc959768e4476f22e910ddaa456f Author: David Reveman <reveman@chromium.org> Date: Thu Oct 19 20:48:18 2017 Settings: Disable profile image animations on manage user page. Request first frame of user image to avoid animations. TBR=reveman@chromium.org (cherry picked from commit fb23482d3f768b4d23c5eb3cb0a6aefb05dd58e6) Bug: 775988 Test: manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I47df758d0ce63f0d1f51cefa1e8d90340ad3ef67 Reviewed-on: https://chromium-review.googlesource.com/726303 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509896} Reviewed-on: https://chromium-review.googlesource.com/728541 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#87} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/4001b96c7e81cc959768e4476f22e910ddaa456f/chrome/browser/resources/settings/people_page/user_list.js
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a801d115891fda9babf3c5b23250f746ccb8e1b9 commit a801d115891fda9babf3c5b23250f746ccb8e1b9 Author: David Reveman <reveman@chromium.org> Date: Thu Oct 19 20:54:38 2017 Login: Stop motion stills when not selected. This updates the user image URL handler to respect frame arguments for motion stills and not only the default set of user images. TBR=reveman@chromium.org (cherry picked from commit 1b8a113ba6841f4b1397c504e92fe12044e10968) Bug: 775988 Test: manual Change-Id: I25b9e5d0d3937c90b128b246ba40c63bb59a4b51 Reviewed-on: https://chromium-review.googlesource.com/726600 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509923} Reviewed-on: https://chromium-review.googlesource.com/728542 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#88} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/a801d115891fda9babf3c5b23250f746ccb8e1b9/chrome/browser/ui/webui/chromeos/user_image_source.cc
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e00a2db2f6e129f0d9a2cb5be83321cdb5de0808 commit e00a2db2f6e129f0d9a2cb5be83321cdb5de0808 Author: David Reveman <reveman@chromium.org> Date: Thu Oct 19 21:04:20 2017 Settings: Disable profile image animations on settings page. This uses CrPngBehavior to remove any potential animations from the profile image displayed on the 'People' settings page. TBR=reveman@chromium.org (cherry picked from commit 9e9700f98b9f423b1dce16dc0e641057d70acca6) Bug: 775988 Test: manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib6675b648e30c409f3c53973bed219d0479f1d6f Reviewed-on: https://chromium-review.googlesource.com/726381 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509943} Reviewed-on: https://chromium-review.googlesource.com/729132 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#89} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/e00a2db2f6e129f0d9a2cb5be83321cdb5de0808/chrome/browser/resources/settings/people_page/compiled_resources2.gyp [modify] https://crrev.com/e00a2db2f6e129f0d9a2cb5be83321cdb5de0808/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/e00a2db2f6e129f0d9a2cb5be83321cdb5de0808/chrome/browser/resources/settings/people_page/people_page.js |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by reve...@chromium.org
, Oct 18 2017