[MacViews] Clicking on the title bar outside of a tab doesn't activate browser |
|||||||
Issue descriptionI have a chrome::BrowserListObserver. When I click in the title bar outside of any tab, while the browser window comes forward, OnBrowserSetLastActive is not called. Only when I click inside a tab or the content area of the tab does OnBrowserSetLastActive finally get called. This is incorrect behavior; whenever the browser window comes forward OnBrowserSetLastActive must be called. > random MacViews folks
,
Feb 7 2018
,
Mar 23 2018
MacViews triage: oop, this one's actually pretty important :) self-assigning targeting M-67.
,
Mar 23 2018
Issue 712251 has been merged into this issue.
,
Mar 23 2018
Issue 587333 has been merged into this issue.
,
Mar 26 2018
This might be a fix: <https://chromium-review.googlesource.com/c/chromium/src/+/980701>
,
Mar 26 2018
Seems like CL listed at #6 is ready to submit. Elly, could you ptal and land the change to trunk pls?
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dd0abb6ac24b0444a38105cd47c0d82e56d45d4 commit 6dd0abb6ac24b0444a38105cd47c0d82e56d45d4 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Mar 27 12:11:55 2018 macviews: don't ignore events that may start a drag In NativeWidgetMacNSWindow, sendEvent: will *not* call [super sendEvent:] for events that might be the start of a drag, which prevents the window from receiving the event if we think it might start a drag. Any LMouseDown could start a drag, so that causes mouse clicks that aren't on some other NSView to not raise the window. Fix that by not returning early when maybe starting a drag. Bug: 775984 Change-Id: Ibe93e45dc4dde39630a3d97f5a148de018c99ab2 Reviewed-on: https://chromium-review.googlesource.com/980701 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#546084} [modify] https://crrev.com/6dd0abb6ac24b0444a38105cd47c0d82e56d45d4/ui/views/cocoa/native_widget_mac_nswindow.mm
,
Mar 27 2018
Fixed by #8.
,
Apr 6 2018
As this issue doesn't have any steps checked with steps in merged issue 587333 . Able to reproduce this issue on build without fix(67.0.3379.0). i.e; Abe to drag frameless window but not seeing focus on it when clicked. Hence verifying the fix on latest canary 67.0.3390.0 Enabled chrome://flags/#mac-views-native-app-windows and added frameless window app. Clicked on desktop and selected frameless window and dragged. Observing highlight on frameless window and able to drag successfully. As fix is working as expected adding Verified labels. Thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ellyjo...@chromium.org
, Jan 9 2018