New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775968 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ChromeOutOfProcessPatcher should not use utility_process_mojo_client

Project Member Reported by jcivelli@chromium.org, Oct 18 2017

Issue description

As part of the effort to move process launch to the service manager, 
chrome/browser/component_updater/component_patcher_operation_out_of_process.h should use the service manager instead of 
utility_process_mojo_client.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29f9b94b7d8d5a137144dad671016077fafc0753

commit 29f9b94b7d8d5a137144dad671016077fafc0753
Author: Jay Civelli <jcivelli@google.com>
Date: Wed Nov 08 20:07:26 2017

Servicifying file patching.

As part of the effort to deprecate UtilityProcessMojoClient, changing
FilePatcher to be a service, living under chrome/services/chrome_file_util
(where additional file related services will be added soon).

Bug:  775968 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie82d5b0da34996723b11b053cbbda201c16c4ba1
Reviewed-on: https://chromium-review.googlesource.com/726179
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514919}
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/chrome/app/BUILD.gn
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/chrome/app/generated_resources.grd
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/chrome/browser/BUILD.gn
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/chrome/browser/chrome_content_utility_manifest_overlay.json
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/chrome/browser/component_updater/chrome_component_updater_configurator.cc
[rename] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/chrome/browser/component_updater/component_patcher_operation_browsertest.cc
[delete] https://crrev.com/746fa66bc5f6d6e23f9cea4726e19831ccf4527f/chrome/browser/component_updater/component_patcher_operation_out_of_process.cc
[delete] https://crrev.com/746fa66bc5f6d6e23f9cea4726e19831ccf4527f/chrome/browser/component_updater/component_patcher_operation_out_of_process.h
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/chrome/browser/extensions/updater/chrome_update_client_config.cc
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/chrome/browser/extensions/updater/chrome_update_client_config.h
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/chrome/common/BUILD.gn
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/chrome/test/BUILD.gn
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/chrome/utility/BUILD.gn
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/chrome/utility/DEPS
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/component_updater/BUILD.gn
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/component_updater/DEPS
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/component_updater/component_installer_unittest.cc
[add] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/patch_service/BUILD.gn
[add] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/patch_service/DEPS
[add] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/patch_service/OWNERS
[add] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/patch_service/README.md
[add] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/patch_service/file_patcher_impl.cc
[add] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/patch_service/file_patcher_impl.h
[add] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/patch_service/manifest.json
[add] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/patch_service/patch_service.cc
[add] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/patch_service/patch_service.h
[add] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/patch_service/public/cpp/BUILD.gn
[add] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/patch_service/public/cpp/patch.cc
[add] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/patch_service/public/cpp/patch.h
[add] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/patch_service/public/interfaces/BUILD.gn
[add] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/patch_service/public/interfaces/OWNERS
[add] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/patch_service/public/interfaces/constants.mojom
[rename] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/patch_service/public/interfaces/file_patcher.mojom
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/update_client/BUILD.gn
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/update_client/DEPS
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/update_client/component.cc
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/update_client/component_patcher.cc
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/update_client/component_patcher.h
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/update_client/component_patcher_operation.cc
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/update_client/component_patcher_operation.h
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/update_client/component_patcher_unittest.cc
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/update_client/component_unpacker.cc
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/update_client/component_unpacker.h
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/update_client/configurator.h
[delete] https://crrev.com/746fa66bc5f6d6e23f9cea4726e19831ccf4527f/components/update_client/out_of_process_patcher.h
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/update_client/test_configurator.cc
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/components/update_client/test_configurator.h
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/ios/chrome/browser/DEPS
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/ios/chrome/browser/component_updater/BUILD.gn
[modify] https://crrev.com/29f9b94b7d8d5a137144dad671016077fafc0753/ios/chrome/browser/component_updater/ios_component_updater_configurator.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment