New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775958 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

virtual/gpu-rasterization/images/color-profile-svg-fill-text.html draws slightly differently after Skia tessellation change

Project Member Reported by bsalo...@google.com, Oct 18 2017

Issue description

Skia changed the way it tessellates rectangles and this test subtly and insignificantly changed. It'll need a rebaseline.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62f303c84de571d445bb31c1c0ae2c40ee2bdfb9

commit 62f303c84de571d445bb31c1c0ae2c40ee2bdfb9
Author: Brian Salomon <bsalomon@google.com>
Date: Wed Oct 18 22:04:33 2017

Manually roll src/third_party/skia/ 079e50bbd..c4f93cab6 (4 commits)

https://skia.googlesource.com/skia.git/+log/079e50bbdeeb..c4f93cab667b

Suppress several layout tests (1 due to apparent swiftshader bug)

Rebaseline LayerTreeHostFiltersPixelTest.BackgroundFilterBlurOutsets

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Bug:  775957 , 775958 
Change-Id: I41ff979a446f7410a5caf78db594d5219f84e090
Reviewed-on: https://chromium-review.googlesource.com/726103
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509891}
[modify] https://crrev.com/62f303c84de571d445bb31c1c0ae2c40ee2bdfb9/DEPS
[modify] https://crrev.com/62f303c84de571d445bb31c1c0ae2c40ee2bdfb9/components/viz/test/data/background_filter_blur_outsets.png
[modify] https://crrev.com/62f303c84de571d445bb31c1c0ae2c40ee2bdfb9/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d65fb52c51f499a2e766e0b5e10bafe57064e296

commit d65fb52c51f499a2e766e0b5e10bafe57064e296
Author: Brian Salomon <bsalomon@google.com>
Date: Tue Oct 24 02:08:34 2017

Rebaseline tests for  crbug.com/775958 

Bug:  775958 
Change-Id: I10313b017c3af60a413f034f90a3d93fe17cd6b8
Reviewed-on: https://chromium-review.googlesource.com/726999
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511008}
[modify] https://crrev.com/d65fb52c51f499a2e766e0b5e10bafe57064e296/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d65fb52c51f499a2e766e0b5e10bafe57064e296/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/d65fb52c51f499a2e766e0b5e10bafe57064e296/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/d65fb52c51f499a2e766e0b5e10bafe57064e296/third_party/WebKit/LayoutTests/platform/mac/compositing/masks/mask-with-added-filters-expected.png
[modify] https://crrev.com/d65fb52c51f499a2e766e0b5e10bafe57064e296/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/d65fb52c51f499a2e766e0b5e10bafe57064e296/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-composite-video-expected.png
[modify] https://crrev.com/d65fb52c51f499a2e766e0b5e10bafe57064e296/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-composite-video-shadow-expected.png
[modify] https://crrev.com/d65fb52c51f499a2e766e0b5e10bafe57064e296/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-svg-fill-text-expected.png

Comment 3 by bsalo...@google.com, Oct 24 2017

Status: Fixed (was: Assigned)

Sign in to add a comment