Canvas layout test draws incorrectly on swiftshader but not osmesa or NVIDIA GPU |
|||
Issue descriptionSkia recently changed how it triangulates rectangles. The diagonal edge changed from going from the top-left to the bottom-right to now going from the bottom-left to the top-right. Two virtual/gpu layout tests changed. One of them now draws incorrectly. Corruption is seen along the new diagonal. This seems to only happen in SwiftShader. OSMesa and the NVIDIA card in my Z840 don't show this corruption. The test is: virtual/gpu/fast/canvas/canvas-incremental-repaint.html The bad result can be seen here: https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_rel_ng/567812/layout-test-results/results.html The Skia change that triggered this is here: https://skia.googlesource.com/skia.git/+/57caa660c024cf6fda5e1fba8cb21224b51375fe It has not yet rolled into Chrome, though that should happen after I suppress this test.
,
Oct 18 2017
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62f303c84de571d445bb31c1c0ae2c40ee2bdfb9 commit 62f303c84de571d445bb31c1c0ae2c40ee2bdfb9 Author: Brian Salomon <bsalomon@google.com> Date: Wed Oct 18 22:04:33 2017 Manually roll src/third_party/skia/ 079e50bbd..c4f93cab6 (4 commits) https://skia.googlesource.com/skia.git/+log/079e50bbdeeb..c4f93cab667b Suppress several layout tests (1 due to apparent swiftshader bug) Rebaseline LayerTreeHostFiltersPixelTest.BackgroundFilterBlurOutsets CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Bug: 775957 , 775958 Change-Id: I41ff979a446f7410a5caf78db594d5219f84e090 Reviewed-on: https://chromium-review.googlesource.com/726103 Commit-Queue: Brian Salomon <bsalomon@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#509891} [modify] https://crrev.com/62f303c84de571d445bb31c1c0ae2c40ee2bdfb9/DEPS [modify] https://crrev.com/62f303c84de571d445bb31c1c0ae2c40ee2bdfb9/components/viz/test/data/background_filter_blur_outsets.png [modify] https://crrev.com/62f303c84de571d445bb31c1c0ae2c40ee2bdfb9/third_party/WebKit/LayoutTests/TestExpectations
,
Oct 26 2017
This issue was fixed by: https://swiftshader-review.googlesource.com/c/SwiftShader/+/13268 Fix will be available in the next SwiftShader DEPS roll.
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e813690449fb7265efb50b410dc271e5f63cf05 commit 7e813690449fb7265efb50b410dc271e5f63cf05 Author: Alexis Hetu <sugoi@google.com> Date: Fri Oct 27 19:22:05 2017 Roll SwiftShader ec5da19..6e27fea https://swiftshader.googlesource.com/SwiftShader.git/+log/ec5da19..6e27fea BUG= chromium:778254 chromium:776621 chromium:775957 TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I77c9aa6852f23337dc3358ece917299a6e3f1db3 Reviewed-on: https://chromium-review.googlesource.com/741920 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#512264} [modify] https://crrev.com/7e813690449fb7265efb50b410dc271e5f63cf05/DEPS
,
Nov 2 2017
Should be fixed. The layout test can be rebaselined and re-enabled. |
|||
►
Sign in to add a comment |
|||
Comment 1 by senorblanco@chromium.org
, Oct 18 2017