[Remote suggestions] Tracking how many suggestions have been seen does not work well with Chrome Home |
||||
Issue descriptionCurrently, the tracking is based on onBindViewHolder events. In ChromeHome, ~4 suggestions are bound initially before any of them is displayed. dgn@ claims this is due to the combination of a bottom sheet and a RecyclerView; the whole sheet gets bound initially, even when pulled up by 1px. Probably hard to fix without breaking other things. We should fix it and base the tracking on something else. This is a M63 merge candidate (depending on the complexity of the fix).
,
Nov 7 2017
jkrcal@, friendly ping. Is M63 still an option?
,
Nov 8 2017
I have it on my radar. I think M63 is not realistic, at this moment. I changed the target to M64.
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c68f9bae584130da8857842e8be99bcb9459fa14 commit c68f9bae584130da8857842e8be99bcb9459fa14 Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Nov 15 19:09:56 2017 [Suggestions] Improve tracking seen suggestions for CH This CL fixes the tracking mechanism for which suggestions have been seen. Before this change, tracking was partially broken for Chrome Home when pulling up the sheet, 4 suggestions were marked as impressed immediately. Bug: 775953 Change-Id: Id1d76d8620ce6986c242eaeeeeb0f087b44ed41d Reviewed-on: https://chromium-review.googlesource.com/726083 Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#516775} [modify] https://crrev.com/c68f9bae584130da8857842e8be99bcb9459fa14/chrome/android/java/src/org/chromium/chrome/browser/metrics/ImpressionTracker.java [modify] https://crrev.com/c68f9bae584130da8857842e8be99bcb9459fa14/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java [modify] https://crrev.com/c68f9bae584130da8857842e8be99bcb9459fa14/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java [modify] https://crrev.com/c68f9bae584130da8857842e8be99bcb9459fa14/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java [modify] https://crrev.com/c68f9bae584130da8857842e8be99bcb9459fa14/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/c68f9bae584130da8857842e8be99bcb9459fa14/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java [modify] https://crrev.com/c68f9bae584130da8857842e8be99bcb9459fa14/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java
,
Nov 17 2017
,
Nov 20 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by fhorschig@chromium.org
, Oct 20 2017