New issue
Advanced search Search tips

Issue 775946 link

Starred by 1 user
Status: Fixed
Owner:
se...@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Remove basictypes_override for libaddressinput

Project Member Reported by se...@chromium.org, Oct 18 2017 
Now that libaddressinput is using the features of C++ 11 and that the basictypes file is removed, we can now remove the basictypes_override that is used in chromium.

A nice effect of this will be that there won't be a macro redifinition error in using both libaddressinput and libphonenumber (They both defined a CompileAssert in their basictypes file).
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17ebe806789b5cf788debbc783eabb6ed208edfc

commit 17ebe806789b5cf788debbc783eabb6ed208edfc
Author: sebsg <sebsg@chromium.org>
Date: Thu Oct 26 17:46:21 2017

[Autofill] Remove basictypes_override from chromium libaddressinput.

It's not needed anymore now that libaddressinput doesn't need a
basictypes file.

Link to the github commit: https://github.com/googlei18n/libaddressinput/pull/143/

Bug:  775946 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I95b20063d05311d352c7055dae7dd58d0682fc8b
Reviewed-on: https://chromium-review.googlesource.com/726099
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511872}
[modify] https://crrev.com/17ebe806789b5cf788debbc783eabb6ed208edfc/DEPS
[modify] https://crrev.com/17ebe806789b5cf788debbc783eabb6ed208edfc/build/check_gn_headers_whitelist.txt
[modify] https://crrev.com/17ebe806789b5cf788debbc783eabb6ed208edfc/third_party/libaddressinput/BUILD.gn
[delete] https://crrev.com/010464ad1c6d042d29565b488f0cf88be790bba5/third_party/libaddressinput/chromium/override/basictypes_override.h

Comment 2 by se...@chromium.org, Oct 30 2017

Status: Fixed (was: Started)
►

Sign in to add a comment