New issue
Advanced search Search tips

Issue 775935 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 785808
issue 786223
issue 786232



Sign in to add a comment

builder"s" page (relative view) per project in milo

Project Member Reported by estaab@chromium.org, Oct 18 2017

Issue description

Builders list page that shows a list of builders. Requirements

- Show list of builders per project
- Each row is a builder
- Each builder shows 
    - # of Pending builds
    - In progress builds
    - Completed builds (N most recent)
- X axis represents time, but time is "relative" only per row and not over whole table (NOT absolute)
- Link to parent "project" page somewhere on the page

Changes to parent project page: 
- Parent "project" page should have a link to it's builder"s" page. 

Expected URL: https://ci.chromium.org/p/<project_id>/builders

Features should be parity to existing page in BuildBot: 
https://build.chromium.org/p/tryserver.chromium.linux/builders

 

Comment 1 by estaab@chromium.org, Oct 18 2017

Components: -Infra>Platform Infra>Platform>Milo
I mostly use this for try builders, but I'll also use it for continuous builders to get a sense of what's red; I don't usually use the console because I can't see the builder names and I find the builders page easier to read (scanning down instead of across).

One thing that would be really useful that we don't have today would be to show how far behind a given builder is (i.e., the last completed build revision, or the build revision currently being built, or both). You can get a sense of this in the console view today, but only when there aren't too many revisions that have landed since the builder last completed.

Comment 3 by estaab@chromium.org, Nov 16 2017

Cc: efoo@chromium.org jchin...@chromium.org
Labels: LUCI-Blockers-M4

Comment 4 by estaab@chromium.org, Nov 16 2017

Labels: -LUCI-Blockers-M4 LUCI-Blocker-M4

Comment 5 by efoo@chromium.org, Nov 16 2017

Labels: REQBY-LUCI-M4a-MacWinPOC LUCI-M3-S12 LUCI-M3-Beta
Assign to S12 and set labels for tracking

Comment 6 by efoo@chromium.org, Nov 16 2017

Owner: jchin...@chromium.org
Status: Assigned (was: Available)
Assigning to Jao-ke

Comment 7 by efoo@chromium.org, Nov 16 2017

Issue 782516 has been merged into this issue.

Comment 8 by efoo@chromium.org, Nov 16 2017

Labels: LUCI-Blocker-UI

Comment 9 by efoo@chromium.org, Nov 16 2017

Blocking: 785808

Comment 10 by efoo@chromium.org, Nov 17 2017

Summary: builders page (relative view) per console and per project in milo (was: builders view in milo)

Comment 11 by efoo@chromium.org, Nov 17 2017

Description: Show this description

Comment 12 by efoo@chromium.org, Nov 17 2017

Summary: builders page (relative view) per project in milo (was: builders page (relative view) per console and per project in milo)

Comment 13 by efoo@chromium.org, Nov 17 2017

Blocking: 786223 786232
Labels: -Pri-2 Pri-1
Summary: builder"s" page (relative view) per project in milo (was: builders page (relative view) per project in milo)
Marked as P1. This is the minimum requirements of what we would like to have for LUCI UI Tuesday. Moved out remaining P2 work:

- builder"s" page per console  (crbug.com/786223)
- absolute view for builder"s" page (crbug.com/786232)

Comment 14 by efoo@chromium.org, Nov 17 2017

Description: Show this description

Comment 15 by efoo@chromium.org, Nov 17 2017

Description: Show this description

Comment 16 by no...@chromium.org, Nov 17 2017

> Pending builds
number of pending builds or a list of pending builds? buildbot displays a single number

> Completed builds (N most recent)
Buildbot does not do this. Is this a blocker?

Comment 17 by efoo@chromium.org, Nov 17 2017

> Pending builds?
number of pending builds

> Completed builds (N most recent)
>> Buildbot does not do this. Is this a blocker?
AFAIK, Jao-ke's design includes this. That's the relative aspect of this bug. 

Worst case scenario, we drop the N completed builds requirement to just show the most recent completed build. 

Comment 18 by efoo@chromium.org, Nov 17 2017

Description: Show this description
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/gae/+/690323161cf20e86033fc809dc30caf4b88eb0cf

commit 690323161cf20e86033fc809dc30caf4b88eb0cf
Author: Nodir Turakulov <nodir@google.com>
Date: Sat Nov 18 18:06:38 2017

[datastore] set parent key before setting id

PopulateKey ignores parent key if it is not able to set id.
However, not being able to set id is not an error because it might be
intentionally defined as _.

Populate what we can first, then populate more critical pieces.

Bug:  775935 
Change-Id: Ie03ce49c0062dc6c810703dcb7ea1c501aee4240
Reviewed-on: https://chromium-review.googlesource.com/777985
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/690323161cf20e86033fc809dc30caf4b88eb0cf/service/datastore/interface.go
[modify] https://crrev.com/690323161cf20e86033fc809dc30caf4b88eb0cf/service/datastore/datastore_test.go

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/0447dba094992bd0f5e9146169b46bceeffe0940

commit 0447dba094992bd0f5e9146169b46bceeffe0940
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Mon Nov 20 05:06:40 2017

[milo] Provide builders view by relative time.

This is analogous to Buildbot's builders view, displaying, for each
builder, the number of pending and running builds, and the statuses
of the last {limit} builds on that builder. Thus builders cannot be
correlated time-wise with each other in this view.

This CL does not filter the builders list based on console, instead
displaying all builders in a given project; this will be changed in
(one of) the next CL(s).

Bug:  775935 
Change-Id: I289a03efefe8e326f240cf76f46cd7032bd32c5f
Reviewed-on: https://chromium-review.googlesource.com/777706
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/0447dba094992bd0f5e9146169b46bceeffe0940/milo/common/model/build_summary.go
[modify] https://crrev.com/0447dba094992bd0f5e9146169b46bceeffe0940/milo/common/model/builder_summary.go
[modify] https://crrev.com/0447dba094992bd0f5e9146169b46bceeffe0940/milo/common/model/builder_summary_test.go
[modify] https://crrev.com/0447dba094992bd0f5e9146169b46bceeffe0940/milo/frontend/appengine/index.yaml
[modify] https://crrev.com/0447dba094992bd0f5e9146169b46bceeffe0940/milo/frontend/appengine/static/buildbot/css/default.css
[add] https://crrev.com/0447dba094992bd0f5e9146169b46bceeffe0940/milo/frontend/appengine/static/common/css/builders.css
[add] https://crrev.com/0447dba094992bd0f5e9146169b46bceeffe0940/milo/frontend/appengine/templates/pages/builders_relative_time.html
[modify] https://crrev.com/0447dba094992bd0f5e9146169b46bceeffe0940/milo/frontend/routes.go
[add] https://crrev.com/0447dba094992bd0f5e9146169b46bceeffe0940/milo/frontend/view_builders.go

Comment 21 by efoo@chromium.org, Nov 20 2017

Status: Fixed (was: Assigned)

Comment 22 by efoo@chromium.org, Jan 31 2018

Labels: LUCI-Beta

Comment 23 by efoo@chromium.org, Jan 31 2018

Labels: -LUCI-Blocker-M4 -LUCI-M3-Beta luci-blocker-migration

Comment 24 by efoo@chromium.org, Feb 13 2018

Labels: -LUCI-blocker-migration LUCI-Chromium-CQSets LUCI-Blocker-Chromium-CQSets

Sign in to add a comment