New issue
Advanced search Search tips

Issue 775923 link

Starred by 1 user
Status: Available
Owner:
droger@chromium.org
Cc:
msarda@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Dice] Retry logic on errors when fetching the token

Project Member Reported by droger@chromium.org, Oct 18 2017 
Currently, when Dice fetches a new token from the authorization code, it only uses the retry logic that is built in the GaiaAuthFetcher (which I think itself inherits from the net::URLFetcher).

We may want to improve that logic, in particular if the request failed for connectivity issues.

The relevant code is in DiceResponseHandler::OnTokenExchangeFailure().

Comment 1 by droger@chromium.org, Nov 8 2017 

Relevant histogram is: Signin.DiceTokenFetchResult
https://uma.googleplex.com/histograms?dayCount=28&histograms=Signin.DiceTokenFetchResult&fixupData=true&showMax=true&filters=platform%2Ceq%2CW%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial

As of today it has a 98% success rate:
        Count	PDF
Success	7,959	97.76%
Abort	110	01.35%
Failure	17	00.21%
Timeout	55	00.68%

If we ignore abort (which is not really an error), the error rate is actually below 1%.
Project Member

Comment 2 by sheriffbot@chromium.org, Dec 8 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by msarda@chromium.org, Dec 8 2017

Status: Assigned (was: Available)
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 8 2018

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Available)
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 3

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment