New issue
Advanced search Search tips

Issue 775918 link

Starred by 2 users
Status: Assigned
Owner:
mahmadi@chromium.org
Cc:
rogerm@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

No unittests are in place for ChromeAutofillClientIOS and AutofillClientIOS

Project Member Reported by linds...@chromium.org, Oct 18 2017 
No unittests are in place for ChromeAutofillClientIOS and AutofillClientIOS. Lack of automated test coverage made it possible for a change to land that causes a crash if you put the cursor in a field and type in an incognito window (issue 774704). In order to create unittest coverage the objects would have to be mocked out, so it will take considerable time investment.

Comment 1 by sczs@chromium.org, Oct 18 2017

Cc: -dvadym@chromium.org
Owner: dvadym@chromium.org
Status: Assigned (was: Untriaged)
dvadym@ could you PTAL.

Comment 2 by dvadym@chromium.org, Oct 19 2017

Owner: ----
Status: Available (was: Assigned)
Sorry atm I'm pretty busy with other stuff and I'm not really familiar with this code, I've just fixed a crash. Let's leave it as available, probably somebody will take it.

lindsayw@ why is it restricted to Google permissions?

Comment 3 by linds...@chromium.org, Oct 20 2017 

Why is the bug RVG? That's probably just the template I used to file the tracker, also some teams use RVG for test discussions. Please feel free to open this tracker as appropriate.

Comment 4 by dvadym@chromium.org, Oct 20 2017

Labels: -Restrict-View-Google
Making bug public. That makes it possible that somebody outside Google would take it.

Comment 5 by ma...@chromium.org, May 1 2018

Status: Untriaged (was: Available)

Comment 6 by se...@chromium.org, May 15 2018

Labels: -Pri-2 Pri-3
Owner: mahmadi@chromium.org
Status: Assigned (was: Untriaged)
►

Sign in to add a comment