New issue
Advanced search Search tips

Issue 775906 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Useless return value of WebRTCEventLogHost::StartEventLogForPeerConnection

Project Member Reported by eladalon@chromium.org, Oct 18 2017

Issue description

The return value is always true, regardless of the function's operation. Also, no one is examining it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c980c35fb16bd1b2e18a9c329d8ad19870cb785

commit 9c980c35fb16bd1b2e18a9c329d8ad19870cb785
Author: Elad Alon <eladalon@chromium.org>
Date: Fri Oct 20 08:26:39 2017

Remove unused return value of WebRTCEventLogHost::StartEventLogForPeerConnection

The return value is always true, regardless of the function's operation. Also, no one is examining it.

Bug:  775906 
Change-Id: I5d624af731f94ff4f5ff4af232020398fee673bf
Reviewed-on: https://chromium-review.googlesource.com/725710
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510378}
[modify] https://crrev.com/9c980c35fb16bd1b2e18a9c329d8ad19870cb785/content/browser/webrtc/webrtc_eventlog_host.cc
[modify] https://crrev.com/9c980c35fb16bd1b2e18a9c329d8ad19870cb785/content/browser/webrtc/webrtc_eventlog_host.h

Status: Fixed (was: Started)

Sign in to add a comment