New issue
Advanced search Search tips

Issue 775893 link

Starred by 1 user
Status: Fixed
Owner:
ericwilligers@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Web Animation: Some properties not responsive to inherited change

Project Member Reported by ericwilligers@chromium.org, Oct 18 2017 
When animating to or from 'inherit', the animation should respond if the parent element's style changes.

The current happens for some properties, e.g. shape-outside, but not always for others, e.g. text-indent and offset-rotate.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c294ea6e57dcbfed27d16e30d920fd417d9779ef

commit c294ea6e57dcbfed27d16e30d920fd417d9779ef
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Fri Oct 20 23:30:05 2017

Web Animation: responsive offset-rotate and text-indent

Animations for offset-rotate/text-indent where a keyframe
is 'inherit' previously did not respond if the inherited
angle/length changed during the animation. (They only
responded when there was a change in non-interpolable
value like 'auto' or 'hanging'.)

Added tests for offset-rotate, shape-outside and text-indent.

BUG= 775893 

Change-Id: Ie0ffe751da3197c7fa777d2e2fd566be72b03251
Reviewed-on: https://chromium-review.googlesource.com/725642
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510606}
[modify] https://crrev.com/c294ea6e57dcbfed27d16e30d920fd417d9779ef/third_party/WebKit/LayoutTests/animations/responsive/animations-responsive-offsetDistance.html
[add] https://crrev.com/c294ea6e57dcbfed27d16e30d920fd417d9779ef/third_party/WebKit/LayoutTests/animations/responsive/animations-responsive-offsetRotate.html
[add] https://crrev.com/c294ea6e57dcbfed27d16e30d920fd417d9779ef/third_party/WebKit/LayoutTests/animations/responsive/animations-responsive-shapeOutside.html
[modify] https://crrev.com/c294ea6e57dcbfed27d16e30d920fd417d9779ef/third_party/WebKit/LayoutTests/animations/responsive/animations-responsive-textIndent.html
[modify] https://crrev.com/c294ea6e57dcbfed27d16e30d920fd417d9779ef/third_party/WebKit/Source/core/animation/CSSOffsetRotateInterpolationType.cpp
[modify] https://crrev.com/c294ea6e57dcbfed27d16e30d920fd417d9779ef/third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a418cde22b0bc980824eb3707edd1096ca55a76d

commit a418cde22b0bc980824eb3707edd1096ca55a76d
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Sat Oct 21 11:52:33 2017

Avoid InheritedRotationChecker Jumbo clash

CSSRotateInterpolationType.cpp and CSSOffsetRotateInterpolationType.cpp
each defined InheritedRotationChecker in the anonymous namespace.

This broke Jumbo builds.

BUG= 775893 

Change-Id: If64aa5381760ef923331c95bea40e25e2a60b853
Reviewed-on: https://chromium-review.googlesource.com/732363
Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510680}
[modify] https://crrev.com/a418cde22b0bc980824eb3707edd1096ca55a76d/third_party/WebKit/Source/core/animation/CSSOffsetRotateInterpolationType.cpp

Comment 3 by ericwilligers@chromium.org, Jun 21 2018

Owner: ericwilligers@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment