New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775888 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

DCHECK failure in array->map() != fixed_cow_array_map() in heap.cc

Project Member Reported by ClusterFuzz, Oct 18 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5525304222416896

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  array->map() != fixed_cow_array_map() in heap.cc
  v8::internal::Heap::MoveElements
  v8::internal::FastElementsAccessor<v8::internal::FastPackedObjectElementsAccesso
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=48623:48624

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5525304222416896

Issue manually filed by: titzer

See https://github.com/google/clusterfuzz-tools for more information.
 

Comment 1 by titzer@chromium.org, Oct 18 2017

Owner: danno@chromium.org
Status: Assigned (was: Untriaged)
This reproduces locally with a normal debug build.
Project Member

Comment 2 by ClusterFuzz, Oct 18 2017

Components: Blink>JavaScript>GC
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 18 2017

Labels: Pri-1

Comment 4 by titzer@chromium.org, Oct 19 2017

 Issue 776315  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0454a842d143ae260d920f54bc2f8278aff9b186

commit 0454a842d143ae260d920f54bc2f8278aff9b186
Author: Daniel Clifford <danno@chromium.org>
Date: Thu Oct 19 15:05:44 2017

Ensure inlined Array.protoype.shift() calls return non-COW arrays

Also ensure that CSA's CloneFixedArray and ExtractFixedArray correctly
transition COW to non-COW maps when doing a clone requiring copying.

Bug:  chromium:775888 
Change-Id: I31c97072761fdd2360d86f840c9fd6ab2d72973a
Reviewed-on: https://chromium-review.googlesource.com/727900
Commit-Queue: Daniel Clifford <danno@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48754}
[modify] https://crrev.com/0454a842d143ae260d920f54bc2f8278aff9b186/src/builtins/builtins-constructor-gen.cc
[modify] https://crrev.com/0454a842d143ae260d920f54bc2f8278aff9b186/src/builtins/builtins-internal-gen.cc
[modify] https://crrev.com/0454a842d143ae260d920f54bc2f8278aff9b186/src/builtins/builtins-promise-gen.cc
[modify] https://crrev.com/0454a842d143ae260d920f54bc2f8278aff9b186/src/builtins/builtins-regexp-gen.cc
[modify] https://crrev.com/0454a842d143ae260d920f54bc2f8278aff9b186/src/code-stub-assembler.cc
[modify] https://crrev.com/0454a842d143ae260d920f54bc2f8278aff9b186/src/code-stub-assembler.h
[modify] https://crrev.com/0454a842d143ae260d920f54bc2f8278aff9b186/test/cctest/test-code-stub-assembler.cc
[add] https://crrev.com/0454a842d143ae260d920f54bc2f8278aff9b186/test/mjsunit/regress/regress-775888.js

Comment 7 by danno@chromium.org, Oct 19 2017

Status: Fixed (was: Assigned)
Project Member

Comment 8 by ClusterFuzz, Oct 20 2017

ClusterFuzz has detected this issue as fixed in range 48753:48754.

Detailed report: https://clusterfuzz.com/testcase?key=5525304222416896

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  array->map() != fixed_cow_array_map() in heap.cc
  v8::internal::Heap::MoveElements
  v8::internal::FastElementsAccessor<v8::internal::FastPackedObjectElementsAccesso
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=48623:48624
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=48753:48754

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5525304222416896

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Oct 20 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5525304222416896 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Oct 22 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Project Member

Comment 12 by sheriffbot@chromium.org, Jan 27 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 13 by danno@chromium.org, Jun 20 2018

Cc: jarin@chromium.org
Labels: Hotlist-Torque
Cc: tebbi@chromium.org

Sign in to add a comment