New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users
Status: Fixed
Owner:
Unavailable Nov 15-30
Closed: Nov 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux, Android, Windows, Mac
Pri: 1
Type: Compat



Sign in to add a comment
css list-style renders in a weird way
Reported by slamb...@gmail.com, Oct 18 Back to list
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.62 Safari/537.36

Example URL:
https://test1.slamb.eu/pages/

Steps to reproduce the problem:
just visit https://test1.slamb.eu/pages/ and watch the menu on the left hand side

What is the expected behavior?
menu should have A normally visible inside LI

What went wrong?
A is moved down

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? Yes last 61 version before update to 62

Does this work in other browsers? Yes

Chrome version: 62.0.3202.62  Channel: stable
OS Version: 10.0
Flash Version: 

I found out when i add list-style: none to #menucontent > ul > li, it will fix, but until update to chrome 62 it worked fine as it was earlier, in Firefox and Edge it is ok without list-style set to none.
 
list-style.png
828 KB View Download
Components: Blink>CSS
Labels: Needs-Bisect Needs-Triage-M62
Cc: abdulsyed@chromium.org e...@chromium.org cathiec...@tencent.com
Labels: -Pri-2 -Needs-Bisect ReleaseBlock-Stable M-62 OS-Linux OS-Mac Pri-1
Owner: e...@chromium.org
Status: Assigned
Good# 62.0.3164.0
Bad# 62.0.3178.0

You are probably looking for a change made after 490845 (known good), but no later than 490846 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/e73eb5fb23e0e925cdc81922f8e6c15e3341a244..d80f2f901ba7e631b1779c7acac4d9aebd48fe9b

cathiechen@, can you please look into this change (https://chromium.googlesource.com/chromium/src/+/d80f2f901ba7e631b1779c7acac4d9aebd48fe9b) ?

Thank you!
Components: -Blink>CSS Blink>Layout
Yes, it's associated with this change. li contains overflow hidden block. E.g.
<li><div style="overflow:hidden"></div></li>

After this change, there will be a line break between marker and overflow:hidden block. 

I'm working on https://chromium-review.googlesource.com/c/chromium/src/+/728119 which could fix this issue.
Cc: cma...@chromium.org
Labels: M-63 OS-Android
Adding Android as this is Blink>Layout bug.
Is this a regression in M62? What is the progress on the fix? Since I am not sure I understand this issue very well, I would like to know how severe it is to warrant a respin for M62.
Comment 7 Deleted
Sorry for the delay. 
I've start a code review to fix this.
https://chromium-review.googlesource.com/c/chromium/src/+/735303


Because list with overflow firstchild didn't show marker,
last change intent to make marker shown, but it caused line-break issue. ( https://chromium.googlesource.com/chromium/src/+/d80f2f901ba7e631b1779c7acac4d9aebd48fe9b)

The new patch would eliminate this line-break and align block direction position for marker according to list's content. 
eae@ - can you please confirm if this is a true blocker? Our stable respin is scheduled for this week. Since we haven't seen any other similar issues from other sites, my recommendation is to fix this in M63. 
> Since we haven't seen any other similar issues from other sites

https://github.com/Turbo87/sidebar-v2/issues/126 seems to be the same issue
Cc: ranjitkan@chromium.org
Just to update, still bale to reproduce the issue on build 64.0.3253.0 on Windows 10, Mac 10.12.6, Ubuntu 14.04, Issue is tagged with a stale blocker for M63. Can this be addressed.

Thanks.!
[Bulk Edit]
URGENT - PTAL.
M63 Stable promotion is coming soon and your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP. Thank you.

Labels: -ReleaseBlock-Stable
Reverting isn't really an option as the cause for this fixed another P1 blocker. This seems slightly less serve so I'd argue we shouldn't block on this but try to fix it as soon as we can.

Note that we do have a fix in review.
Project Member Comment 14 by bugdroid1@chromium.org, Nov 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5099b7b47d627181b682a832d0e80f775d20eae

commit f5099b7b47d627181b682a832d0e80f775d20eae
Author: cathiechen <cathiechen@tencent.com>
Date: Thu Nov 02 20:35:35 2017

Fix unnecessary line-break between marker and overflow element.

In order to show marker in list with overflow children, we make marker as
the child of list. This change will generate line-break between marker
and overflow children. To eliminame this line-break:
1. When construct layout tree add marker as child of li which would
generate line-break.
2. To eliminame line-break, set marker_container's logicalHeight to
0px.
3. Align marker's block direction position according to first-line-box
after li's children layouted.

Design document:
https://docs.google.com/document/d/1bMerTLCSqHZYAERJ2HDr-4auOSw0eIx8QfD2vY92TNo

Bug:  775880 ,  767408 , 344941
Change-Id: I323be3fdd9447c5487963cb039c7bcc83922dcb8
Reviewed-on: https://chromium-review.googlesource.com/735303
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513595}
[add] https://crrev.com/f5099b7b47d627181b682a832d0e80f775d20eae/third_party/WebKit/LayoutTests/fast/lists/add-inline-child-after-marker-expected.html
[add] https://crrev.com/f5099b7b47d627181b682a832d0e80f775d20eae/third_party/WebKit/LayoutTests/fast/lists/add-inline-child-after-marker.html
[add] https://crrev.com/f5099b7b47d627181b682a832d0e80f775d20eae/third_party/WebKit/LayoutTests/fast/lists/li-with-overflow-hidden-change-list-style-position-expected.html
[add] https://crrev.com/f5099b7b47d627181b682a832d0e80f775d20eae/third_party/WebKit/LayoutTests/fast/lists/li-with-overflow-hidden-change-list-style-position.html
[modify] https://crrev.com/f5099b7b47d627181b682a832d0e80f775d20eae/third_party/WebKit/LayoutTests/fast/lists/list-marker-inside-overflow-hidden-expected.html
[add] https://crrev.com/f5099b7b47d627181b682a832d0e80f775d20eae/third_party/WebKit/LayoutTests/fast/lists/list-marker-with-lineheight-and-overflow-hidden-expected.html
[add] https://crrev.com/f5099b7b47d627181b682a832d0e80f775d20eae/third_party/WebKit/LayoutTests/fast/lists/list-marker-with-lineheight-and-overflow-hidden.html
[modify] https://crrev.com/f5099b7b47d627181b682a832d0e80f775d20eae/third_party/WebKit/Source/core/layout/LayoutListItem.cpp
[modify] https://crrev.com/f5099b7b47d627181b682a832d0e80f775d20eae/third_party/WebKit/Source/core/layout/LayoutListItem.h

Has this been fixed now cathiechen or are there more changes needed?

Yes, this has been fixed:)
Comment 17 by e...@chromium.org, Nov 13 (4 days ago)
Status: Fixed
Thank you!
Sign in to add a comment