Issue metadata
Sign in to add a comment
|
Regression : Saved image or File is opened in Browser on clicking at space available after 'SHOW IN FOLDER' in Notifications |
||||||||||||||||||||||
Issue descriptionChrome Version: 62.0.3202.63/9901.49.0 Beta-channel Daisy,Candy and Reks OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Save any Page or Download any PDF file (2)Now hover mouse at space available after 'SHOW IN FOLDER' -> Click on that space and observe saved page is seen in Browser (Please refer Video) Note : 1.If the above change is intended then unnecessarily saved page is opened in Browser on clicking at 'Download Manager' i.e. should not able to click on 'Download Manager' as already able to open file or page in Browser on clicking at space available after 'SHOW IN FOLDER' 2.Issue is seen on latest M-64 also Expected: Saved page or File should open in Files App On clicking anywhere at space available after 'SHOW IN FOLDER' Actual: Instead saved page or File is opened in Browser on clicking at space available after 'SHOW IN FOLDER' This is Regression Issue seen as same is working fine in 61.0.3163.120/9765.81.0 stable-channel Daisy @Yoshiki: Please confirm the behavior
,
Nov 3 2017
This is an expected behavior as the region clicked in the Actual_Notification.webm video is outside the button, and all the clicks outside the button are treated as the notification click event, in this case, opening a file. Though it can be confusing, so it might be better to remove click target from the action button area?
,
Nov 6 2017
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c144779d6b9194e60efd8dddddce5b825956e2a commit 6c144779d6b9194e60efd8dddddce5b825956e2a Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Nov 08 18:52:07 2017 Ignore click of the empty area in actions row. In NotificationViewMD, all clicks outside the action buttons and the header trigger notifiation click event. This behavior is confusing for the empty area in the actions row. This CL changes the behavior to ignore such clicks by overriding OnMousePressed in NotificationViewMD. TEST=manual BUG= 775875 Change-Id: Id10437f031e7c462b6d0f4a5a272342b4f4142f9 Reviewed-on: https://chromium-review.googlesource.com/754421 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#514898} [modify] https://crrev.com/6c144779d6b9194e60efd8dddddce5b825956e2a/ui/message_center/views/notification_view_md.cc [modify] https://crrev.com/6c144779d6b9194e60efd8dddddce5b825956e2a/ui/message_center/views/notification_view_md.h
,
Nov 8 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by yoshiki@chromium.org
, Nov 2 2017Owner: tetsui@chromium.org