Regression: The separator line should be visible between the current page entry and the new page entry on chrome://settings
Reported by
vineetha...@etouch.net,
Oct 18 2017
|
|||
Issue descriptionChrome version: 63.0.3239.9 4e280fc118ef968a7faaf87ddfd1f4c3cd6fa3bb-refs/branch-heads/3239@{#38}(32/64 bit) OS: Windows (7,8,10),Linux (14.04 LTS), Mac(10.12.6). Precondition: At least one current page and more than 10 new pages should be added in chrome://Settings > Manage on startup pages > Open a specific page or set of pages Steps to reproduce: 1. Launch Chrome. 2. Navigate to chrome://Settings > Manage on startup pages > Open a specific page or set of pages 3. Remove the last entry from the page list , scroll to the top and observe. Actual Result: The separator line is not visible between the current page entry and the new page entry after deleting the last entry from the list. Expected Result: The separator line should be visible between the current page entry and the new page entry. This is Regression Issue broken in M-63 and and Using the per-revision bisect providing the bisect results, Good Build: 63.0.3211.0(Revision: 500754) Bad Build: 63.0.3212.0(Revision: 500792) You are probably looking for a change made after 500771 (known good), but no later than 500772 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/8316ce5af3eaa219e5b9705db4ccef535d8ad1e0..c9a3169d206e066bf33f3b4e399cce5ac0782c61 Suspect : https://chromium.googlesource.com/chromium/src/+/c9a3169d206e066bf33f3b4e399cce5ac0782c61 @dschuyler : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7492bd8fb7d69396841bf4a53a4ae6743843bcdb commit 7492bd8fb7d69396841bf4a53a4ae6743843bcdb Author: Dave Schuyler <dschuyler@chromium.org> Date: Fri Oct 20 19:32:07 2017 [CR webui] fix iron-list element separators. This CL changes from using :first-of-type to first$="[[!index]]" to determine whether an iron-list element is the first element, which is more robust. Bug: 775869 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If623593c167dff0f5ea336bfc04573738a967968 Reviewed-on: https://chromium-review.googlesource.com/729714 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#510519} [modify] https://crrev.com/7492bd8fb7d69396841bf4a53a4ae6743843bcdb/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html [modify] https://crrev.com/7492bd8fb7d69396841bf4a53a4ae6743843bcdb/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html [modify] https://crrev.com/7492bd8fb7d69396841bf4a53a4ae6743843bcdb/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html [modify] https://crrev.com/7492bd8fb7d69396841bf4a53a4ae6743843bcdb/ui/webui/resources/cr_elements/shared_style_css.html
,
Oct 26 2017
I believe this issue has existed for some time, so merging into m-63 doesn't appear urgent. tbuckley@ agreed, please ask tbuckley@ if this desired for an m-63 merge.
,
Nov 8 2017
Verified on M64 dev build (10109.0.0, 64.0.3261.0). |
|||
►
Sign in to add a comment |
|||
Comment 1 by dschuyler@chromium.org
, Oct 19 2017