New issue
Advanced search Search tips

Issue 775868 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 3
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in SkPathRef::countVerbs

Project Member Reported by ClusterFuzz, Oct 18 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5063957760180224

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x60b000000488
Crash State:
  SkPathRef::countVerbs
  SkPath::isEmpty
  GrCCPRCoverageOpsBuilder::parsePath
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=509426:509661

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5063957760180224

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 18 2017

Labels: Test-Predator-AutoOwner
Owner: csmartdalton@google.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://skia.googlesource.com/skia/+/a2ac30da36c80f616c909c671a240f2d468db124 (Enable CCPR for volatile paths).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 18 2017

Labels: M-63
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 18 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 18 2017

Labels: Pri-1
Labels: -Pri-1 -Security_Impact-Head Security_Impact-None Pri-3
Project Member

Comment 6 by ClusterFuzz, Oct 18 2017

Labels: OS-Mac
Project Member

Comment 7 by sheriffbot@chromium.org, Oct 19 2017

Labels: -ReleaseBlock-Stable

Comment 8 by mmoroz@chromium.org, Oct 24 2017

For more information, please see https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md.

The link referenced in the description is no longer valid.
Status: Fixed (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c9259938599dbc41ba3d965876e35c59f483476

commit 4c9259938599dbc41ba3d965876e35c59f483476
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Tue Nov 07 05:10:38 2017

Roll src/third_party/skia/ 61ffd53a9..b49d7b011 (5 commits)

https://skia.googlesource.com/skia.git/+log/61ffd53a9065..b49d7b011878

$ git log 61ffd53a9..b49d7b011 --date=short --no-merges --format='%ad %ae %s'
2017-11-06 liyuqian This is a reland of 67340. This CL fixes the broken layout tests by preserving the containedInClip boolean. We will eventually remove it and rebaseline the layout tests.
2017-11-06 csmartdalton Fix dangling pointers when Ganesh culls CCPR Ops early
2017-11-06 bsalomon Make GrAtlasTextBlob return to caller when a flush is required during subrun tessellation.
2017-11-06 rmistry Add section for how to connect to Skia swarming bots
2017-11-06 csmartdalton Add clipping options to path text bench and samples

Created with:
  roll-dep src/third_party/skia
BUG= 775868 


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: I196d21665444bf771dad313b9639952e767545aa
Reviewed-on: https://chromium-review.googlesource.com/756475
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514400}
[modify] https://crrev.com/4c9259938599dbc41ba3d965876e35c59f483476/DEPS

Project Member

Comment 12 by ClusterFuzz, Nov 7 2017

ClusterFuzz has detected this issue as fixed in range 514325:514357.

Detailed report: https://clusterfuzz.com/testcase?key=5063957760180224

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x60b000000488
Crash State:
  SkPathRef::countVerbs
  SkPath::isEmpty
  GrCCPRCoverageOpsBuilder::parsePath
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=509426:509661
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=514325:514357

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5063957760180224

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, Nov 7 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5063957760180224 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by sheriffbot@chromium.org, Nov 7 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner

Comment 16 by mmoroz@google.com, Nov 27 2017

Cc: enne@chromium.org
Project Member

Comment 17 by sheriffbot@chromium.org, Feb 13 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment