New issue
Advanced search Search tips

Issue 775848 link

Starred by 3 users

Issue metadata

Status: Archived
Owner: ----
Closed: Sep 13
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug

Blocked on:
issue 713030
issue 780409

Blocking:
issue 783540
issue 775847



Sign in to add a comment

Eng: Enable Harmony Dialogs on Windows, Linux and Mac.

Project Member Reported by tapted@chromium.org, Oct 18 2017

Issue description

Bug for engineering work for Issue 775847 "Enable Harmony Dialogs on Windows, Linux and Mac".
 

Comment 1 by tapted@chromium.org, Oct 19 2017

https://chromium-review.googlesource.com/c/chromium/src/+/725160 -> converts --secondary-ui-md into a feature flag
https://chromium-review.googlesource.com/c/chromium/src/+/725201 -> splits dialogs on Mac
https://chromium-review.googlesource.com/c/chromium/src/+/725205 -> enables --secondary-ui-md by default

jobs in that last one are red, which is blocking landing. I'll ping  Issue 713030 

Comment 2 by tapted@chromium.org, Oct 19 2017

Blockedon: 713030
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9efc45358e4a44c4e4b096294e9278b786578353

commit 9efc45358e4a44c4e4b096294e9278b786578353
Author: Trent Apted <tapted@chromium.org>
Date: Mon Oct 23 11:09:38 2017

Convert --secondary-ui-md into a feature flag.

Currently, if we were to enable --secondary-ui-md by default, there
would be no way for a user to *disable* it. That's no good.

Rather than have two flags, convert the extisting setup into base::Feature.
This is needed anyway for eventual rollout via Finch.

Bug:  775848 
Change-Id: I9da0908456b8df3562cd53d4afb18b144d81c183
Reviewed-on: https://chromium-review.googlesource.com/725160
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510764}
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/chrome/browser/about_flags.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/chrome/browser/download/download_danger_prompt_browsertest.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/chrome/browser/ui/cocoa/bubble_anchor_helper_views_unittest.mm
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/chrome/browser/ui/cocoa/location_bar/zoom_decoration_unittest.mm
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_interactive_uitest.mm
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/chrome/browser/ui/collected_cookies_browsertest.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/chrome/browser/ui/extensions/extension_installed_bubble_browsertest.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/chrome/browser/ui/test/test_browser_dialog.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/chrome/browser/ui/test/test_browser_dialog.h
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/chrome/browser/ui/update_chrome_dialog_browsertest.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/chrome/browser/ui/views/harmony/layout_provider_unittest.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views_browsertest.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/chrome/browser/ui/views/try_chrome_dialog_browsertest.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/ui/base/BUILD.gn
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/ui/base/material_design/material_design_controller.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/ui/base/material_design/material_design_controller.h
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/ui/base/test/material_design_controller_test_api.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/ui/base/test/material_design_controller_test_api.h
[add] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/ui/base/ui_base_features.cc
[add] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/ui/base/ui_base_features.h
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/ui/base/ui_base_switches.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/ui/base/ui_base_switches.h
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/ui/views/controls/label_unittest.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/ui/views/controls/styled_label_unittest.cc
[modify] https://crrev.com/9efc45358e4a44c4e4b096294e9278b786578353/ui/views/win/hwnd_message_handler.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/750ba7027d0a8d62aa843a0d27c2f13365022ca8

commit 750ba7027d0a8d62aa843a0d27c2f13365022ca8
Author: Trent Apted <tapted@chromium.org>
Date: Mon Oct 23 13:36:25 2017

Split toolkit-views dialog plumbing on Mac into "Pilot" and "All" categories.

Pilot dialogs will be put behind --secondary-ui-md.
Other dialogs get a separate, chrome://flags/#show-all-dialogs-with-views-toolkit

This allows us to roll out Harmony UI to Mac in stages on Mac, where it is a
major change.

A side-effect of this CL means that with just pilot dialogs, some Cocoa
dialogs will be anchored differently, even though they still use an arrow.

The first round of pilot dialogs are:
 - Add Bookmark (bubble)
 - HTTP Auth (tab modal)
 - Upgrade chrome (window modal)
 - Zoom (bubble)

Bug:  775848 
Change-Id: If127171ebeb9f626219036aa9696d7626b81d989
Reviewed-on: https://chromium-review.googlesource.com/725201
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510779}
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/about_flags.cc
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_views.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_views.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/browser_dialogs_views_mac.cc
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/browser_dialogs_views_mac.h
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/confirm_bubble_views_mac.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/external_protocol_dialog_views_mac.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/first_run_bubble_controller.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/global_error_bubble_controller.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/login_handler_cocoa.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/password_reuse_warning_dialog_cocoa.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/permission_bubble/chooser_bubble_ui_views_mac.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/permission_bubble/permission_prompt_impl_views_mac.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/simple_message_box_bridge_views.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/collected_cookies_browsertest.cc
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/extensions/extension_installed_bubble_browsertest.cc
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/javascript_dialogs/javascript_dialog_mac.cc
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/test/test_browser_dialog.cc
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/common/chrome_features.cc
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/chrome/common/chrome_features.h
[modify] https://crrev.com/750ba7027d0a8d62aa843a0d27c2f13365022ca8/tools/metrics/histograms/enums.xml

Blockedon: 780409
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eca7aba022c190ea02e34dbd4ae52a8f5f88bbc

commit 1eca7aba022c190ea02e34dbd4ae52a8f5f88bbc
Author: Trent Apted <tapted@chromium.org>
Date: Thu Nov 02 01:34:13 2017

Enable kSecondaryUiMd by default on Windows and Desktop Linux.

Mac will follow shortly (blocked on crbug/780409).

This enables Harmony dialogs on Windows and Desktop Linux.

Current roadmap is to enable this for 2 weeks in m64 to collect
feedback and issues, then disable well before branch point.

Bug:  775848 
Change-Id: Ifa5d54568daa79fb701c958c4c4b293c48f821dc
Reviewed-on: https://chromium-review.googlesource.com/725205
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513361}
[modify] https://crrev.com/1eca7aba022c190ea02e34dbd4ae52a8f5f88bbc/ui/base/ui_base_features.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b6e8fe1fcf17e0545c688d1bfda16d6f79fd97e

commit 6b6e8fe1fcf17e0545c688d1bfda16d6f79fd97e
Author: Trent Apted <tapted@chromium.org>
Date: Mon Nov 06 13:45:29 2017

Enable SecondaryUiMd and ShowAllDialogsWithViewsToolkit on Mac

We've decided to flip both flags for the experiment on dev and
canary on m64.

This causes all Cocoa dialogs on Mac to be displayed with the
views toolkit, and use Harmony styling.

These will be flipped back on all platforms well before m64 branches
into beta.

Bug:  775848 
Change-Id: I09520b09fad396afb1dde32d1f507802f05e25db
Reviewed-on: https://chromium-review.googlesource.com/750444
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514117}
[modify] https://crrev.com/6b6e8fe1fcf17e0545c688d1bfda16d6f79fd97e/chrome/common/chrome_features.cc
[modify] https://crrev.com/6b6e8fe1fcf17e0545c688d1bfda16d6f79fd97e/ui/base/ui_base_features.cc

Comment 8 by tapted@chromium.org, Nov 10 2017

Blocking: 783540
Status: Archived (was: Available)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Sign in to add a comment