New issue
Advanced search Search tips

Issue 775845 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Turning on the ‘Search and Site suggestions’ are not displaying Articles for you.

Project Member Reported by rakurati@chromium.org, Oct 18 2017

Issue description

App Version: 64.0.3242.0 Canary
iOS Version: 10.3.3, 11.1 beta 3
Device: iPhone and iPad

Steps to reproduce:
1. Launch chrome
2. Open settings>>Privacy and disable ‘search and site suggestions’
3. Close the settings tab and open new tab page
4. Go to settings>>Privacy and enable ‘search and site suggestions’
5. Open new tab page

Observed results:
List of articles are not displayed instead a message is displayed ‘That’s all for now’

Expected results:
List of articles should be displayed

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): No on M62(62.0.3202.60 which will be submitting to app store soon)
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M63 beta

Link to video/image:

M64 behavior:
https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8eWlsT1JlVkxMSUk/view?usp=sharing
M62 behavior:
https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8dTkyNzRiWm41eUU/view?usp=sharing

 

Comment 1 by sczs@chromium.org, Oct 18 2017

Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)
gambard@ could you PTAL
Cc: treib@chromium.org
treib@: is this WAI?
The SuggestionsService is returning 0 suggestions (suggestions_by_category_ has no entry for Articles for You).

Comment 3 by treib@chromium.org, Oct 19 2017

Cc: vitaliii@chromium.org jkrcal@chromium.org
I'm guessing this is related to some changes to how fetching is scheduled - looks like we don't automatically fetch anymore when the setting is turned on.
Adding people who might know more :)
Labels: zine-triaged
ping: vitaliii@, jkrcal@

Comment 6 by jkrcal@chromium.org, Oct 25 2017

Sorry for the delay. 

A quick question:
Is the toggle implemented via prefs::kSearchSuggestEnabled on iOS as well?
Yes: https://cs.chromium.org/chromium/src/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory_util.cc?sq=package:chromium&dr=C&l=188
However, this pref is defined in the iOS pref list, so it is probably not common with the Android one.

Comment 8 by jkrcal@chromium.org, Oct 25 2017

Huh, this is broken on Android too.
It is most probably related to https://chromium-review.googlesource.com/c/chromium/src/+/702316, working on a fix.
Cc: gambard@chromium.org
Labels: OS-Android
Owner: jkrcal@chromium.org
Ok, I am assigning it to you then.
Components: -UI>Browser>NewTabPage UI>Browser>ContentSuggestions
FYI, jkrcal@ is OOO until 6th of November.
The mentioned fix is probably https://chromium-review.googlesource.com/c/chromium/src/+/737835.
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1584eeb46b45cc7370a5bd830ee171c56590a48

commit c1584eeb46b45cc7370a5bd830ee171c56590a48
Author: Jan Krcal <jkrcal@chromium.org>
Date: Tue Nov 14 22:49:18 2017

[Scheduler] Queue the next fetch after clearing suggestions

A recent change removed from RemoteSuggestionsProvider queuing of
delayed requests (i.e. requests while the provider is not ready).
The change relied on the Scheduler implementing such a queue for
delayed requests itself. However, one code path in the Scheduler
skipped its internal queue: triggering a fetch right after clearing
the suggestions. Suggestions are cleared when the user signs-in,
signs-out, or disables the feature.

This CL fixes this code path. When clearing suggestions after this CL,
the scheduler queues delayed requests (instead of immediately
triggering the provider).

One effect of the change is that the fetch is now issued in the form of
a RefetchWhileDisplaying() call and not a ReloadSuggestions() call.

Bug:  775845 
Change-Id: I94aa3cf349493b2ca8a416689bd12f29ef78d784
Reviewed-on: https://chromium-review.googlesource.com/737835
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516476}
[modify] https://crrev.com/c1584eeb46b45cc7370a5bd830ee171c56590a48/components/ntp_snippets/remote/remote_suggestions_scheduler_impl.cc
[modify] https://crrev.com/c1584eeb46b45cc7370a5bd830ee171c56590a48/components/ntp_snippets/remote/remote_suggestions_scheduler_impl.h
[modify] https://crrev.com/c1584eeb46b45cc7370a5bd830ee171c56590a48/components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc

Gauthier, should be fixed now. Can you please take a look when a new Canary is out?
It looks like it is fixed on developer build.
Status: Fixed (was: Assigned)
Verified in 64.0.3276.0 Canary in iPhone 8plus(iOS 11.2 beta4) and iPad mini(iOS 10.3.3)

List of content suggestions are displaying fine when search and suggestions are turn on, looks good
Status: Verified (was: Fixed)
Verified in 64.0.3282.85 beta iPhone 6 iOS 10.3.3, iPhone 7 iOS11, iPad Pro iOS11
Looks good.

Sign in to add a comment