New issue
Advanced search Search tips

Issue 775837 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug

Blocking:
issue 775899



Sign in to add a comment

[Password manager] Save prompt after failed attempt on yandex.ru

Project Member Reported by se...@yandex-team.ru, Oct 18 2017

Issue description

Chrome Version: 64.0.3242.0 (canary)

What steps will reproduce the problem?
(1) Open yandex.ru.
(2) Enter invalid username/password.
(3) Press submit.

What is the expected result?
Save password prompt is not shown.

What happens instead?
Save password prompt is shown.
 
Status: Started (was: Assigned)

Comment 2 by vabr@chromium.org, Oct 19 2017

Blocking: 775899
Labels: Hotlist-Polish
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab1b0ba3474365bd26dbb5699c40591eca44f2d8

commit ab1b0ba3474365bd26dbb5699c40591eca44f2d8
Author: Alexey Khoroshilov <sense@yandex-team.ru>
Date: Mon Oct 23 09:04:33 2017

[Password Manager] Improve password form reappear detection.

This CL adds field identifiers and content comparison to match
reappeared password form.

BUG= 775837 
R=dvadym@chromium.org

Change-Id: Ideb9543a9f8958f37dc6541b4d4878b82d7df643
Reviewed-on: https://chromium-review.googlesource.com/725282
Commit-Queue: Alexey Khoroshilov <sense@yandex-team.ru>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510742}
[modify] https://crrev.com/ab1b0ba3474365bd26dbb5699c40591eca44f2d8/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/ab1b0ba3474365bd26dbb5699c40591eca44f2d8/chrome/test/data/password/done_and_unrelated_form.html
[add] https://crrev.com/ab1b0ba3474365bd26dbb5699c40591eca44f2d8/chrome/test/data/password/failed_contains_username.html
[add] https://crrev.com/ab1b0ba3474365bd26dbb5699c40591eca44f2d8/chrome/test/data/password/failed_different_action.html
[modify] https://crrev.com/ab1b0ba3474365bd26dbb5699c40591eca44f2d8/chrome/test/data/password/password_form.html
[modify] https://crrev.com/ab1b0ba3474365bd26dbb5699c40591eca44f2d8/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/ab1b0ba3474365bd26dbb5699c40591eca44f2d8/components/password_manager/core/browser/password_manager_unittest.cc

Status: Fixed (was: Started)
Cc: -vabr@chromium.org

Sign in to add a comment