New issue
Advanced search Search tips

Issue 775830 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 841653



Sign in to add a comment

Mojofy content/common/clipboard_messages.h

Project Member Reported by slangley@chromium.org, Oct 18 2017

Issue description

Convert all IPCs to mojo
Remove content/common/clipboard_messages.h
Onion Soup where possible.

 
Labels: -Pri-3 Pri-2
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48300395311db1aa2677e91c4eaeed51f20d7e59

commit 48300395311db1aa2677e91c4eaeed51f20d7e59
Author: Stuart Langley <slangley@chromium.org>
Date: Thu Nov 02 03:54:44 2017

Change custom data type from map to unordered_map in preperation for mojofication.

clipboard_messages currently defines a CustomDataMap as:

typedef std::map<base::string16, base::string16> CustomDataMap;

When this moves to mojo is will become an unordered_map - this work is to make this
change now so we can make sure it doesn't introduce and side effects.

Bug:  775830 
Change-Id: I6bb8fc854027e3735bb0f5afd831a411bba82f8f
Reviewed-on: https://chromium-review.googlesource.com/749606
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513398}
[modify] https://crrev.com/48300395311db1aa2677e91c4eaeed51f20d7e59/content/browser/renderer_host/clipboard_message_filter.cc
[modify] https://crrev.com/48300395311db1aa2677e91c4eaeed51f20d7e59/content/browser/renderer_host/clipboard_message_filter.h
[modify] https://crrev.com/48300395311db1aa2677e91c4eaeed51f20d7e59/content/common/clipboard_messages.h
[modify] https://crrev.com/48300395311db1aa2677e91c4eaeed51f20d7e59/content/public/common/drop_data.h
[modify] https://crrev.com/48300395311db1aa2677e91c4eaeed51f20d7e59/content/renderer/render_widget.cc
[modify] https://crrev.com/48300395311db1aa2677e91c4eaeed51f20d7e59/content/renderer/renderer_clipboard_delegate.cc
[modify] https://crrev.com/48300395311db1aa2677e91c4eaeed51f20d7e59/content/renderer/renderer_clipboard_delegate.h
[modify] https://crrev.com/48300395311db1aa2677e91c4eaeed51f20d7e59/ipc/ipc_message_utils.h
[modify] https://crrev.com/48300395311db1aa2677e91c4eaeed51f20d7e59/ui/base/clipboard/clipboard_util_win.cc
[modify] https://crrev.com/48300395311db1aa2677e91c4eaeed51f20d7e59/ui/base/clipboard/clipboard_util_win.h
[modify] https://crrev.com/48300395311db1aa2677e91c4eaeed51f20d7e59/ui/base/clipboard/custom_data_helper.cc
[modify] https://crrev.com/48300395311db1aa2677e91c4eaeed51f20d7e59/ui/base/clipboard/custom_data_helper.h
[modify] https://crrev.com/48300395311db1aa2677e91c4eaeed51f20d7e59/ui/base/clipboard/custom_data_helper_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e830001af5df676765a3cf3567053e4eb342c232

commit e830001af5df676765a3cf3567053e4eb342c232
Author: Stuart Langley <slangley@chromium.org>
Date: Fri Nov 24 01:16:18 2017

Convert clipboard_messages from IPC to Mojo.

Convert all of the IPC messages in content/common/clipboard_messages.h
to Mojo. This CL includes a number of changes as a result:

- Remove the Dispatch of messages for OS_WIN on the IO thread. The requirement
  to do this seems to be inspired by deadlocks with NPAPI plugins, but as
  NPAPI is now persona non grata we can remove this and all the code that
  existed to support it.
- interstitial page test was inserting a message_filter to intercept write calls
  to the clipboard - replace this with a ClipboardObserver and have the
  test_clipboard fire the event for observation. This also caused TSAN failures,
  so we can re-enable the cut test under TSAN now.
- Remove the clipboard delegate entirely, and move some logic to write
  images to shared memory for transport to the impl file now.

Bug:  775830 ,  631322 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I35c6238a41190b3bc82e0cfab7bbfe4325a3be21
Reviewed-on: https://chromium-review.googlesource.com/752861
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519040}
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/browser/BUILD.gn
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/browser/frame_host/interstitial_page_impl_browsertest.cc
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/browser/renderer_host/clipboard_host_impl.cc
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/browser/renderer_host/clipboard_host_impl.h
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/browser/renderer_host/clipboard_host_impl_mac.mm
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/browser/renderer_host/clipboard_host_impl_unittest.cc
[delete] https://crrev.com/ad2ac19bbe6a4b4ec874aef844059819e95d2676/content/browser/renderer_host/clipboard_message_filter.cc
[delete] https://crrev.com/ad2ac19bbe6a4b4ec874aef844059819e95d2676/content/browser/renderer_host/clipboard_message_filter.h
[delete] https://crrev.com/ad2ac19bbe6a4b4ec874aef844059819e95d2676/content/browser/renderer_host/clipboard_message_filter_mac.mm
[delete] https://crrev.com/ad2ac19bbe6a4b4ec874aef844059819e95d2676/content/browser/renderer_host/clipboard_message_filter_unittest.cc
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/common/BUILD.gn
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/common/clipboard.mojom
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/common/clipboard.typemap
[delete] https://crrev.com/ad2ac19bbe6a4b4ec874aef844059819e95d2676/content/common/clipboard_messages.h
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/common/clipboard_struct_traits.h
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/common/content_message_generator.h
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/common/typemaps.gni
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/public/test/browser_test_utils.h
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/renderer/BUILD.gn
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/renderer/renderer_blink_platform_impl.h
[delete] https://crrev.com/ad2ac19bbe6a4b4ec874aef844059819e95d2676/content/renderer/renderer_clipboard_delegate.cc
[delete] https://crrev.com/ad2ac19bbe6a4b4ec874aef844059819e95d2676/content/renderer/renderer_clipboard_delegate.h
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/renderer/webclipboard_impl.cc
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/renderer/webclipboard_impl.h
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/content/test/BUILD.gn
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/ui/base/clipboard/mojom/BUILD.gn
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/ui/base/clipboard/mojom/OWNERS
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/ui/base/clipboard/mojom/clipboard.mojom
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/ui/base/clipboard/mojom/clipboard.typemap
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/ui/base/clipboard/mojom/clipboard_struct_traits.h
[add] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/ui/base/clipboard/mojom/typemaps.gni
[modify] https://crrev.com/e830001af5df676765a3cf3567053e4eb342c232/ui/base/test/test_clipboard.cc

Rough outline of plans to Onion Soup WebClipboard.

1. Move the definition of WebClipboard::Buffer and WebClipboard::Format into mojo, replace everywhere. Remove existing type maps from clipboard.mojom.

2. Move webclipboard_impl into core/exported and inject it via platform/exported/Platform.cpp

3. Fix tests to inject MockWebClipboard into Mojo.

4. (Try) and move logic from Renderer side to Browser side and see it we can delete webclipboard_impl altogether.

5. Add back typemap for ui::Clipboard to automagically marshal the mojo type on browser side.
Cc: dcheng@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f843cc37b3b95af2c382197e4c96997ee95c32a

commit 4f843cc37b3b95af2c382197e4c96997ee95c32a
Author: Stuart Langley <slangley@chromium.org>
Date: Mon Dec 04 21:56:54 2017

Start Onion Soup of WebClipboard, by moving shared enums to mojom.

This CL is preparation for onion souping of WebClipboard.

It moves public enum types from WebClipboard into a mojom file
defined in WebKit/common.

The clipboard mojo interface is then changed to use these enums
rather than the type defined in ui/base/clipboard.

Typemaps for clipboard_format and ui::ClipboardType have been
removed as we no longer use these types in the mojom, and
it will make it simpler to move the files around. We may
add type-mapping back in when we've removed WebClipboard.

Code that previously converted from WebClipboard::Buffer to
ui::Clipboard has been moved to the browser side, on the
renderer side we still check that the Buffer type is valid,
but we no longer do the conversion.

The ultimate goal is to replace WebClipboard with the mojo
interface.

Bug:  775830 
Change-Id: I2cf4e7fc771dd66c4b6ec95abc7d131686683d52
Reviewed-on: https://chromium-review.googlesource.com/804774
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521478}
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/content/browser/renderer_host/clipboard_host_impl.cc
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/content/browser/renderer_host/clipboard_host_impl.h
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/content/browser/renderer_host/clipboard_host_impl_unittest.cc
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/content/common/BUILD.gn
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/content/common/clipboard.mojom
[delete] https://crrev.com/80428a9587801289b331674365fc09523319288c/content/common/clipboard.typemap
[delete] https://crrev.com/80428a9587801289b331674365fc09523319288c/content/common/clipboard_format.h
[delete] https://crrev.com/80428a9587801289b331674365fc09523319288c/content/common/clipboard_struct_traits.h
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/content/common/typemaps.gni
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/content/renderer/pepper/pepper_webplugin_impl.cc
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/content/renderer/webclipboard_impl.cc
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/content/renderer/webclipboard_impl.h
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/content/shell/test_runner/pixel_dump.cc
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/content/test/mock_webclipboard_impl.cc
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/content/test/mock_webclipboard_impl.h
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/third_party/WebKit/Source/core/clipboard/DataObject.cpp
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/third_party/WebKit/Source/core/clipboard/DataObjectItem.cpp
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/third_party/WebKit/Source/core/clipboard/Pasteboard.cpp
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/third_party/WebKit/Source/core/clipboard/Pasteboard.h
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/third_party/WebKit/Source/core/exported/WebPluginContainerTest.cpp
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/third_party/WebKit/Source/modules/clipboard/BUILD.gn
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/third_party/WebKit/Source/modules/clipboard/ClipboardPromise.cpp
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/third_party/WebKit/Source/modules/clipboard/ClipboardPromise.h
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/third_party/WebKit/common/BUILD.gn
[add] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/third_party/WebKit/common/clipboard/OWNERS
[add] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/third_party/WebKit/common/clipboard/clipboard.mojom
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/third_party/WebKit/public/platform/WebClipboard.h
[modify] https://crrev.com/4f843cc37b3b95af2c382197e4c96997ee95c32a/third_party/WebKit/public/platform/WebMockClipboard.h
[delete] https://crrev.com/80428a9587801289b331674365fc09523319288c/ui/base/clipboard/mojom/BUILD.gn
[delete] https://crrev.com/80428a9587801289b331674365fc09523319288c/ui/base/clipboard/mojom/OWNERS
[delete] https://crrev.com/80428a9587801289b331674365fc09523319288c/ui/base/clipboard/mojom/clipboard.mojom
[delete] https://crrev.com/80428a9587801289b331674365fc09523319288c/ui/base/clipboard/mojom/clipboard.typemap
[delete] https://crrev.com/80428a9587801289b331674365fc09523319288c/ui/base/clipboard/mojom/clipboard_struct_traits.h
[delete] https://crrev.com/80428a9587801289b331674365fc09523319288c/ui/base/clipboard/mojom/typemaps.gni

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdd23baca689698b9f209d20a420be712c197ef4

commit fdd23baca689698b9f209d20a420be712c197ef4
Author: Stuart Langley <slangley@chromium.org>
Date: Wed Dec 13 01:04:14 2017

Onion Soup WebClipboard - move clipboard.mojom to WebKit/common/clipboard.

This continues the work to onion soup WebClipboard.

- The mojo definition for ClipboardHost is moved from content/common to
  WebKit/common/clipboard.
- The implementation of WebClipboard, content/renderer/webclipboard_impl.* is
  moved to WebKit/Source/platform/expored/WebClipboardImpl.*.
- Fixed the implementation of WebClipboardImpl to use the blink types (
  WTF::String etc) directly rather than WebString.
- Plagiarized parts of DropDataBuilder and URLToImageMarkup as we need to keep
  implementations in content for MockWebClipboardImpl.
- Removed the interface binding from renderer_blink_platform_impl to
  WebClipboardImpl and render_frame_impl (for MACOSX only).
- Instantiate WebClipboardImpl in Platform.cpp (temporary until we can remove
  Clipboard() from platform.)


We cannot remove Platform::Clipboard yet because it is used by
pepper_webplugin_impl, will need see if we can move pepper to use mojo instead.

Next steps;

- Remove MockWebClipboardImpl and mock out at the mojo level instead of
  Platform.
- Provide typemap for blink::mojo::ClipboardBuffer to ui::Clipboard for browser.
- Remove Clipboard() from Platform by fixing pepper.
- Delete public/platform/WebClipboard definition.

Note: Gerrit is not showing which files are renames + modifications, the list is

content/renderer/webclipboard_impl* : Source/platform/exported/WebClipboardImpl*
content/common/clipboard.mojom : WebKit/common/clipboard/clipboard.mojom

Bug:  775830 
Change-Id: Ife7121886fe133cc7577cd1ce8f1d90262d97102
Reviewed-on: https://chromium-review.googlesource.com/809824
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523640}
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/content/browser/frame_host/interstitial_page_impl_browsertest.cc
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/content/browser/renderer_host/clipboard_host_impl.cc
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/content/browser/renderer_host/clipboard_host_impl.h
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/content/common/BUILD.gn
[delete] https://crrev.com/4ee0fd38b4d6979c8642251da3079473f67b25dd/content/common/clipboard.mojom
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/content/renderer/BUILD.gn
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/content/renderer/clipboard_utils.cc
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/content/renderer/clipboard_utils.h
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/content/renderer/render_frame_impl.h
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/content/renderer/renderer_blink_platform_impl.h
[delete] https://crrev.com/4ee0fd38b4d6979c8642251da3079473f67b25dd/content/renderer/webclipboard_impl.cc
[delete] https://crrev.com/4ee0fd38b4d6979c8642251da3079473f67b25dd/content/renderer/webclipboard_impl.h
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/content/renderer/webclipboard_impl_browsertest.cc
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/content/test/mock_webclipboard_impl.cc
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/content/test/mock_webclipboard_impl.h
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/third_party/WebKit/Source/platform/exported/Platform.cpp
[add] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/third_party/WebKit/Source/platform/exported/WebClipboardImpl.cpp
[add] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/third_party/WebKit/Source/platform/exported/WebClipboardImpl.h
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/third_party/WebKit/common/BUILD.gn
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/third_party/WebKit/common/clipboard/clipboard.mojom
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/third_party/WebKit/public/platform/Platform.h
[modify] https://crrev.com/fdd23baca689698b9f209d20a420be712c197ef4/third_party/WebKit/public/platform/WebClipboard.h

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edf12cc9a016371ca930e0771acf164bdffbcd17

commit edf12cc9a016371ca930e0771acf164bdffbcd17
Author: Stuart Langley <slangley@chromium.org>
Date: Sat Dec 16 05:27:56 2017

Use typemap to convert blink::mojom::ClipboardBuffer to ui::ClipboardType.

We removed this typemap when moving the mojom into WebKit, now we add it
back to do the marshaling between ClipboardBuffer and ClipboardType on
the browser side.

As we don't intend at this time to send messages of this type in the
opposite direction we only implement the FromMojom method in
clipboard_struct_traits.

Bug:  775830 
Change-Id: Ib3dacbcc5b3c029167e902afbf7c8c5c809f1ee9
Reviewed-on: https://chromium-review.googlesource.com/823542
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524593}
[modify] https://crrev.com/edf12cc9a016371ca930e0771acf164bdffbcd17/content/browser/renderer_host/clipboard_host_impl.cc
[modify] https://crrev.com/edf12cc9a016371ca930e0771acf164bdffbcd17/content/browser/renderer_host/clipboard_host_impl.h
[modify] https://crrev.com/edf12cc9a016371ca930e0771acf164bdffbcd17/content/browser/renderer_host/clipboard_host_impl_unittest.cc
[modify] https://crrev.com/edf12cc9a016371ca930e0771acf164bdffbcd17/ui/base/mojo/DEPS
[add] https://crrev.com/edf12cc9a016371ca930e0771acf164bdffbcd17/ui/base/mojo/clipboard.typemap
[add] https://crrev.com/edf12cc9a016371ca930e0771acf164bdffbcd17/ui/base/mojo/clipboard_struct_traits.h
[modify] https://crrev.com/edf12cc9a016371ca930e0771acf164bdffbcd17/ui/base/mojo/typemaps.gni

Owner: ----
still needs onion souping.
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c63d7cda22ea96f712b41bbedc2421ba788addbd

commit c63d7cda22ea96f712b41bbedc2421ba788addbd
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu Apr 26 17:23:16 2018

Use mojom::ClipboardHost directly in PepperWebPluginImpl

... instead of going through blink's platform clipboard.

Bug:  775830 
Change-Id: I3485409765f9d567120b991a05c66f49ac4aa441
Reviewed-on: https://chromium-review.googlesource.com/1027997
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554064}
[modify] https://crrev.com/c63d7cda22ea96f712b41bbedc2421ba788addbd/content/renderer/pepper/pepper_webplugin_impl.cc
[modify] https://crrev.com/c63d7cda22ea96f712b41bbedc2421ba788addbd/content/renderer/pepper/pepper_webplugin_impl.h

Blockedon: 841653
Project Member

Comment 12 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d

commit 0ae5186d1bf72bd375c5cf14c7a762806fe0f29d
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu May 10 17:59:07 2018

Replace WebMockClipboard with MockClipboardHost

This mock clipboard host lives in browser process, essentially synchronizing
clipboard between OOPIFs.

In unit tests we instantiate the mock in-process and override the binder in
Connector so that WebClipboardImpl connects to it.

This patch discovered two issues with clipboard implementation which are being fixed:
- Blacklisting text/uri-list clipboard items does not allow them to be copied
  to clipboard. Old mock implementation masked this issues, while the new one
  exposed the issue caught by multiple tests.
- Unit tests sometime pass null strings to copy to clipboard, so we should
  ensure they are non-null in WebClipboardImpl.

One more semantic change is a rewrite of unit tests which read image from
clipboard to layout tests, where that functionality is available.

The rest is just plumbing of a new mock.

Bug:  775830 ,  607991 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie63552228a9038cfd5e677d9f1bec5a2184662ad
Reviewed-on: https://chromium-review.googlesource.com/1034022
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557582}
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/content/public/browser/browser_context.h
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/content/public/renderer/content_renderer_client.h
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/content/shell/browser/layout_test/blink_test_controller.cc
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/content/shell/browser/layout_test/layout_test_content_browser_client.cc
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/content/shell/browser/layout_test/layout_test_content_browser_client.h
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/content/shell/renderer/layout_test/layout_test_content_renderer_client.h
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/content/shell/test_runner/DEPS
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/content/shell/test_runner/pixel_dump.cc
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/content/test/BUILD.gn
[add] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/content/test/mock_clipboard_host.cc
[add] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/content/test/mock_clipboard_host.h
[delete] https://crrev.com/c8fb1550cf42970f8cb5445e481e3f193df4c910/content/test/mock_webclipboard_impl.cc
[delete] https://crrev.com/c8fb1550cf42970f8cb5445e481e3f193df4c910/content/test/mock_webclipboard_impl.h
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/content/test/test_blink_web_unit_test_support.h
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[add] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/third_party/WebKit/LayoutTests/clipboard/copy-image-at-expected.txt
[add] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/third_party/WebKit/LayoutTests/clipboard/copy-image-at-with-pinch-zoom-expected.txt
[add] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/third_party/WebKit/LayoutTests/clipboard/copy-image-at-with-pinch-zoom.html
[add] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/third_party/WebKit/LayoutTests/clipboard/copy-image-at.html
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/third_party/blink/public/BUILD.gn
[delete] https://crrev.com/c8fb1550cf42970f8cb5445e481e3f193df4c910/third_party/blink/public/platform/web_mock_clipboard.h
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/third_party/blink/renderer/core/exported/web_plugin_container_test.cc
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/third_party/blink/renderer/core/svg/unsafe_svg_attribute_sanitization_test.cc
[delete] https://crrev.com/c8fb1550cf42970f8cb5445e481e3f193df4c910/third_party/blink/renderer/core/testing/data/canvas-copy-image.html
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/third_party/blink/renderer/platform/exported/web_clipboard_impl.cc
[delete] https://crrev.com/c8fb1550cf42970f8cb5445e481e3f193df4c910/third_party/blink/renderer/platform/exported/web_mock_clipboard.cc
[modify] https://crrev.com/0ae5186d1bf72bd375c5cf14c7a762806fe0f29d/ui/base/mojo/clipboard_struct_traits.h

Project Member

Comment 13 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c7daf82b6af9b44fae33c3ad2754834f4416e6c

commit 6c7daf82b6af9b44fae33c3ad2754834f4416e6c
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu May 10 21:15:34 2018

Remove blink::Platform::Clipboard

... since it's not overridden by embedder anymore.

Bug:  775830 
Change-Id: Ic719cb4f542785b5dc198900b3e0fca206ba5e86
Reviewed-on: https://chromium-review.googlesource.com/1045728
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557674}
[modify] https://crrev.com/6c7daf82b6af9b44fae33c3ad2754834f4416e6c/content/ppapi_plugin/ppapi_blink_platform_impl.cc
[modify] https://crrev.com/6c7daf82b6af9b44fae33c3ad2754834f4416e6c/content/ppapi_plugin/ppapi_blink_platform_impl.h
[modify] https://crrev.com/6c7daf82b6af9b44fae33c3ad2754834f4416e6c/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/6c7daf82b6af9b44fae33c3ad2754834f4416e6c/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/6c7daf82b6af9b44fae33c3ad2754834f4416e6c/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/6c7daf82b6af9b44fae33c3ad2754834f4416e6c/third_party/blink/public/platform/platform.h
[delete] https://crrev.com/62d9ab595b111b9600ea79eb17ecd9a5182a3a85/third_party/blink/public/platform/web_clipboard.h
[modify] https://crrev.com/6c7daf82b6af9b44fae33c3ad2754834f4416e6c/third_party/blink/renderer/core/clipboard/data_object.cc
[modify] https://crrev.com/6c7daf82b6af9b44fae33c3ad2754834f4416e6c/third_party/blink/renderer/core/clipboard/data_object_item.cc
[modify] https://crrev.com/6c7daf82b6af9b44fae33c3ad2754834f4416e6c/third_party/blink/renderer/core/clipboard/pasteboard.cc
[modify] https://crrev.com/6c7daf82b6af9b44fae33c3ad2754834f4416e6c/third_party/blink/renderer/core/clipboard/pasteboard.h
[modify] https://crrev.com/6c7daf82b6af9b44fae33c3ad2754834f4416e6c/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/6c7daf82b6af9b44fae33c3ad2754834f4416e6c/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/6c7daf82b6af9b44fae33c3ad2754834f4416e6c/third_party/blink/renderer/core/exported/web_plugin_container_test.cc
[modify] https://crrev.com/6c7daf82b6af9b44fae33c3ad2754834f4416e6c/third_party/blink/renderer/modules/clipboard/clipboard_promise.cc
[modify] https://crrev.com/6c7daf82b6af9b44fae33c3ad2754834f4416e6c/third_party/blink/renderer/platform/exported/platform.cc
[modify] https://crrev.com/6c7daf82b6af9b44fae33c3ad2754834f4416e6c/third_party/blink/renderer/platform/exported/web_clipboard_impl.h
[modify] https://crrev.com/6c7daf82b6af9b44fae33c3ad2754834f4416e6c/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/6c7daf82b6af9b44fae33c3ad2754834f4416e6c/third_party/blink/renderer/platform/testing/testing_platform_support.h

Project Member

Comment 14 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/500de904015c79db792df05e0266fe48ba421596

commit 500de904015c79db792df05e0266fe48ba421596
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Fri May 11 00:40:22 2018

Merge WebClipboardImpl and Pasteboard into Clipboard

Bug:  775830 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3da04418bac37e0e03b63df4a8d2407296948e77
Reviewed-on: https://chromium-review.googlesource.com/1045492
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557739}
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/content/renderer/mojo/blink_interface_provider_impl.h
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/content/test/test_blink_web_unit_test_support.h
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/core/clipboard/BUILD.gn
[add] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/core/clipboard/clipboard.cc
[add] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/core/clipboard/clipboard.h
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/core/clipboard/data_object.cc
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/core/clipboard/data_object.h
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/core/clipboard/data_object_item.cc
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/core/clipboard/data_object_item.h
[delete] https://crrev.com/66a7be19c75e8f63d872a5fe08c40c263e3a71de/third_party/blink/renderer/core/clipboard/pasteboard.cc
[delete] https://crrev.com/66a7be19c75e8f63d872a5fe08c40c263e3a71de/third_party/blink/renderer/core/clipboard/pasteboard.h
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/core/editing/commands/clipboard_commands.cc
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/core/editing/commands/clipboard_commands.h
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/core/editing/editing_utilities.cc
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/core/editing/editing_utilities.h
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/core/editing/editor.cc
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/core/editing/editor_test.cc
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/core/exported/web_plugin_container_test.cc
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/core/inspector/dev_tools_host.cc
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/core/svg/unsafe_svg_attribute_sanitization_test.cc
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/modules/clipboard/clipboard_promise.cc
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/modules/clipboard/clipboard_promise.h
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/platform/clipboard/clipboard_utilities.cc
[modify] https://crrev.com/500de904015c79db792df05e0266fe48ba421596/third_party/blink/renderer/platform/clipboard/clipboard_utilities.h
[delete] https://crrev.com/66a7be19c75e8f63d872a5fe08c40c263e3a71de/third_party/blink/renderer/platform/exported/web_clipboard_impl.cc
[delete] https://crrev.com/66a7be19c75e8f63d872a5fe08c40c263e3a71de/third_party/blink/renderer/platform/exported/web_clipboard_impl.h

Project Member

Comment 15 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ae95dc0eb15b838374180f1c66265c0ced0e163

commit 5ae95dc0eb15b838374180f1c66265c0ced0e163
Author: Timothy Loh <timloh@chromium.org>
Date: Fri May 11 01:15:16 2018

Revert "Merge WebClipboardImpl and Pasteboard into Clipboard"

This reverts commit 500de904015c79db792df05e0266fe48ba421596.

Reason for revert: Breaks linux-jumbo-rel compile as the patch adds a second definition for blink::Clipboard.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-jumbo-rel/1249

Original change's description:
> Merge WebClipboardImpl and Pasteboard into Clipboard
> 
> Bug:  775830 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I3da04418bac37e0e03b63df4a8d2407296948e77
> Reviewed-on: https://chromium-review.googlesource.com/1045492
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557739}

TBR=dgozman@chromium.org,dcheng@chromium.org,haraken@chromium.org

Change-Id: Iae8a29b556f55971515b66a943df7ef812cd44f7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  775830 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1055007
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557750}
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/content/renderer/mojo/blink_interface_provider_impl.h
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/content/test/test_blink_web_unit_test_support.h
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/core/clipboard/BUILD.gn
[delete] https://crrev.com/bc771d8ff8e65b25520749821e64649338282469/third_party/blink/renderer/core/clipboard/clipboard.cc
[delete] https://crrev.com/bc771d8ff8e65b25520749821e64649338282469/third_party/blink/renderer/core/clipboard/clipboard.h
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/core/clipboard/data_object.cc
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/core/clipboard/data_object.h
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/core/clipboard/data_object_item.cc
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/core/clipboard/data_object_item.h
[add] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/core/clipboard/pasteboard.cc
[add] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/core/clipboard/pasteboard.h
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/core/editing/commands/clipboard_commands.cc
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/core/editing/commands/clipboard_commands.h
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/core/editing/editing_utilities.cc
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/core/editing/editing_utilities.h
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/core/editing/editor.cc
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/core/editing/editor_test.cc
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/core/exported/web_plugin_container_test.cc
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/core/inspector/dev_tools_host.cc
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/core/svg/unsafe_svg_attribute_sanitization_test.cc
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/modules/clipboard/clipboard_promise.cc
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/modules/clipboard/clipboard_promise.h
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/platform/clipboard/clipboard_utilities.cc
[modify] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/platform/clipboard/clipboard_utilities.h
[add] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/platform/exported/web_clipboard_impl.cc
[add] https://crrev.com/5ae95dc0eb15b838374180f1c66265c0ced0e163/third_party/blink/renderer/platform/exported/web_clipboard_impl.h

Project Member

Comment 16 by bugdroid1@chromium.org, May 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d5986488f2a31788668698af2a7db9bb3b4bb5c

commit 0d5986488f2a31788668698af2a7db9bb3b4bb5c
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Sun May 13 00:54:51 2018

Reland "Merge WebClipboardImpl and Pasteboard into Clipboard"

This is a reland of 500de904015c79db792df05e0266fe48ba421596

Original change's description:
> Merge WebClipboardImpl and Pasteboard into Clipboard
> 
> Bug:  775830 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I3da04418bac37e0e03b63df4a8d2407296948e77
> Reviewed-on: https://chromium-review.googlesource.com/1045492
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557739}

Bug:  775830 
Change-Id: I921c9c3becf2acf3b169049656e898be6e4b8e1e
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1056427
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558147}
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/content/renderer/mojo/blink_interface_provider_impl.h
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/content/test/test_blink_web_unit_test_support.h
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/core/clipboard/BUILD.gn
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/core/clipboard/data_object.cc
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/core/clipboard/data_object.h
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/core/clipboard/data_object_item.cc
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/core/clipboard/data_object_item.h
[delete] https://crrev.com/23abd9c690d6c74e1a5b653cbdfbfa36b6049cd0/third_party/blink/renderer/core/clipboard/pasteboard.cc
[delete] https://crrev.com/23abd9c690d6c74e1a5b653cbdfbfa36b6049cd0/third_party/blink/renderer/core/clipboard/pasteboard.h
[add] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/core/clipboard/system_clipboard.cc
[add] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/core/clipboard/system_clipboard.h
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/core/editing/commands/clipboard_commands.cc
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/core/editing/commands/clipboard_commands.h
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/core/editing/editing_utilities.cc
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/core/editing/editing_utilities.h
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/core/editing/editor.cc
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/core/editing/editor_test.cc
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/core/exported/web_plugin_container_test.cc
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/core/inspector/dev_tools_host.cc
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/core/svg/unsafe_svg_attribute_sanitization_test.cc
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/modules/clipboard/clipboard_promise.cc
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/modules/clipboard/clipboard_promise.h
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/platform/clipboard/clipboard_utilities.cc
[modify] https://crrev.com/0d5986488f2a31788668698af2a7db9bb3b4bb5c/third_party/blink/renderer/platform/clipboard/clipboard_utilities.h
[delete] https://crrev.com/23abd9c690d6c74e1a5b653cbdfbfa36b6049cd0/third_party/blink/renderer/platform/exported/web_clipboard_impl.cc
[delete] https://crrev.com/23abd9c690d6c74e1a5b653cbdfbfa36b6049cd0/third_party/blink/renderer/platform/exported/web_clipboard_impl.h

Owner: dgozman@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment