New issue
Advanced search Search tips

Issue 775825 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Record manual fallbacks for filling stats

Project Member Reported by melandory@chromium.org, Oct 18 2017

Issue description

Manual fallbacks for filling are missing metrics reporting.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/376b1551feed797687cbf362188efdf1ab5a718d

commit 376b1551feed797687cbf362188efdf1ab5a718d
Author: Tatiana Gornak <melandory@chromium.org>
Date: Thu Oct 19 08:27:13 2017

Record metrics when "Show all saved passwords" is triggered from Context Menu.

BUG= 739343 ,  775825 

Change-Id: Ib0f997a0228fcf02b117d769644a31cd4b3352d0
Reviewed-on: https://chromium-review.googlesource.com/725342
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510036}
[modify] https://crrev.com/376b1551feed797687cbf362188efdf1ab5a718d/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/376b1551feed797687cbf362188efdf1ab5a718d/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/376b1551feed797687cbf362188efdf1ab5a718d/components/password_manager/core/browser/password_manager_metrics_util.h
[modify] https://crrev.com/376b1551feed797687cbf362188efdf1ab5a718d/components/password_manager/core/browser/password_manager_util.cc
[modify] https://crrev.com/376b1551feed797687cbf362188efdf1ab5a718d/components/password_manager/core/browser/password_manager_util.h
[modify] https://crrev.com/376b1551feed797687cbf362188efdf1ab5a718d/components/password_manager/core/common/experiments.cc
[modify] https://crrev.com/376b1551feed797687cbf362188efdf1ab5a718d/components/password_manager/core/common/experiments.h

Labels: Merge-Request-63
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 24 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by gov...@chromium.org, Oct 24 2017

Please merge you change to M63 branch 3239 by 4:00 PM PT, tomorrow (Wednesday). Thank you.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 25 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/885ce1e482d9f15f9c1bcf5cbf23ad91974278a1

commit 885ce1e482d9f15f9c1bcf5cbf23ad91974278a1
Author: Tatiana Gornak <melandory@chromium.org>
Date: Wed Oct 25 13:49:08 2017

Record metrics when "Show all saved passwords" is triggered from Context Menu.

BUG= 739343 ,  775825 
TBR=melandory@chromium.org

(cherry picked from commit 376b1551feed797687cbf362188efdf1ab5a718d)

Change-Id: Ib0f997a0228fcf02b117d769644a31cd4b3352d0
Reviewed-on: https://chromium-review.googlesource.com/725342
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510036}
Reviewed-on: https://chromium-review.googlesource.com/738205
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#212}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/885ce1e482d9f15f9c1bcf5cbf23ad91974278a1/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/885ce1e482d9f15f9c1bcf5cbf23ad91974278a1/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/885ce1e482d9f15f9c1bcf5cbf23ad91974278a1/components/password_manager/core/browser/password_manager_metrics_util.h
[modify] https://crrev.com/885ce1e482d9f15f9c1bcf5cbf23ad91974278a1/components/password_manager/core/browser/password_manager_util.cc
[modify] https://crrev.com/885ce1e482d9f15f9c1bcf5cbf23ad91974278a1/components/password_manager/core/browser/password_manager_util.h
[modify] https://crrev.com/885ce1e482d9f15f9c1bcf5cbf23ad91974278a1/components/password_manager/core/common/experiments.cc
[modify] https://crrev.com/885ce1e482d9f15f9c1bcf5cbf23ad91974278a1/components/password_manager/core/common/experiments.h

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2b94a9c448ba0c04f4b96916e1503f180846a9a

commit a2b94a9c448ba0c04f4b96916e1503f180846a9a
Author: Tatiana Gornak <melandory@chromium.org>
Date: Wed Oct 25 14:15:22 2017

Record metrics when "Generate a password" is triggered from Context Menu.

BUG= 739343 ,  775825 
TBR=melandory@chromium.org

(cherry picked from commit 43b335030921dbc94cbadab8a78b981c0066c21a)

Change-Id: I12ba09c21afd4e2fd70e82974bb1720228b0829b
Reviewed-on: https://chromium-review.googlesource.com/727894
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510376}
Reviewed-on: https://chromium-review.googlesource.com/738208
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#213}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/a2b94a9c448ba0c04f4b96916e1503f180846a9a/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/a2b94a9c448ba0c04f4b96916e1503f180846a9a/components/autofill/core/common/password_generation_util.h
[modify] https://crrev.com/a2b94a9c448ba0c04f4b96916e1503f180846a9a/components/password_manager/core/browser/password_manager_util.cc
[modify] https://crrev.com/a2b94a9c448ba0c04f4b96916e1503f180846a9a/components/password_manager/core/browser/password_manager_util.h

Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb2b02ace587fa16576949e93af4859811cd25f4

commit bb2b02ace587fa16576949e93af4859811cd25f4
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Wed Jan 31 14:12:10 2018

[Password Manager] Add missed rows to UMA enum

In https://chromium-review.googlesource.com/c/chromium/src/+/725342, enum.xm wasn't updated properly. It should corresponds to |ShowAllSavedPasswordsContext|

Bug:  739343 ,  775825 
Change-Id: I0129522e95414412aeb6f271d0aa07cc236801cf
Reviewed-on: https://chromium-review.googlesource.com/893560
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533266}
[modify] https://crrev.com/bb2b02ace587fa16576949e93af4859811cd25f4/tools/metrics/histograms/enums.xml

Sign in to add a comment