Complete the mojofication of the remaining IPCs in content/common/child_process_messages.h and Onion Soup the resulting classes (where possible).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a commit 5420564de0e2b7da728e7a9402e04b6cdfb9fc0a Author: Nicholas Verne <nverne@chromium.org> Date: Fri Oct 27 07:37:54 2017 Mojoify control messages for child processes. Interface ChildControl is implemented by threads in Child processes, e.g. ChildThreadImpl, RenderThreadImpl. The ChildControl methods seemed like a good fit for interface Child in child.mojom, but that interface is empty and implemented by content::ServiceManagerConnectionImpl::IOThreadContext, not ChildThreadImpl. Bug: 775817 Change-Id: Ica5f0e680366c25356f1db7cb3d7091c4305fdba Reviewed-on: https://chromium-review.googlesource.com/734500 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#512115} [modify] https://crrev.com/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a/content/browser/browser_ipc_logging.cc [modify] https://crrev.com/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a/content/browser/renderer_host/render_process_host_impl.h [modify] https://crrev.com/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a/content/child/child_thread_impl.cc [modify] https://crrev.com/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a/content/child/child_thread_impl.h [modify] https://crrev.com/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a/content/common/BUILD.gn [add] https://crrev.com/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a/content/common/child_control.mojom [modify] https://crrev.com/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a/content/common/child_process_host_impl.cc [modify] https://crrev.com/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a/content/common/child_process_host_impl.h [modify] https://crrev.com/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a/content/common/child_process_messages.h [modify] https://crrev.com/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a/content/common/renderer.mojom [modify] https://crrev.com/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a/content/public/app/mojo/content_gpu_manifest.json [modify] https://crrev.com/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a/content/public/app/mojo/content_plugin_manifest.json [modify] https://crrev.com/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a/content/public/app/mojo/content_renderer_manifest.json [modify] https://crrev.com/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a/content/public/app/mojo/content_utility_manifest.json [modify] https://crrev.com/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a/content/renderer/render_thread_impl.cc [modify] https://crrev.com/5420564de0e2b7da728e7a9402e04b6cdfb9fc0a/content/renderer/render_thread_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcc2c29418c49f2b06dc4bf5b89769f916c0bbb2 commit bcc2c29418c49f2b06dc4bf5b89769f916c0bbb2 Author: Nicholas Verne <nverne@chromium.org> Date: Fri Oct 27 10:20:44 2017 removed unused LocationSnapshot class Bug: 775817 Change-Id: Iace54f25b3ac98c15055f9cd9b28806e5eb536a6 Reviewed-on: https://chromium-review.googlesource.com/737739 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#512143} [modify] https://crrev.com/bcc2c29418c49f2b06dc4bf5b89769f916c0bbb2/base/location.cc [modify] https://crrev.com/bcc2c29418c49f2b06dc4bf5b89769f916c0bbb2/base/location.h [modify] https://crrev.com/bcc2c29418c49f2b06dc4bf5b89769f916c0bbb2/content/common/child_process_messages.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46bed17ef6f36d5ef97a9e4700cdc035b1cddc16 commit 46bed17ef6f36d5ef97a9e4700cdc035b1cddc16 Author: Xiaohan Wang <xhwang@chromium.org> Date: Thu Nov 02 04:42:14 2017 Fix ChildControl binding in ChildProcessHostImpl For some child processes, BindInterface() in ChildProcessHostImpl's constructor will not work, e.g. for utility process, see ServiceUtilityProcessHost::BindInterface(). This CL moves the ChildControl binding to ChildProcessHostImpl::InitChannel() to fix this issue. BUG= 775817 ,780529 TEST=Manually tested and the utility CDM process exits properly. Change-Id: I5d42ae9eb2eb61abd2c842d8b38820925ac8fcbc Reviewed-on: https://chromium-review.googlesource.com/749639 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#513404} [modify] https://crrev.com/46bed17ef6f36d5ef97a9e4700cdc035b1cddc16/content/common/child_process_host_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06de8122fd8d71f0b07e793f22ae019c6340fccd commit 06de8122fd8d71f0b07e793f22ae019c6340fccd Author: Nicholas Verne <nverne@chromium.org> Date: Thu Nov 16 04:47:38 2017 mojoify ChildProcessHostMsg_ShutdownRequest There is no longer any need for non-renderer ChildProcesses to request shutdown from the host, because it is always granted. Only Renderers need to do this dance, so the ShutdownRequest message is handled in mojom.RendererHost As part of this dance, RenderProcessShutdownRequested is called for all RenderProcessHostObservers,and SitePerProcessBrowserTest.CloseSubframeWidgetAndViewOnProcessExit observes this event instead of adding an extra message filter to the RenderProcessHost. Bug: 775817 Change-Id: Id01308e28bfc2c1b1ecac4a63d2815300ada50b7 Reviewed-on: https://chromium-review.googlesource.com/768520 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#516990} [modify] https://crrev.com/06de8122fd8d71f0b07e793f22ae019c6340fccd/content/browser/renderer_host/render_process_host_browsertest.cc [modify] https://crrev.com/06de8122fd8d71f0b07e793f22ae019c6340fccd/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/06de8122fd8d71f0b07e793f22ae019c6340fccd/content/browser/renderer_host/render_process_host_impl.h [modify] https://crrev.com/06de8122fd8d71f0b07e793f22ae019c6340fccd/content/browser/site_per_process_browsertest.cc [modify] https://crrev.com/06de8122fd8d71f0b07e793f22ae019c6340fccd/content/child/child_thread_impl.cc [modify] https://crrev.com/06de8122fd8d71f0b07e793f22ae019c6340fccd/content/child/child_thread_impl.h [modify] https://crrev.com/06de8122fd8d71f0b07e793f22ae019c6340fccd/content/common/child_process_host_impl.cc [modify] https://crrev.com/06de8122fd8d71f0b07e793f22ae019c6340fccd/content/common/child_process_host_impl.h [modify] https://crrev.com/06de8122fd8d71f0b07e793f22ae019c6340fccd/content/common/child_process_messages.h [modify] https://crrev.com/06de8122fd8d71f0b07e793f22ae019c6340fccd/content/common/renderer_host.mojom [modify] https://crrev.com/06de8122fd8d71f0b07e793f22ae019c6340fccd/content/public/browser/render_process_host_observer.h [modify] https://crrev.com/06de8122fd8d71f0b07e793f22ae019c6340fccd/content/renderer/render_thread_impl.cc [modify] https://crrev.com/06de8122fd8d71f0b07e793f22ae019c6340fccd/content/renderer/render_thread_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84dc55e365a4c05b7b374402aed9e54fcfd0f079 commit 84dc55e365a4c05b7b374402aed9e54fcfd0f079 Author: Nicholas Verne <nverne@chromium.org> Date: Thu Nov 23 01:02:38 2017 Convert moar ChildProcessHostMsg to mojo. ChildProcessHostMsg_HasGpuProcess and ChildProcessHostMsg_SetThreadPriority now live in RenderMessageFilter. Bug: 775817 Change-Id: Idf9dd6dbb8d65b304aaff68d0dc22901ced19968 Reviewed-on: https://chromium-review.googlesource.com/778203 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#518816} [modify] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/content/browser/gpu/gpu_process_host.h [modify] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/content/browser/renderer_host/render_message_filter.cc [modify] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/content/browser/renderer_host/render_message_filter.h [modify] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/content/child/child_process.cc [modify] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/content/child/child_process.h [modify] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/content/child/child_thread_impl.cc [modify] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/content/child/child_thread_impl.h [modify] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/content/common/child_process_messages.h [modify] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/content/common/render_message_filter.mojom [modify] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/content/public/test/mock_render_thread.cc [modify] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/content/renderer/gpu/gpu_benchmarking_extension.cc [modify] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/content/renderer/render_thread_impl.cc [modify] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/mojo/common/BUILD.gn [modify] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/mojo/common/common_custom_types_struct_traits.cc [modify] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/mojo/common/common_custom_types_struct_traits.h [add] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/mojo/common/thread_priority.mojom [add] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/mojo/common/thread_priority.typemap [modify] https://crrev.com/84dc55e365a4c05b7b374402aed9e54fcfd0f079/mojo/common/typemaps.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33a2d10d42fcb82679cc9fb5642153a0d4ac9b50 commit 33a2d10d42fcb82679cc9fb5642153a0d4ac9b50 Author: Nicholas Verne <nverne@chromium.org> Date: Tue Nov 28 00:18:28 2017 Mojo-ify PreCacheFont/ReleaseCachedFonts IPCs for windows Made windows-only typemap for LOGFONT using the existing IPC ParamTraits. The next CL will remove child_process_messages.h Bug: 775817 Change-Id: Id42bf3df88ab067e1bc440757a70e6821e4f40e8 Reviewed-on: https://chromium-review.googlesource.com/783912 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#519471} [modify] https://crrev.com/33a2d10d42fcb82679cc9fb5642153a0d4ac9b50/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/33a2d10d42fcb82679cc9fb5642153a0d4ac9b50/content/browser/service_manager/common_browser_interfaces.cc [modify] https://crrev.com/33a2d10d42fcb82679cc9fb5642153a0d4ac9b50/content/child/child_thread_impl.cc [modify] https://crrev.com/33a2d10d42fcb82679cc9fb5642153a0d4ac9b50/content/child/child_thread_impl.h [modify] https://crrev.com/33a2d10d42fcb82679cc9fb5642153a0d4ac9b50/content/common/BUILD.gn [modify] https://crrev.com/33a2d10d42fcb82679cc9fb5642153a0d4ac9b50/content/common/child_process_host_impl.cc [modify] https://crrev.com/33a2d10d42fcb82679cc9fb5642153a0d4ac9b50/content/common/child_process_messages.h [modify] https://crrev.com/33a2d10d42fcb82679cc9fb5642153a0d4ac9b50/content/common/font_cache_dispatcher_win.cc [modify] https://crrev.com/33a2d10d42fcb82679cc9fb5642153a0d4ac9b50/content/common/font_cache_dispatcher_win.h [add] https://crrev.com/33a2d10d42fcb82679cc9fb5642153a0d4ac9b50/content/common/font_cache_win.mojom [modify] https://crrev.com/33a2d10d42fcb82679cc9fb5642153a0d4ac9b50/mojo/common/BUILD.gn [add] https://crrev.com/33a2d10d42fcb82679cc9fb5642153a0d4ac9b50/mojo/common/logfont_win.mojom [add] https://crrev.com/33a2d10d42fcb82679cc9fb5642153a0d4ac9b50/mojo/common/logfont_win.typemap [modify] https://crrev.com/33a2d10d42fcb82679cc9fb5642153a0d4ac9b50/mojo/common/typemaps.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e5b75f5b75d5a9c50871fca910d8f2918f2d354 commit 0e5b75f5b75d5a9c50871fca910d8f2918f2d354 Author: Nicholas Verne <nverne@chromium.org> Date: Tue Nov 28 07:25:11 2017 remove child_process_messages.h Bug: 775817 Change-Id: I0b6f40d0ca84f8fc7296fca56759186b6960588e Reviewed-on: https://chromium-review.googlesource.com/787052 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#519598} [modify] https://crrev.com/0e5b75f5b75d5a9c50871fca910d8f2918f2d354/content/browser/browser_child_process_host_impl.cc [modify] https://crrev.com/0e5b75f5b75d5a9c50871fca910d8f2918f2d354/content/browser/histogram_controller.cc [modify] https://crrev.com/0e5b75f5b75d5a9c50871fca910d8f2918f2d354/content/browser/ppapi_plugin_process_host.cc [modify] https://crrev.com/0e5b75f5b75d5a9c50871fca910d8f2918f2d354/content/browser/renderer_host/render_message_filter.cc [modify] https://crrev.com/0e5b75f5b75d5a9c50871fca910d8f2918f2d354/content/browser/renderer_host/render_process_host_browsertest.cc [modify] https://crrev.com/0e5b75f5b75d5a9c50871fca910d8f2918f2d354/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/0e5b75f5b75d5a9c50871fca910d8f2918f2d354/content/browser/site_per_process_browsertest.cc [modify] https://crrev.com/0e5b75f5b75d5a9c50871fca910d8f2918f2d354/content/child/child_histogram_fetcher_impl.cc [modify] https://crrev.com/0e5b75f5b75d5a9c50871fca910d8f2918f2d354/content/child/child_thread_impl.cc [modify] https://crrev.com/0e5b75f5b75d5a9c50871fca910d8f2918f2d354/content/common/BUILD.gn [modify] https://crrev.com/0e5b75f5b75d5a9c50871fca910d8f2918f2d354/content/common/child_process_host_impl.cc [delete] https://crrev.com/e643f226b1b9dfb90997f7f2fb76e78320156af2/content/common/child_process_messages.h [modify] https://crrev.com/0e5b75f5b75d5a9c50871fca910d8f2918f2d354/content/common/content_message_generator.h [modify] https://crrev.com/0e5b75f5b75d5a9c50871fca910d8f2918f2d354/content/ppapi_plugin/ppapi_blink_platform_impl.cc [modify] https://crrev.com/0e5b75f5b75d5a9c50871fca910d8f2918f2d354/content/ppapi_plugin/ppapi_thread.cc [modify] https://crrev.com/0e5b75f5b75d5a9c50871fca910d8f2918f2d354/content/renderer/dom_automation_controller.cc [modify] https://crrev.com/0e5b75f5b75d5a9c50871fca910d8f2918f2d354/content/renderer/gpu/gpu_benchmarking_extension.cc [modify] https://crrev.com/0e5b75f5b75d5a9c50871fca910d8f2918f2d354/content/renderer/render_thread_impl.cc [modify] https://crrev.com/0e5b75f5b75d5a9c50871fca910d8f2918f2d354/content/renderer/renderer_blink_platform_impl.cc
Comment 1 by bugdroid1@chromium.org
, Oct 27 2017