New issue
Advanced search Search tips

Issue 775809 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Onion Soup: Mojofy and onion soup content/common/render_process_messages.h

Project Member Reported by slangley@chromium.org, Oct 18 2017

Issue description

- Turn all IPCs into mojo.
- Move code from //content/ to //blink
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 14 2017

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cdc5b305672aee2cef38bc3824452a09d40d6e7

commit 4cdc5b305672aee2cef38bc3824452a09d40d6e7
Author: Dirk Pranke <dpranke@chromium.org>
Date: Wed Nov 15 03:32:14 2017

Revert "Convert IPC SuddenTerminationChanged to mojo."

This reverts commit 56860de6211ad94453155bb7f035e66ca73e9fd8.

Reason for revert: Speculative revert for  crbug.com/785121  (BrowserCloseManagerBrowserTest.AddBeforeUnloadDuringClosing/0 failing on multiple test suites).

Original change's description:
> Convert IPC SuddenTerminationChanged to mojo.
> 
> Bug: 775809
> Change-Id: Ie8600341a0cb73c7eae0df5c3c877f69023fc9b5
> Reviewed-on: https://chromium-review.googlesource.com/768097
> Commit-Queue: Joel Hockey <joelhockey@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Nicholas Verne <nverne@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516486}

TBR=jam@chromium.org,sammc@chromium.org,tsepez@chromium.org,joelhockey@chromium.org,nverne@chromium.org

Change-Id: I774d245645dc3ae2af6911ed646304410861fbce
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775809
Reviewed-on: https://chromium-review.googlesource.com/770497
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516582}
[modify] https://crrev.com/4cdc5b305672aee2cef38bc3824452a09d40d6e7/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/4cdc5b305672aee2cef38bc3824452a09d40d6e7/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/4cdc5b305672aee2cef38bc3824452a09d40d6e7/content/common/render_process_messages.h
[modify] https://crrev.com/4cdc5b305672aee2cef38bc3824452a09d40d6e7/content/common/renderer_host.mojom
[modify] https://crrev.com/4cdc5b305672aee2cef38bc3824452a09d40d6e7/content/renderer/renderer_blink_platform_impl.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3146d14ff14dd6da0acf47e6aab87a288acab77e

commit 3146d14ff14dd6da0acf47e6aab87a288acab77e
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Nov 15 22:27:40 2017

Convert IPC SuddenTerminationChanged to mojo.
Change mojom::RendererHost to be associated

This is a reland of crrev.com/c/785121 with mojo interface
updated to be assoicated and preserve message ordering.

Bug: 775809
Bug:  785121 
Change-Id: Ib5fc3bb32cfe343d8e9a34aaa32bba2b13925ef7
Tbr: jam@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/770676
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516862}
[modify] https://crrev.com/3146d14ff14dd6da0acf47e6aab87a288acab77e/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/3146d14ff14dd6da0acf47e6aab87a288acab77e/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/3146d14ff14dd6da0acf47e6aab87a288acab77e/content/common/render_process_messages.h
[modify] https://crrev.com/3146d14ff14dd6da0acf47e6aab87a288acab77e/content/common/renderer_host.mojom
[modify] https://crrev.com/3146d14ff14dd6da0acf47e6aab87a288acab77e/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/3146d14ff14dd6da0acf47e6aab87a288acab77e/content/renderer/render_thread_impl.h
[modify] https://crrev.com/3146d14ff14dd6da0acf47e6aab87a288acab77e/content/renderer/renderer_blink_platform_impl.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00fecee965380f9c1b8043f500fdffef9f854890

commit 00fecee965380f9c1b8043f500fdffef9f854890
Author: Noel Gordon <noel@chromium.org>
Date: Tue Nov 21 21:38:05 2017

Fix mojo Shared Buffer documentation example

Per the current code, to create a mojo::ScopedSharedBufferHandle, one
should call the mojo::SharedBufferHandle::Create.  Update README docs
code example to say that.

Bug: 775809
Change-Id: Icfc86485923d1ec5fb7bb9d1b7b7125928af9e5f
Reviewed-on: https://chromium-review.googlesource.com/781310
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518401}
[modify] https://crrev.com/00fecee965380f9c1b8043f500fdffef9f854890/mojo/public/cpp/system/README.md

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd

commit 27bcca76fb5c9e73b5270c8a407eb42ec445f2bd
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Nov 23 05:28:47 2017

Convert IPC LoadFont to mojo

Removed FontDescriptor class which was used in IPC and replaced by using
embedded string16 font_name and float font_point_size fields directly.

Replaced usage of NSFont with CTFontRef in order to be able to access
font_name and font_point_size fields outside of objective-C.

Updated FontLoader API to use mojo::ScopedSharedBufferHandle to avoid
unnecessary conversions.

Bug: 775809
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I5b891aa2ebb386fb460d64a8f0a79c6bba95f82c
Reviewed-on: https://chromium-review.googlesource.com/768332
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518858}
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/build/check_gn_headers_whitelist.txt
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/content/browser/renderer_host/render_message_filter.h
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/content/common/BUILD.gn
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/content/common/content_message_generator.h
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/content/common/mac/attributed_string_coder.h
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/content/common/mac/attributed_string_coder.mm
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/content/common/mac/attributed_string_coder_unittest.mm
[delete] https://crrev.com/7ca0794d1a91400d2f0e82037ef63a34b14a6798/content/common/mac/font_descriptor.h
[delete] https://crrev.com/7ca0794d1a91400d2f0e82037ef63a34b14a6798/content/common/mac/font_descriptor.mm
[delete] https://crrev.com/7ca0794d1a91400d2f0e82037ef63a34b14a6798/content/common/mac/font_descriptor_unittest.mm
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/content/common/mac/font_loader.h
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/content/common/mac/font_loader.mm
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/content/common/render_message_filter.mojom
[delete] https://crrev.com/7ca0794d1a91400d2f0e82037ef63a34b14a6798/content/common/render_process_messages.h
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/content/common/sandbox_mac_fontloading_unittest.mm
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/content/ppapi_plugin/ppapi_blink_platform_impl.cc
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/content/public/test/mock_render_thread.cc
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/content/test/BUILD.gn
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/ipc/ipc_message_start.h
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm
[modify] https://crrev.com/27bcca76fb5c9e73b5270c8a407eb42ec445f2bd/third_party/WebKit/public/platform/mac/WebSandboxSupport.h

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/918f65bdf2489817a5c174b3ac21e3770db398f1

commit 918f65bdf2489817a5c174b3ac21e3770db398f1
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Nov 23 06:50:17 2017

Convert base::SharedMemoryHandle in FontLoader to mojo::ScopedSharedBufferHandle

SendLoadFontReply function definition removed since it is now identical
to the mojo LoadFontCallback.

Bug: 775809
Change-Id: Iea112d8f741aad6c3d049406e4a16ed1a6a52db0
Reviewed-on: https://chromium-review.googlesource.com/784737
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518867}
[modify] https://crrev.com/918f65bdf2489817a5c174b3ac21e3770db398f1/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/918f65bdf2489817a5c174b3ac21e3770db398f1/content/browser/renderer_host/render_message_filter.h
[modify] https://crrev.com/918f65bdf2489817a5c174b3ac21e3770db398f1/content/common/mac/font_loader.h
[modify] https://crrev.com/918f65bdf2489817a5c174b3ac21e3770db398f1/content/common/mac/font_loader.mm
[modify] https://crrev.com/918f65bdf2489817a5c174b3ac21e3770db398f1/content/common/sandbox_mac_fontloading_unittest.mm

IPCs are now all removed.  Status for onion soup work (moving mojo calls out of renderer_blink_platform_impl and calling directly from blink)

DidGenerateCacheableMetadata:
 - ready to go

DidGenerateCacheableMetadataInCacheStorage:
 - ready to go

SuddenTerminationChanged:
 - blocked on content/renderer/blob_storage/blob_transport_controller.cc
 - blocked on content/renderer/dom_storage/dom_storage_dispatcher.cc

LoadFont:
 - ready to go in third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm
Cc: joelhockey@chromium.org
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 10 by sheriffbot@chromium.org, Today (67 minutes ago)

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment