New issue
Advanced search Search tips

Issue 775806 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 545318



Sign in to add a comment

[css-typed-om] Parsing an invalid cssText for a property should throw

Project Member Reported by shend@chromium.org, Oct 18 2017

Issue description

Spec: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssstylevalue-parse

Test Failure:
FAIL Calling CSSStyleValue.parse with an invalid cssText for the given property throws a SyntaxError assert_throws: function "() => CSSStyleValue[parseMethod]('width', '10deg')" did not throw
 

Comment 1 by shend@chromium.org, Oct 29 2017

Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9e824178ed91864f6c3e0173e11b0bfca5e8f30

commit f9e824178ed91864f6c3e0173e11b0bfca5e8f30
Author: Darren Shen <shend@chromium.org>
Date: Mon Oct 30 03:38:33 2017

[css-typed-om] Throw SyntaxError on parsing invalid cssText.

Currently we return null when calling CSSStyleValue.parse with an
invalid cssText. The spec says to throw a SyntaxError:

https://drafts.css-houdini.org/css-typed-om-1/#dom-cssstylevalue-parse

Bug:  775806 
Change-Id: Iab99af48ce162fa1810ac678e63475e1660d9d95
Reviewed-on: https://chromium-review.googlesource.com/743082
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512438}
[modify] https://crrev.com/f9e824178ed91864f6c3e0173e11b0bfca5e8f30/third_party/WebKit/LayoutTests/typedcssom/stylevalue-objects/parse-parseAll-expected.txt
[modify] https://crrev.com/f9e824178ed91864f6c3e0173e11b0bfca5e8f30/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp

Comment 3 by shend@chromium.org, Oct 30 2017

Status: Fixed (was: Started)

Comment 4 by nainar@chromium.org, Nov 29 2017

Labels: -Type-Bug -Hotlist-Interop Type-Feature

Sign in to add a comment