New issue
Advanced search Search tips

Issue 775802 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 545318



Sign in to add a comment

[css-typed-om] Implement CSSStyleValue.parseAll.

Project Member Reported by shend@chromium.org, Oct 18 2017

Issue description

Comment 1 by shend@chromium.org, Oct 18 2017

Blocking: 545318

Comment 2 by shend@chromium.org, Oct 30 2017

Owner: shend@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/797edda23a38016d17389f66d1eef4d2658a7b0a

commit 797edda23a38016d17389f66d1eef4d2658a7b0a
Author: Darren Shen <shend@chromium.org>
Date: Wed Nov 01 02:41:11 2017

[css-typed-om] Implement CSSStyleValue.parseAll.

CSSStyleValue.parseAll is similar to CSSStyleValue.parse in that it
converts a string value into a CSSStyleValue. The main difference is
how it handles list-valued properties.

Spec: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssstylevalue-parseall

To reduce duplication, we move the common logic between parse and
parseAll into a helper function.

We also change the tests for parseAll because they wrongly expected that
parseAll return a CSSStyleValue instead of a sequence of CSSStyleValues.

Bug:  775802 
Change-Id: I4b6b05d3a164e34709839ca2e059ec3fbf18a993
Reviewed-on: https://chromium-review.googlesource.com/742822
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513054}
[modify] https://crrev.com/797edda23a38016d17389f66d1eef4d2658a7b0a/third_party/WebKit/LayoutTests/typedcssom/stylevalue-objects/parse-parseAll-expected.txt
[modify] https://crrev.com/797edda23a38016d17389f66d1eef4d2658a7b0a/third_party/WebKit/LayoutTests/typedcssom/stylevalue-objects/parse-parseAll.html
[modify] https://crrev.com/797edda23a38016d17389f66d1eef4d2658a7b0a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/797edda23a38016d17389f66d1eef4d2658a7b0a/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp
[modify] https://crrev.com/797edda23a38016d17389f66d1eef4d2658a7b0a/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h
[modify] https://crrev.com/797edda23a38016d17389f66d1eef4d2658a7b0a/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.idl

Comment 4 by shend@chromium.org, Nov 6 2017

Status: Fixed (was: Started)

Comment 5 by nainar@chromium.org, Nov 29 2017

Labels: -Type-Bug -Hotlist-Interop Type-Feature

Sign in to add a comment