New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775785 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

AFDO feedback data is not access during ChromeOS build.

Project Member Reported by pan.d...@intel.com, Oct 18 2017

Issue description

Recently, AFDO feedback data on google storage is not access by anonymous, it blocks the "afdo_use" build.
We have tried gsutil ls ..., it says the file exists in gs.
The ChromeOS source version we are using is 10021.

thanks for your help.
Pan

The logs:
chromeos-chrome-63.0.3236.0_rc-r1:  * chromeos-chrome-amd64-63.0.3236.0_rc-r1.afdo.prof.bz2 SHA256 SHA512 WHIRLPOOL size ;-) ...                    [ ok ]
chromeos-chrome-63.0.3236.0_rc-r1: 09:45:39: INFO: RunCommand: /mnt/host/source/.cache/common/gsutil_4.27.tar.gz/gsutil/gsutil -o 'Boto:num_retries=10' -o 'Boto:proxy=proxy-us.intel.com' -o 'Boto:proxy_port=911' cp -v -- gs://chromeos-localmirror/distfiles/afdo/experimental/cwp/chromeos-chrome-amd64-63.0.3223.0_rc-r1.afdo.bz2 /var/cache/chromeos-cache/distfiles/target/chromeos-chrome-amd64-63.0.3223.0_rc-r1.afdo.exp1.bz2.tmp
chromeos-chrome-63.0.3236.0_rc-r1: 09:45:41: WARNING: GS_ERROR: ServiceException: 401 Anonymous users does not have storage.objects.get access to chromeos-localmirror/distfiles/afdo/experimental/cwp/chromeos-chrome-amd64-63.0.3223.0_rc-r1.afdo.bz2.
chromeos-chrome-63.0.3236.0_rc-r1:  
chromeos-chrome-63.0.3236.0_rc-r1: 09:45:41: ERROR: return code: 1; command: /mnt/host/source/.cache/common/gsutil_4.27.tar.gz/gsutil/gsutil -o 'Boto:num_retries=10' -o 'Boto:proxy=proxy-us.intel.com' -o 'Boto:proxy_port=911' cp -v -- gs://chromeos-localmirror/distfiles/afdo/experimental/cwp/chromeos-chrome-amd64-63.0.3223.0_rc-r1.afdo.bz2 /var/cache/chromeos-cache/distfiles/target/chromeos-chrome-amd64-63.0.3223.0_rc-r1.afdo.exp1.bz2.tmp
chromeos-chrome-63.0.3236.0_rc-r1: ServiceException: 401 Anonymous users does not have storage.objects.get access to chromeos-localmirror/distfiles/afdo/experimental/cwp/chromeos-chrome-amd64-63.0.3223.0_rc-r1.afdo.bz2.
chromeos-chrome-63.0.3236.0_rc-r1: 
chromeos-chrome-63.0.3236.0_rc-r1: cmd=['/mnt/host/source/.cache/common/gsutil_4.27.tar.gz/gsutil/gsutil', '-o', 'Boto:num_retries=10', '-o', 'Boto:proxy=proxy-us.intel.com', '-o', 'Boto:proxy_port=911', 'cp', '-v', '--', 'gs://chromeos-localmirror/distfiles/afdo/experimental/cwp/chromeos-chrome-amd64-63.0.3223.0_rc-r1.afdo.bz2', '/var/cache/chromeos-cache/distfiles/target/chromeos-chrome-amd64-63.0.3223.0_rc-r1.afdo.exp1.bz2.tmp']
chromeos-chrome-63.0.3236.0_rc-r1: !!! Couldn't download 'chromeos-chrome-amd64-63.0.3223.0_rc-r1.afdo.exp1.bz2'. Aborting.



 

Comment 1 by pan.d...@intel.com, Oct 19 2017

@llozano, could you please help on this issue?

thanks
Pan
Labels: Build-Toolchain
Owner: laszio@chromium.org
Status: Assigned (was: Unconfirmed)
hi, when filing bugs against my team, please use label:build-toolchain and os:chrome.
It is not good to depend on me to be at the office.
Ting-Yuan, 

can you please help with this?


Comment 3 by pan.d...@intel.com, Oct 19 2017

I see, thanks! :)

Comment 4 by laszio@chromium.org, Oct 19 2017

There are 2 problems here:

1. The experimental profiles shouldn't be donwloaded when not used. The fix is under review:
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/728725

2. The profile themselves should be publicly available. I need to check the permission.

Comment 5 by laszio@chromium.org, Oct 19 2017

Hi Pan, would you mind to manually apply the above CL before it lands? So that you can be unblocked.

Comment 6 by laszio@chromium.org, Oct 19 2017

Labels: -Pri-3 Pri-1

Comment 7 by pan.d...@intel.com, Oct 20 2017

@laszio, sure, thanks for your help!

Cheers
Pan
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a211e38ed003fef296115e54edb5d37c67cdc1ac

commit a211e38ed003fef296115e54edb5d37c67cdc1ac
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Sun Oct 22 14:06:23 2017

chrome: only download afdo profiles when needed.

TEST=tested locally; the experimental profile are not downloaded
     without corresponding use flags.
BUG= chromium:775785 
CQ-DEPEND=CL:731574

Change-Id: Ie561f729303c2b21cb5f5df548637f80eef9149a
Reviewed-on: https://chromium-review.googlesource.com/728725
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a211e38ed003fef296115e54edb5d37c67cdc1ac/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Comment 9 by laszio@chromium.org, Oct 22 2017

Status: Fixed (was: Assigned)
The permission is also fixed.

Comment 11 by pan.d...@intel.com, Oct 24 2017

Cool! thanks!

Comment 12 by dchan@chromium.org, Jan 22 2018

Status: archived (was: Fixed)

Comment 13 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment