New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775778 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Show Chrome Home promo header on NTP overflow menu

Project Member Reported by k...@chromium.org, Oct 18 2017

Issue description

We should show the Chrome Home promo header ("You're using the new Chrome") on the NTP overflow menu.
 
I originally removed it from the NTP to avoid a crash in the promo dialog code that reparents the tab, but I believe Matt added a null check that should make this pretty easy.
Cc: cl...@chromium.org hannahs@chromium.org
+cleer@ and hannahs@ for UX fyi

Video attached of my prototype code. We can easily show the promo header on the Chrome Home NTP. Since the Chrome Home NTP isn't a real tab, we don't persist anything to disk and can't reparent the tab. So when the user is dropped back into regular Chrome, they "lose" the NTP and we can't show the opt-out snackbar. Not ideal... We can probably add some logic to work around this so they're at least shown the legacy NTP after opting out.

If the user has no tabs open, we currently show nothing.. I *think* we should be able to fix that by updating our logic that determines when to open a new tab on cold start. Matt modified this for the tab reparenting done when the user opts in or out so he may have some ideas here.
opt-out-from-ntp.mp4
2.6 MB View Download
opt-out-from-ntp-no-tabs.mp4
3.1 MB View Download

Comment 3 by k...@chromium.org, Oct 19 2017

Thanks for prototyping. I'm OK with that behavior. I wonder how often it will be triggered through the NTP as it may introduce yet another factor for snackbar survey showing up. cleer/hannahs thoughts?

Comment 4 by k...@chromium.org, Oct 19 2017

Labels: -Fine-Pri-3.0 Fine-Pri-2.8
I have a patch with the "prototype" behavior out for review: https://chromium-review.googlesource.com/c/chromium/src/+/727368/


I can land it, and we can do clean up later. Or I can pull out the code (really easy) and land it separately. Any UX opinions on this?
Spoke with Chris and our main priority is to make sure they survey is shown at opt out, so it's probably best to pull out showing the menu header into a separate change. Thanks!
Status: WontFix (was: Available)
The Chrome Home experiment has ended; closing obsolete bug.

Sign in to add a comment