New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775768 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

See if we will add new metrics for new bookmark openURL actions

Project Member Reported by martiw@chromium.org, Oct 18 2017

Issue description

In the new bookmark ui, there are 4 new ways to open url(s):
- open in new tab
- open in new incognito tab
- open all in normal tabs
- open all in incognito tabs

Currently we track all of them by MobileBookmarkManagerEntryOpened:
https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm?type=cs&q=MobileBookmarkManagerEntryOpened&l=321

We should add more action metrics for tracking the new actions.

 

Comment 1 by martiw@chromium.org, Oct 18 2017

Labels: -M-63
Summary: See if we will add new metrics for new bookmark openURL actions (was: Add new metrics for new bookmark openURL actions)
It seems the action MobileBookmarkManagerEntryOpened is shared by both android and iOS.  I will investigate to see if we can really add new metrics.
Components: UI>Browser>Bookmarks Internals>Metrics
Labels: M-63

Comment 4 by martiw@chromium.org, Oct 30 2017

Cc: gambard@chromium.org sdefresne@chromium.org
We currently tracking 2 actions when opening bookmarks:  
(A) MobileBookmarkManagerEntryOpened (from base::RecordAction, shared with Android)
(B) ACTION_OPENED_BOOKMARK (from new_tab_page_uma::RecordAction, used in iOS only)

For (A), I am waiting for the reply of the owner to see if we could add more actions.

For (B), gambard@, sdefresne@, do you think it's appropriate to add the following bookmark actions to new_tab_page_uma.mm?
(1)  ACTION_OPENED_BOOKMARK_IN_NEW_TAB,
(2)  ACTION_OPENED_BOOKMARK_IN_NEW_INCOGNITO_TAB,
(3)  ACTION_OPENED_BOOKMARKS_IN_NEW_TABS,
(4)  ACTION_OPENED_BOOKMARKS_IN_NEW_INCOGNITO_TABS,

If yes, we could just track the actions on our own.
For B, we are recording the action taken by the user on the NTP. I don't think we expect them to be that precise as we don't record it for other surfaces. I think Mardini would be the person to ask as he is the one using the metrics.
As Gauthier said. For (B) this is part of the histogram tracking what users have done on the NTP (Searched, went to google.com, typed a URL, launched Recent tabs, Bookmarks, ...etc). So I don't think this level of granularity is needed. 

Thanks for checking. 
Components: -Internals>Metrics
Labels: Hotlist-Metrics
FYI, we are switching over to using Hotlist-Metrics for tracking individual metrics, and reserving Internals>Metrics for core metrics team infrastructure work.  Thanks!

Comment 8 by martiw@chromium.org, Nov 10 2017

Labels: -M-63 M-64

Comment 9 by martiw@chromium.org, Feb 18 2018

Owner: ----
Status: Available (was: Assigned)
Switched team and releasing this bug.
Status: WontFix (was: Available)
Marking this as WontFix as we don't need these granular metrics.

Sign in to add a comment