New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775767 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Chrome OS: system tray still shows an old cellular network entry after Mobile Data is disabled

Project Member Reported by benchan@chromium.org, Oct 18 2017

Issue description

Chrome Version: 64.0.3243.0  (also observed in M63 dev)
OS: Chrome OS 10039.0.0

What steps will reproduce the problem?
(1) Make sure "Mobile Data" is initially enabled, and there is a cellular network
(2) From the system tray, turn off "Mobile Data"

What is the expected result?

No cellular network entry remains in system tray after "Mobile Data" is disabled

What happens instead?

An old cellular network entry remains in the system tray after "Mobile Data" is disabled (see attached video)

 
issue.mp4
775 KB View Download
Components: UI>Shell>Networking
Labels: M-64 M-63
Summary: Chrome OS: system tray still shows an old cellular network entry after Mobile Data is disabled (was: CrOS: system tray still shows an old cellular network entry after Mobile Data is disabled)
Labels: -Type-Bug Type-Bug-Regression
Labels: -Pri-1 Pri-2
Status: Started (was: Assigned)
Labels: -M-64
Labels: -Pri-2 Pri-1
This is actually a pretty confusing but that is in 63, making a P1.

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe4b542f5cd637921a9db4b40f14dd3258ce0f21

commit fe4b542f5cd637921a9db4b40f14dd3258ce0f21
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Oct 20 01:21:55 2017

System Tray > Network > Hide default cellular network

For Settings, we create a default Cellular network even when Cellular
is disabled or no Service is a vailable so that the UI can configure
device properties ( crbug.com/717063 ).

A side effect of this was that this network shows up in the system
tray which is confusing. We should skip it in that UI.

Bug:  775767 
Change-Id: I41bada47bd142d0754436ad168ded02255bd4834
Reviewed-on: https://chromium-review.googlesource.com/729712
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510287}
[modify] https://crrev.com/fe4b542f5cd637921a9db4b40f14dd3258ce0f21/ash/system/network/network_list.cc

Labels: Merge-Request-63
Status: Fixed (was: Started)
Labels: -Merge-Request-63 Merge-Approved-63
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 21 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ac0d54a8727aead922321ad40657f62a75ef044

commit 8ac0d54a8727aead922321ad40657f62a75ef044
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Sat Oct 21 00:08:54 2017

System Tray > Network > Hide default cellular network

For Settings, we create a default Cellular network even when Cellular
is disabled or no Service is a vailable so that the UI can configure
device properties ( crbug.com/717063 ).

A side effect of this was that this network shows up in the system
tray which is confusing. We should skip it in that UI.

TBR=stevenjb@chromium.org

(cherry picked from commit fe4b542f5cd637921a9db4b40f14dd3258ce0f21)

Bug:  775767 
Change-Id: I41bada47bd142d0754436ad168ded02255bd4834
Reviewed-on: https://chromium-review.googlesource.com/729712
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510287}
Reviewed-on: https://chromium-review.googlesource.com/731823
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#131}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/8ac0d54a8727aead922321ad40657f62a75ef044/ash/system/network/network_list.cc

Sign in to add a comment