chromeos-config-tools unittest broke CQ |
|||||
Issue descriptionhttps://luci-milo.appspot.com/buildbot/chromeos/guado_moblab-paladin/7576 chromeos-config-tools-0.0.1-r665: Running tests in ./cros_config_host_py/libcros_config_host_unittest.py chromeos-config-tools-0.0.1-r665: .........F....... chromeos-config-tools-0.0.1-r665: ====================================================================== chromeos-config-tools-0.0.1-r665: FAIL: testGetTouchFirmwareFiles (__main__.CrosConfigHostTest) chromeos-config-tools-0.0.1-r665: ---------------------------------------------------------------------- chromeos-config-tools-0.0.1-r665: Traceback (most recent call last): chromeos-config-tools-0.0.1-r665: File "././cros_config_host_py/libcros_config_host_unittest.py", line 134, in testGetTouchFirmwareFiles chromeos-config-tools-0.0.1-r665: TouchFile(firmware='wacom/4209.hex', symlink='wacom_firmware_PYRO.bin') chromeos-config-tools-0.0.1-r665: AssertionError: Lists differ: [TouchFile(firmware='elan/0a97... != [TouchFile(firmware='elan/0a97... chromeos-config-tools-0.0.1-r665: chromeos-config-tools-0.0.1-r665: First differing element 5: chromeos-config-tools-0.0.1-r665: TouchFile(firmware='wacom/4209.hex', symlink='wacom_firmware_WHITETIP2.bin') chromeos-config-tools-0.0.1-r665: TouchFile(firmware='wacom/4209.hex', symlink='wacom_firmware_PYRO.bin') chromeos-config-tools-0.0.1-r665: chromeos-config-tools-0.0.1-r665: First list contains 3 additional elements. chromeos-config-tools-0.0.1-r665: First extra element 6: chromeos-config-tools-0.0.1-r665: TouchFile(firmware='wacom/4209.hex', symlink='wacom_firmware_WHITETIP.bin') chromeos-config-tools-0.0.1-r665: chromeos-config-tools-0.0.1-r665: Diff is 925 characters long. Set self.maxDiff to None to see it. chromeos-config-tools-0.0.1-r665: chromeos-config-tools-0.0.1-r665: ---------------------------------------------------------------------- chromeos-config-tools-0.0.1-r665: Ran 17 tests in 0.256s chromeos-config-tools-0.0.1-r665: chromeos-config-tools-0.0.1-r665: FAILED (failures=1) chromeos-config-tools-0.0.1-r665: * ERROR: chromeos-base/chromeos-config-tools-0.0.1-r665::chromiumos failed (test phase): chromeos-config-tools-0.0.1-r665: * cros_config unit tests have errors
,
Oct 18 2017
Chumped the following reverts to fix the unittests failure https://chromium-review.googlesource.com/c/chromiumos/platform2/+/724363 https://chromium-review.googlesource.com/c/chromiumos/platform2/+/724527 https://chromium-review.googlesource.com/c/chromiumos/platform2/+/724300 https://chromium-review.googlesource.com/c/chromiumos/platform2/+/724129
,
Oct 18 2017
I think this was due to a test relying on the order of two namedtuple objects, where the first field was the same for two of them, and thus the order was indeterminate. I resubmitted the CLs without that. I don't think this is a problem with test coverage, and in particular it doesn't matter which board you run chromeos-config-tools on. It is board-agnostic.
,
Oct 18 2017
We should consider reverting https://chromium-review.googlesource.com/c/chromiumos/platform/firmware/+/724364 and just run the pre-CQ on one board, or perhaps one ARM, one x86.
,
Nov 4 2017
,
Nov 10 2017
You may have fixed this - assigning to you
,
Nov 10 2017
I didn't fix it, but I also haven't seen this error. Lets call it fixed. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nxia@chromium.org
, Oct 18 2017