Issue metadata
Sign in to add a comment
|
DevTools: tracing is started before profiler has completed initialization |
||||||||||||||||||||||
Issue descriptionChrome Version: ToT, #509424 What steps will reproduce the problem? (1) Open DevTools on a page with a huge heap (e.g. gmail that was running for a week or so) (2) Switch to Performance panel (3) Start recording, then stop after a few seconds Note large gray event at the start of Timeline (see attached screenshot). This is profiler starting up, as it needs to traverse the entire heap. We used to exclude this from user traces by waiting for profiler to start before enabling tracing, but now we don't, and the event looks rather confusing.
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bde2f24b78088eea059e474da51a6ec109aeb0bb commit bde2f24b78088eea059e474da51a6ec109aeb0bb Author: Andrey Kosyakov <caseq@chromium.org> Date: Wed Oct 18 03:33:05 2017 DevTools: properly await profiler start before starting tracing we were waiting for undefined instead of a promise. Bug: 775756 Change-Id: I2fcddae0df9aaab48aa803787b46e87aa72ed61e Reviewed-on: https://chromium-review.googlesource.com/724427 Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#509673} [modify] https://crrev.com/bde2f24b78088eea059e474da51a6ec109aeb0bb/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfilerModel.js
,
Nov 13 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by alph@chromium.org
, Oct 18 2017