New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 775751 link

Starred by 1 user
Status: Fixed
Owner:
█ robert...@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Cc:
chanli@chromium.org
█ robert...@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 774703



Sign in to add a comment

Retry calls to logdog for up to 3 minutes.

Project Member Reported by robert...@chromium.org, Oct 17 2017 
Logdog logs can be delayed up to 3 minutes due to pubsub latency, this means that if our pipelines query for step logs immediately after the tryjob is complete, there's a chance the log will not be present immediately.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0f15b9384769d91d0a5f6c7077025abef80687ac

commit 0f15b9384769d91d0a5f6c7077025abef80687ac
Author: Roberto Carrillo <robertocn@google.com>
Date: Fri Oct 20 18:18:19 2017

[Findit] Let calls to rpc_util override retries, timeout, etc.

By piping keyword arguments to calls to rpc_util down to the .Post()
call of the http client instance, we let calls to services such as
logdog use configurations different from the defaults.

Also, make sure that calls to logdog use up to 7 retries with
exponential backoff (to reach the ~3 minute max propagation delay).

R=chanli,stgao,lijeffrey,wylieb
BUG= 775751 

Change-Id: I8cc1123e0e5a87349201f914a5f5ef997c3b238d
Reviewed-on: https://chromium-review.googlesource.com/724523
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/0f15b9384769d91d0a5f6c7077025abef80687ac/appengine/findit/common/rpc_util.py
[modify] https://crrev.com/0f15b9384769d91d0a5f6c7077025abef80687ac/appengine/findit/infra_api_clients/logdog_util.py

Comment 2 by robert...@chromium.org, Oct 26 2017

Status: Fixed (was: Started)
►

Sign in to add a comment