New issue
Advanced search Search tips

Issue 775748 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Add XMPP logging to diagnose connection failures

Project Member Reported by jamiewa...@chromium.org, Oct 17 2017

Issue description

We are seeing an incidence of XMPP timeouts higher than the historical average. We should add logging to diagnose where the failure occurs.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48d251f9bfe6b49da2b47e63cebf088bac364391

commit 48d251f9bfe6b49da2b47e63cebf088bac364391
Author: Jamie Walch <jamiewalch@chromium.org>
Date: Wed Oct 18 20:02:46 2017

Add XMPP logging.

Bug:  775748 
Change-Id: Id49b1a54fbcbb4ead1b093822be59753420ef983
Reviewed-on: https://chromium-review.googlesource.com/724293
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Kelvin Poon <kelvinp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509846}
[modify] https://crrev.com/48d251f9bfe6b49da2b47e63cebf088bac364391/remoting/webapp/base/js/xmpp_connection.js
[modify] https://crrev.com/48d251f9bfe6b49da2b47e63cebf088bac364391/remoting/webapp/base/js/xmpp_login_handler.js

Labels: Merge-Request-63 OS-Chrome OS-Linux OS-Mac OS-Windows

Comment 3 by gkihumba@google.com, Oct 19 2017

Labels: -Merge-Request-63 Merge-Approved-63

Comment 4 by gkihumba@google.com, Oct 19 2017

Labels: -Merge-Approved-63 Merge-Request-63
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 19 2017

Labels: merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26131f43639db30d7e5cdb395819a70242140ade

commit 26131f43639db30d7e5cdb395819a70242140ade
Author: Jamie Walch <jamiewalch@chromium.org>
Date: Thu Oct 19 18:31:15 2017

Add XMPP logging.

Bug:  775748 
Change-Id: Id49b1a54fbcbb4ead1b093822be59753420ef983
Reviewed-on: https://chromium-review.googlesource.com/724293
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Kelvin Poon <kelvinp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509846}(cherry picked from commit 48d251f9bfe6b49da2b47e63cebf088bac364391)
Reviewed-on: https://chromium-review.googlesource.com/728403
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#80}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/26131f43639db30d7e5cdb395819a70242140ade/remoting/webapp/base/js/xmpp_connection.js
[modify] https://crrev.com/26131f43639db30d7e5cdb395819a70242140ade/remoting/webapp/base/js/xmpp_login_handler.js

Status: Fixed (was: Assigned)

Comment 7 by gov...@chromium.org, Oct 19 2017

Labels: -Merge-Request-63
This got already merged at #5. Hence, removing "Merge-Request-63" label. 

jamiewalch@, is the change look good in Canary?


It's a Chromoting change, so it won't appear in Chrome canary.

Sign in to add a comment