arc: There is no menu for deferred app launch. |
|||||||||
Issue descriptionRepro: 1. Use any default app and start ARC OptIn 2. Spinning icon should appear on the shelf. 3. Activate context menu for spinning icon. Expected: Item has menu with close and pin actions. Actual: Menu contains only generic shelf actions. Regression since M62
,
Oct 23 2017
,
Oct 23 2017
This is UI regression in M62. Requesting merge
,
Oct 23 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 23 2017
Do we need this in 63 also? Approved for both if so.
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c52a968f10375dd4ab70c28478b5068b977ace45 commit c52a968f10375dd4ab70c28478b5068b977ace45 Author: khmel <khmel@google.com> Date: Tue Oct 24 23:57:02 2017 [Merge M63] arc: Restore deferred controller item menu. This fixes regression when ARC deferred launch controller does not have a menu and user cannot closes launch request and pin/unpin item. TBR=khmel@google.com, msw@chromium.org (cherry picked from commit 7df0afaf17dc235754d3949b6901bfd6822b2a96) Test: Manually on device. Unit test added Bug: 775744 Change-Id: I85d902a77a251d2958f9cd2a42dd7c10a393d6c0 Reviewed-on: https://chromium-review.googlesource.com/724460 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509686} Reviewed-on: https://chromium-review.googlesource.com/736678 Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#200} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/c52a968f10375dd4ab70c28478b5068b977ace45/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_item_controller.cc [modify] https://crrev.com/c52a968f10375dd4ab70c28478b5068b977ace45/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_item_controller.h [modify] https://crrev.com/c52a968f10375dd4ab70c28478b5068b977ace45/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a77b0fd68ed2fde333e24351b18c0d910868ba35 commit a77b0fd68ed2fde333e24351b18c0d910868ba35 Author: khmel <khmel@google.com> Date: Wed Oct 25 01:36:46 2017 [Merge M62] arc: Restore deferred controller item menu. This fixes regression when ARC deferred launch controller does not have a menu and user cannot closes launch request and pin/unpin item. TBR=khmel@google.com, msw@chromium.org (cherry picked from commit 7df0afaf17dc235754d3949b6901bfd6822b2a96) Test: Manually on device. Unit test added Bug: 775744 Change-Id: I85d902a77a251d2958f9cd2a42dd7c10a393d6c0 Reviewed-on: https://chromium-review.googlesource.com/724460 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509686} Reviewed-on: https://chromium-review.googlesource.com/736683 Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#741} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/a77b0fd68ed2fde333e24351b18c0d910868ba35/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_item_controller.cc [modify] https://crrev.com/a77b0fd68ed2fde333e24351b18c0d910868ba35/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_item_controller.h [modify] https://crrev.com/a77b0fd68ed2fde333e24351b18c0d910868ba35/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
,
Oct 25 2017
,
Nov 9 2017
Verified on M64 dev build (10109.0.0, 64.0.3261.0).
,
Nov 9 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 18 2017