New issue
Advanced search Search tips

Issue 775708 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug
Team-Accessibility


Participants' hotlists:
Accessibility-Desktop-Dialog


Sign in to add a comment

[A11y - Dialog] Some popovers are not keyboard-navigable when they’re on foreground and not focused

Project Member Reported by hwi@chromium.org, Oct 17 2017

Issue description

Chrome Version       : Stable 61.0.3163.100
OS Version           : Win10
Screenreader         : NVDA

With or without screenreader, the following popovers are not keyboard-navigable when they’re on foreground and not focused:
- Save credit card
- Translate

Recommended fixes:
- When the popover is on foreground and the keyboard navigates to their anchor icons, set focus to the initial focus item in the popover, e.g. Save password
- Once the focus enters the popover, trap the focus


Video* (issue):
https://drive.google.com/open?id=0B1VXa3kr2lYjSVpZdFM4Vi1hQms

Video* (not issue, correct reference):
https://drive.google.com/open?id=0B1VXa3kr2lYjRlJnbjYxOUhxZWs

Full doc*: go/ar-dialogs-win-2017
*: Docs and videos are google internal


Related notes:
- If an implementation to fix this bug covers all other dialogs in the same type, it will be ideal.
- If it's a spot fix for a listed dialog, we can still use the fix as a reference for future fixes for others. 
- Please discuss if the issue needs to be clarified further, and/or if there's an alternative fix. 
- Independently, expanded tests are needed for 1) Harmony flag enabled, 2) Win10+JAWS, 3) CrOS+ChromeVox, and 4) OSX+VO, and also modification of this bug is needed if the same issue occurs on 1)-4).

Thanks!


 

Comment 1 by hwi@chromium.org, Oct 17 2017

Summary: [A11y - Dialog] Some popovers are not keyboard-navigable when they’re on foreground and not focused (was: Some popovers are not keyboard-navigable when they’re on foreground and not focused)

Comment 2 by hwi@chromium.org, Oct 17 2017

Description: Show this description

Comment 3 by hwi@chromium.org, Oct 18 2017

Harmony (chrome://flags/#secondary-ui-md) has the same issue. 
Tested on Canary 64.0.3243.1, Win10, NVDA

Comment 4 by hwi@chromium.org, Oct 30 2017

Status: Available (was: Untriaged)
Labels: win-a11y
Labels: dialogs
Labels: win-a11y-large

Comment 8 by dtseng@chromium.org, Jan 11 2018

Owner: dtseng@chromium.org
Status: started (was: Available)
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0b1b644cd36bf7e4d3a9af373c748ee17482feb

commit c0b1b644cd36bf7e4d3a9af373c748ee17482feb
Author: David Tseng <dtseng@chromium.org>
Date: Wed Jan 24 07:12:27 2018

Provide accessibility and keyboard access to inactive bubble widgets

Bug:  775714 ,  775708 , 728187 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7d85663d4db0c3661e2fc3de8d135a17a7c01258
Reviewed-on: https://chromium-review.googlesource.com/861950
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531468}
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/app/chrome_command_ids.h
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/app/chrome_dll.rc
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/app/generated_resources.grd
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/browser/ui/browser_commands.h
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/browser/ui/browser_window.h
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/browser/ui/cocoa/browser_window_cocoa.h
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/browser/ui/views/accelerator_table.cc
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/browser/ui/views/location_bar/bubble_icon_view.h
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/chrome/test/base/test_browser_window.h
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/tools/metrics/actions/actions.xml
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/ui/views/accessibility/view_accessibility.cc
[modify] https://crrev.com/c0b1b644cd36bf7e4d3a9af373c748ee17482feb/ui/views/accessibility/view_accessibility.h

Status: fixed (was: Started)

Sign in to add a comment