Issue metadata
Sign in to add a comment
|
[A11y - Dialog] Non-focus-taking popovers are not announced when they appear |
||||||||||||||||||||||
Issue descriptionChrome Version : Stable 61.0.3163.100 OS Version : Win10 Screenreader : NVDA The issue occurs on non-focus-taking popovers only. To compare, popovers that automatically take focus when appearing are announced (e.g. Permission, Extension added). Repro the issue from the following non-focus-taking popovers: - Save password - Save credit card - Auto sign-in The issue makes the popovers not perceivable at all. Recommended fixes: - The entire content of a popover should be announced when the popover appears - Non-focus-taking behavior should continue to be preserved, i.e. do not steal focus Video* (non-focus-taking, issue): https://drive.google.com/open?id=0B1VXa3kr2lYjeERiSmFhYUh1UDA Video* (auto-focus-taking, not issue, correct reference): https://drive.google.com/open?id=0B1VXa3kr2lYjZkZ0b1dxTUc1ZDg Full doc*: go/ar-dialogs-win-2017 *: Docs and videos are google internal Related notes: - If an implementation to fix this bug covers all other dialogs in the same type, it will be ideal. - If it's a spot fix for a listed dialog, we can still use the fix as a reference for future fixes for others. - Please discuss if the issue needs to be clarified further, and/or if there's an alternative fix. - Independently, expanded tests are needed for 1) Harmony flag enabled, 2) Win10+JAWS, 3) CrOS+ChromeVox, and 4) OSX+VO, and also modification of this bug is needed if the same issue occurs on 1)-4). Thanks!
,
Oct 17 2017
,
Oct 17 2017
,
Oct 18 2017
Harmony (chrome://flags/#secondary-ui-md) has the same issue. Tested on Canary 64.0.3243.1, Win10, NVDA
,
Oct 30 2017
,
Dec 14 2017
,
Dec 15 2017
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd19640f93eb1a82a0f2cba3d6231f307e0faef4 commit dd19640f93eb1a82a0f2cba3d6231f307e0faef4 Author: Nektarios Paisios <nektar@chromium.org> Date: Thu Mar 29 18:46:34 2018 Views: Modified all bubbles to have an alert dialog role and deleted accessible name This small patch fixes a few related bugs. 1. Assigned an alert dialog role for all bubbles. An alert dialog role makes the contents of a dialog be announced by a screen reader when the dialog appears. Bubbles are non-modal and thus should be announced as soon as they appear because otherwise the user will not know if they are there. However, some Windows screen readers do not yet properly support the alert dialog role. For Windows only, we can switch to the system alert role temporarily until screen reader vendors provide a fix. 2. ARIA Spec compliant? The ARIA Spec dictates that an alert dialog role should only be used for modal dialogs. However, there is no other spec-compliant way to announce the contents of a dialog. 3. Deleted accessible name from any dialogs. The ARIA Spec also dictates that alert dialogs should have an accessible name. However, this patch modifies Views. In Views all dialogs have a title bar. Having both an accessible name and a title bar makes Windows screen readers announce the title twice. 4. Applied to all bubbles by default. Since most bubbles are non-modal and need to be announced as soon as they appear, alert dialog should become the default role. Subclasses can override if needed and switch back to a dialog role. Having a role of dialog doesn't announce anything on Windows when the dialog is non-modal. R=dtseng@chromium.org, aleventhal@chromium.org Bug: 775705 , 779297 , 474622 Change-Id: I062110757cd4c400b31aa3cb89c622002699408e Tested: Jaws and NVDA with permission, password save and zoom bubbles. Reviewed-on: https://chromium-review.googlesource.com/967465 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#546891} [modify] https://crrev.com/dd19640f93eb1a82a0f2cba3d6231f307e0faef4/chrome/app/generated_resources.grd [modify] https://crrev.com/dd19640f93eb1a82a0f2cba3d6231f307e0faef4/chrome/browser/ui/views/conflicting_module_view_win.cc [modify] https://crrev.com/dd19640f93eb1a82a0f2cba3d6231f307e0faef4/chrome/browser/ui/views/conflicting_module_view_win.h [modify] https://crrev.com/dd19640f93eb1a82a0f2cba3d6231f307e0faef4/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc [modify] https://crrev.com/dd19640f93eb1a82a0f2cba3d6231f307e0faef4/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc [modify] https://crrev.com/dd19640f93eb1a82a0f2cba3d6231f307e0faef4/content/browser/accessibility/dump_accessibility_tree_browsertest.cc [modify] https://crrev.com/dd19640f93eb1a82a0f2cba3d6231f307e0faef4/ui/accessibility/platform/ax_platform_node_win.cc [modify] https://crrev.com/dd19640f93eb1a82a0f2cba3d6231f307e0faef4/ui/views/bubble/bubble_dialog_delegate.cc [modify] https://crrev.com/dd19640f93eb1a82a0f2cba3d6231f307e0faef4/ui/views/bubble/bubble_dialog_delegate.h [modify] https://crrev.com/dd19640f93eb1a82a0f2cba3d6231f307e0faef4/ui/views/bubble/tray_bubble_view.cc [modify] https://crrev.com/dd19640f93eb1a82a0f2cba3d6231f307e0faef4/ui/views/bubble/tray_bubble_view.h
,
Mar 29 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by hwi@chromium.org
, Oct 17 2017