Better handling of lock screen app crash |
|||
Issue descriptionCurrently, when the note taking app crashes on the lock screen, the lock screen UI does not change (other than the app window getting closed) - i.e. the lock screen UI still displays the lock screen note launcher element in the right corner of the screen, even though the button will not work any more (given that the target app is not loaded in the lock screen profile any more). When the app is unloaded in the lock screen profile (e.g. due to extension crash), we should at least remove the UI element from the lock screen UI (until the screen gets locked next time, or the app gets reloaded). Additionally, we might think about showing some UI informing the user that the lock screen app has crashed, and offering an option to reload the app.
,
Nov 17 2017
,
Nov 27 2017
Just to make sure I understand, is this correct? 1. The user is taking a lock screen note 2. The app crashes. The user will see the lock screen 3. If the user taps the button to take a lock screen note it will not work Like Tom suggested, could we use the note button to reload the app? Then we could show any potential messaging about the crash within the app instead of on the lock screen.
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9095c93718c77f437ed7be13ebf05068db8031fd commit 9095c93718c77f437ed7be13ebf05068db8031fd Author: Toni Barzic <tbarzic@google.com> Date: Thu Dec 21 05:40:06 2017 Reload lock screen apps after app crash Adds logic to lock_screen_app::AppManagerImpl to handle note taking unload/uninstall from the lock screen apps profile. If the app is unloaded due to it being terminated (which could happen if the app render process crashes), the lock screen note taking will remain being available - the internal AppManagerImpl state will not change, and the app will be reloaded in the lock screen apps profile when the app launch is next requested (the number of reload attempts within a lock session will be bounded). If the app is unloaded for any other reason, or uninstalled, the note taking will be disabled until the app manager is restarted. Bug: 775702 Change-Id: Iac67eb509168c0f9193ad37c2f74787c979652a3 Reviewed-on: https://chromium-review.googlesource.com/802697 Reviewed-by: Gayane Petrosyan <gayane@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#525625} [modify] https://crrev.com/9095c93718c77f437ed7be13ebf05068db8031fd/chrome/browser/chromeos/lock_screen_apps/app_manager_impl.cc [modify] https://crrev.com/9095c93718c77f437ed7be13ebf05068db8031fd/chrome/browser/chromeos/lock_screen_apps/app_manager_impl.h [modify] https://crrev.com/9095c93718c77f437ed7be13ebf05068db8031fd/chrome/browser/chromeos/lock_screen_apps/app_manager_impl_unittest.cc [modify] https://crrev.com/9095c93718c77f437ed7be13ebf05068db8031fd/tools/metrics/histograms/enums.xml [modify] https://crrev.com/9095c93718c77f437ed7be13ebf05068db8031fd/tools/metrics/histograms/histograms.xml
,
Dec 21 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tbuck...@chromium.org
, Nov 17 2017