Change WebStateObserver to observer multiple WebStates |
|||
Issue descriptionMost observer in chrome allow observing multiple object, except for WebStateObserver, leading to multiple workaround (Tab forwarding its notification to TabModel that forward it to its observer, TabUsageRecorder using a std::map<WebState*, std::unique_ptr<WebStateObserver>>, ...). Instead WebStateObserver should be changed to allow observing multiple WebState, this requires: 1. changing the observer interface to receive the WebState as a first parameter, 2. updating client to use the new API, 3. removing the old API, 4. removing the workarounds.
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3212e2afdd4f82a7ac9fa444c8280eaec4844084 commit 3212e2afdd4f82a7ac9fa444c8280eaec4844084 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Oct 18 21:32:49 2017 Pass WebState to WebStateObserver methods. In preparation of allowing WebStateObserver to observe multiple WebStates, pass the WebState as first parameter to all of the methods of WebStateObserver. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I041f66d1bc4a5f905acbf68aafea8b5a11efe306 Reviewed-on: https://chromium-review.googlesource.com/724521 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#509881} [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/components/dom_distiller/ios/distiller_page_ios.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/components/favicon/ios/web_favicon_driver.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/components/favicon/ios/web_favicon_driver.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/components/history/ios/browser/web_state_top_sites_observer.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/components/history/ios/browser/web_state_top_sites_observer.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/components/translate/ios/browser/ios_translate_driver.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/components/translate/ios/browser/ios_translate_driver.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/components/translate/ios/browser/language_detection_controller.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/components/translate/ios/browser/language_detection_controller.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/components/translate/ios/browser/translate_controller.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/components/translate/ios/browser/translate_controller.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/autofill/autofill_tab_helper.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/autofill/autofill_tab_helper.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/autofill/form_input_accessory_view_tab_helper.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/autofill/form_input_accessory_view_tab_helper.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/autofill/form_suggestion_tab_helper.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/autofill/form_suggestion_tab_helper.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/find_in_page/find_tab_helper.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/find_in_page/find_tab_helper.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/history/history_tab_helper.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/history/history_tab_helper.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/infobars/infobar_manager_impl.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/infobars/infobar_manager_impl.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/metrics/tab_usage_recorder.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/passwords/password_tab_helper.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/passwords/password_tab_helper.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/reading_list/favicon_web_state_dispatcher_impl_unittest.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/reading_list/reading_list_web_state_observer.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/translate/chrome_ios_translate_client.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/translate/chrome_ios_translate_client.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/ui/browser_list/browser_list_session_service_impl.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/ui/contextual_search/contextual_search_web_state_observer.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/ui/contextual_search/contextual_search_web_state_observer.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/ui/dialogs/dialog_presenter_unittest.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/ui/dialogs/java_script_dialog_blocking_state.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/ui/dialogs/java_script_dialog_blocking_state.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/ui/dialogs/java_script_dialog_blocking_state_unittest.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/voice/text_to_speech_listener.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/web/network_activity_indicator_tab_helper.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/web/network_activity_indicator_tab_helper.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/web/page_placeholder_tab_helper.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/web/page_placeholder_tab_helper.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/web/print_tab_helper.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/web/print_tab_helper.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/web/repost_form_tab_helper.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/web/repost_form_tab_helper.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/web/sad_tab_tab_helper.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/chrome/browser/web/sad_tab_tab_helper.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/clean/chrome/browser/ui/overlays/overlay_scheduler.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/clean/chrome/browser/ui/overlays/overlay_scheduler.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/interstitials/web_interstitial_impl.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/interstitials/web_interstitial_impl.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/public/test/fakes/test_web_state.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/public/test/fakes/test_web_state_observer.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/public/test/fakes/test_web_state_observer.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/public/test/test_redirect_observer.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/public/test/test_redirect_observer.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/public/test/web_test_with_web_state.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/public/web_state/web_state_observer.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/public/web_state/web_state_observer_bridge.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/test/web_int_test.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/web_state/favicon_callbacks_inttest.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/web_state/global_web_state_event_tracker.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/web_state/navigation_callbacks_inttest.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/web_state/ui/crw_web_controller_unittest.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/web_state/web_controller_observer_bridge.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/web_state/web_controller_observer_bridge.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/web_state/web_state_impl.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/web_state/web_state_observer_bridge.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web/web_state/web_state_observer_bridge_unittest.mm [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web_view/internal/translate/web_view_translate_client.h [modify] https://crrev.com/3212e2afdd4f82a7ac9fa444c8280eaec4844084/ios/web_view/internal/translate/web_view_translate_client.mm
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57b086d561bd353fa6f8036f90219451971d8343 commit 57b086d561bd353fa6f8036f90219451971d8343 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Oct 26 17:50:19 2017 Allow WebStateObserver to observe N WebStates [1/N]. To allow using the same WebStateObserver to watch multiple WebState, make the method to register (and unregister) an observer with a WebState public. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib4b97b5d9a4fd6aa7eae6dc293b5a4ad64bafb2a Reviewed-on: https://chromium-review.googlesource.com/738871 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#511875} [modify] https://crrev.com/57b086d561bd353fa6f8036f90219451971d8343/ios/web/public/web_state/web_state.h [modify] https://crrev.com/57b086d561bd353fa6f8036f90219451971d8343/ios/web/public/web_state/web_state_observer.h [modify] https://crrev.com/57b086d561bd353fa6f8036f90219451971d8343/ios/web/web_state/web_state_impl.h [modify] https://crrev.com/57b086d561bd353fa6f8036f90219451971d8343/ios/web/web_state/web_state_observer.mm
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbb6a6244c1cbfeb7242043aa7eb19e156751b1e commit cbb6a6244c1cbfeb7242043aa7eb19e156751b1e Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Oct 30 15:23:05 2017 Allow WebStateObserver to observe N WebStates [2/N]. Convert WebStateObserverBridge to allow client code to control which WebStates are observed. Still support the constructor to let WebStateObserverBridge itself manages the registration. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I06cc3f8d84f708f493221042a0257ede143b91d0 Reviewed-on: https://chromium-review.googlesource.com/738864 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#512498} [modify] https://crrev.com/cbb6a6244c1cbfeb7242043aa7eb19e156751b1e/ios/web/public/web_state/web_state_observer_bridge.h [modify] https://crrev.com/cbb6a6244c1cbfeb7242043aa7eb19e156751b1e/ios/web/web_state/web_state_observer_bridge.mm
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d0fbe3096a8e2eef6c6e368e51f61e4a6fbd2b4 commit 6d0fbe3096a8e2eef6c6e368e51f61e4a6fbd2b4 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Oct 30 16:11:08 2017 Allow WebStateObserver to observe N WebStates [3/N]. Convert TabUsageRecorder to observe to all WebStates inserted in the WebStateList it observes. Remove the helper class that was required when WebStateObserver could only observe a single WebState. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icb42548d628465e16f91613c7c881f3ff269cb58 Reviewed-on: https://chromium-review.googlesource.com/738872 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#512506} [modify] https://crrev.com/6d0fbe3096a8e2eef6c6e368e51f61e4a6fbd2b4/ios/chrome/browser/metrics/tab_usage_recorder.h [modify] https://crrev.com/6d0fbe3096a8e2eef6c6e368e51f61e4a6fbd2b4/ios/chrome/browser/metrics/tab_usage_recorder.mm
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44c20ad5eaffd6e336afeae1f85a08c193c4d273 commit 44c20ad5eaffd6e336afeae1f85a08c193c4d273 Author: Menglu Huang <huangml@chromium.org> Date: Mon Oct 30 18:23:06 2017 Revert "Allow WebStateObserver to observe N WebStates [2/N]." This reverts commit cbb6a6244c1cbfeb7242043aa7eb19e156751b1e. Reason for revert: <INSERT REASONING HERE> Revert the CL for breaking some content suggestions egtests, e.g. ContentSuggestionsTestCase/testAdditionalItemsKept Link: https://build.chromium.org/p/chromium.mac/builders/ios-simulator-full-configs/builds/59 Original change's description: > Allow WebStateObserver to observe N WebStates [2/N]. > > Convert WebStateObserverBridge to allow client code to control > which WebStates are observed. Still support the constructor to > let WebStateObserverBridge itself manages the registration. > > Bug: 775684 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I06cc3f8d84f708f493221042a0257ede143b91d0 > Reviewed-on: https://chromium-review.googlesource.com/738864 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#512498} TBR=sdefresne@chromium.org,eugenebut@chromium.org Change-Id: I880597b95b92aacd5f1bbcc844eef972c9ddd2eb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/744082 Reviewed-by: Menglu Huang <huangml@chromium.org> Commit-Queue: Menglu Huang <huangml@chromium.org> Cr-Commit-Position: refs/heads/master@{#512533} [modify] https://crrev.com/44c20ad5eaffd6e336afeae1f85a08c193c4d273/ios/web/public/web_state/web_state_observer_bridge.h [modify] https://crrev.com/44c20ad5eaffd6e336afeae1f85a08c193c4d273/ios/web/web_state/web_state_observer_bridge.mm
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f52006d2f086e2e59611c65680b8e0c6474a7d28 commit f52006d2f086e2e59611c65680b8e0c6474a7d28 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Nov 02 16:12:29 2017 Allow WebStateObserver to observe N WebStates [2/N]. Convert WebStateObserverBridge to allow client code to control which WebStates are observed. Still support the constructor to let WebStateObserverBridge itself manages the registration. Reland of https://chromium-review.googlesource.com/738864 with a fix to support null WebState passed to the constructor (some tests do pass null). Bug: 775684 Change-Id: Ib29386d61dc44042f37a3c7e10f4545411a73b1f Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/749944 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#513503} [modify] https://crrev.com/f52006d2f086e2e59611c65680b8e0c6474a7d28/ios/web/public/web_state/web_state_observer_bridge.h [modify] https://crrev.com/f52006d2f086e2e59611c65680b8e0c6474a7d28/ios/web/web_state/web_state_observer_bridge.mm
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b55fa67871d9907948060e09dc101d85b7e80c8f commit b55fa67871d9907948060e09dc101d85b7e80c8f Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Nov 02 17:50:37 2017 Allow WebStateObserver to observe N WebStates [4/N]. Convert CRWWebController to explicitly control the registration of the WebControllerObserverBridge with its WebState. Convert CRWWebController to use CRBProtocolObservers to track the registration of CRWWebControllerObserver. This avoid duplicating code to handle weak pointers to observers. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I91098b7f5852079d5d744a2fcee96e7e35f92fa9 Reviewed-on: https://chromium-review.googlesource.com/738888 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#513542} [modify] https://crrev.com/b55fa67871d9907948060e09dc101d85b7e80c8f/ios/web/web_state/ui/crw_web_controller.h [modify] https://crrev.com/b55fa67871d9907948060e09dc101d85b7e80c8f/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/b55fa67871d9907948060e09dc101d85b7e80c8f/ios/web/web_state/ui/crw_web_controller_unittest.mm [modify] https://crrev.com/b55fa67871d9907948060e09dc101d85b7e80c8f/ios/web/web_state/web_controller_observer_bridge.h [modify] https://crrev.com/b55fa67871d9907948060e09dc101d85b7e80c8f/ios/web/web_state/web_controller_observer_bridge.mm
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f50f26f8d1969ae6b21c2b2951cc2a3e9e45b27 commit 0f50f26f8d1969ae6b21c2b2951cc2a3e9e45b27 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Nov 03 12:43:23 2017 Allow WebStateObserver to observe N WebStates [5/N]. Convert GlobalWebStateEventTracker to directly observe the WebStates instead of using a separate WebStateObserver for each WebState. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibccd2b28aa6394e32138629d132cd4075af0155e Reviewed-on: https://chromium-review.googlesource.com/738918 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#513753} [modify] https://crrev.com/0f50f26f8d1969ae6b21c2b2951cc2a3e9e45b27/ios/web/web_state/global_web_state_event_tracker.h [modify] https://crrev.com/0f50f26f8d1969ae6b21c2b2951cc2a3e9e45b27/ios/web/web_state/global_web_state_event_tracker.mm
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5fb9499fb8bef50b699b088d4a6b5c652c1d82b commit b5fb9499fb8bef50b699b088d4a6b5c652c1d82b Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Nov 03 13:31:28 2017 Allow WebStateObserver to observe N WebStates [6/N]. Convert WebStateInterstitialImpl to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Remove unused method WebInterstitial::GetWebInterstitial(). Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I05db3042870c0a8458750d2089ee4faaffe00bf3 Reviewed-on: https://chromium-review.googlesource.com/738624 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#513759} [modify] https://crrev.com/b5fb9499fb8bef50b699b088d4a6b5c652c1d82b/ios/web/interstitials/web_interstitial_impl.h [modify] https://crrev.com/b5fb9499fb8bef50b699b088d4a6b5c652c1d82b/ios/web/interstitials/web_interstitial_impl.mm [modify] https://crrev.com/b5fb9499fb8bef50b699b088d4a6b5c652c1d82b/ios/web/public/interstitials/web_interstitial.h
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e46f65774fb9a3d837d83f30a92a00c294f39a4d commit e46f65774fb9a3d837d83f30a92a00c294f39a4d Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Nov 03 13:43:19 2017 Allow WebStateObserver to observe N WebStates [7/N]. Convert test WebStateObserver subclasses to directly manage the registration with WebState instead of dependending on the deprecated code from WebStateObserver. Bug: 775684 Change-Id: I2c209d662794d2b1d7bbeb09e377f03f359e184f Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/738675 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#513761} [modify] https://crrev.com/e46f65774fb9a3d837d83f30a92a00c294f39a4d/ios/web/public/test/fakes/test_web_state_observer.h [modify] https://crrev.com/e46f65774fb9a3d837d83f30a92a00c294f39a4d/ios/web/public/test/fakes/test_web_state_observer.mm [modify] https://crrev.com/e46f65774fb9a3d837d83f30a92a00c294f39a4d/ios/web/public/test/web_test_with_web_state.mm [modify] https://crrev.com/e46f65774fb9a3d837d83f30a92a00c294f39a4d/ios/web/web_state/navigation_callbacks_inttest.mm [modify] https://crrev.com/e46f65774fb9a3d837d83f30a92a00c294f39a4d/ios/web/web_state/ui/crw_web_controller_unittest.mm
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf6c42efe66fa71309a794abcb34a50e9713df74 commit bf6c42efe66fa71309a794abcb34a50e9713df74 Author: Mike Baxley <baxley@chromium.org> Date: Fri Nov 03 16:19:11 2017 Revert "Allow WebStateObserver to observe N WebStates [6/N]." This reverts commit b5fb9499fb8bef50b699b088d4a6b5c652c1d82b. Reason for revert: Broke downstream interstitial tests. Original change's description: > Allow WebStateObserver to observe N WebStates [6/N]. > > Convert WebStateInterstitialImpl to directly track registration > with the observed WebState instead of relying on the deprecated > code in WebStateObserver. > > Remove unused method WebInterstitial::GetWebInterstitial(). > > Bug: 775684 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I05db3042870c0a8458750d2089ee4faaffe00bf3 > Reviewed-on: https://chromium-review.googlesource.com/738624 > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#513759} TBR=sdefresne@chromium.org,eugenebut@chromium.org Change-Id: Ife65d281aa1887e071000993d96405260a2b8e99 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/754001 Reviewed-by: Mike Baxley <baxley@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#513797} [modify] https://crrev.com/bf6c42efe66fa71309a794abcb34a50e9713df74/ios/web/interstitials/web_interstitial_impl.h [modify] https://crrev.com/bf6c42efe66fa71309a794abcb34a50e9713df74/ios/web/interstitials/web_interstitial_impl.mm [modify] https://crrev.com/bf6c42efe66fa71309a794abcb34a50e9713df74/ios/web/public/interstitials/web_interstitial.h
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d14904256af6984ca25dc58c44862d31717c27ee commit d14904256af6984ca25dc58c44862d31717c27ee Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Nov 07 16:53:35 2017 Allow WebStateObserver to observe N WebStates [6/N]. Convert WebStateInterstitialImpl to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Remove unused method WebInterstitial::GetWebInterstitial(). Reland of https://chromium-review.googlesource.com/738624 with a fix for the crash. WebInterstitialImpl::DoProcess() delete "this" so unregister the observer before calling this method to avoid using deallocated memory. Bug: 775684 Change-Id: Ie721a32c078d2dff5a8bf989ddac66ad38c7b7f6 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/754836 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#514493} [modify] https://crrev.com/d14904256af6984ca25dc58c44862d31717c27ee/ios/web/interstitials/web_interstitial_impl.h [modify] https://crrev.com/d14904256af6984ca25dc58c44862d31717c27ee/ios/web/interstitials/web_interstitial_impl.mm [modify] https://crrev.com/d14904256af6984ca25dc58c44862d31717c27ee/ios/web/public/interstitials/web_interstitial.h
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/971f9c7714c4d446903a073317964e241acd496e commit 971f9c7714c4d446903a073317964e241acd496e Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Nov 08 14:10:00 2017 Allow WebStateObserver to observe N WebStates [8/N]. Convert DistillerPageIOS to directly implement WebStateObserver and manually track registration with WebState. Bug: 775684 Change-Id: I4aa98ff40f3e4c274b2bc0e5076b4ae1a468a9e4 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/744012 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#514814} [modify] https://crrev.com/971f9c7714c4d446903a073317964e241acd496e/components/dom_distiller/ios/distiller_page_ios.h [modify] https://crrev.com/971f9c7714c4d446903a073317964e241acd496e/components/dom_distiller/ios/distiller_page_ios.mm
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97344a8cc60a6bc1a5a884fee130ce8926186e33 commit 97344a8cc60a6bc1a5a884fee130ce8926186e33 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Nov 08 14:39:07 2017 Allow WebStateObserver to observe N WebStates [9/N]. Convert WebFaviconDriver to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: Ib4f3f917e9d610a8f58e9c83caeb14050c3d4d64 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/743627 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#514826} [modify] https://crrev.com/97344a8cc60a6bc1a5a884fee130ce8926186e33/components/favicon/ios/web_favicon_driver.h [modify] https://crrev.com/97344a8cc60a6bc1a5a884fee130ce8926186e33/components/favicon/ios/web_favicon_driver.mm
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d67c4f37d7c2bbfef518f7a4c6e74189943e4b32 commit d67c4f37d7c2bbfef518f7a4c6e74189943e4b32 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Nov 08 15:49:53 2017 Allow WebStateObserver to observe N WebStates [10/N]. Convert WebStateTopSitesObserver to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: If87cda1fb3168975719d994c456826c3f03f2d8f Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/756745 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#514844} [modify] https://crrev.com/d67c4f37d7c2bbfef518f7a4c6e74189943e4b32/components/history/ios/browser/web_state_top_sites_observer.h [modify] https://crrev.com/d67c4f37d7c2bbfef518f7a4c6e74189943e4b32/components/history/ios/browser/web_state_top_sites_observer.mm
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/969a076c45ddb7e0aa217b6944bb7db0130e4c93 commit 969a076c45ddb7e0aa217b6944bb7db0130e4c93 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Nov 08 18:07:31 2017 Revert "Allow WebStateObserver to observe N WebStates [9/N]." This reverts commit 97344a8cc60a6bc1a5a884fee130ce8926186e33. Reason for revert: break WebUITestCase in ios_chrome_ui_egtests because favicon::WebFaviconDriver::web_state() now always return null. Original change's description: > Allow WebStateObserver to observe N WebStates [9/N]. > > Convert WebFaviconDriver to directly track registration with > the observed WebState instead of relying on the deprecated > code in WebStateObserver. > > Bug: 775684 > Change-Id: Ib4f3f917e9d610a8f58e9c83caeb14050c3d4d64 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet > Reviewed-on: https://chromium-review.googlesource.com/743627 > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#514826} TBR=sdefresne@chromium.org,eugenebut@chromium.org Change-Id: I39dfdb016967d8d89fc07e8985b6aac7d5099f98 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/758996 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#514880} [modify] https://crrev.com/969a076c45ddb7e0aa217b6944bb7db0130e4c93/components/favicon/ios/web_favicon_driver.h [modify] https://crrev.com/969a076c45ddb7e0aa217b6944bb7db0130e4c93/components/favicon/ios/web_favicon_driver.mm
,
Nov 10 2017
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17b7b33f3fa3cfaf221163f9ec020b7d61e9c078 commit 17b7b33f3fa3cfaf221163f9ec020b7d61e9c078 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Nov 10 19:55:15 2017 Extract FaviconObserver to a separate class. Extract FaviconDriverObserverBridge out of TabModelObserversBridge into a separate class TabModelFaviconDriverObserver and refactor it to avoid casting the FaviconDriver to WebFaviconDriver (using a map to get the WebState associated with a FaviconDriver). The cast was the reason for reverting http://crrev.com/c/743627. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I58f2040642b93142ff299a6d6594bc1cca353092 Reviewed-on: https://chromium-review.googlesource.com/758843 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#515648} [modify] https://crrev.com/17b7b33f3fa3cfaf221163f9ec020b7d61e9c078/ios/chrome/browser/tabs/BUILD.gn [modify] https://crrev.com/17b7b33f3fa3cfaf221163f9ec020b7d61e9c078/ios/chrome/browser/tabs/tab_model.mm [add] https://crrev.com/17b7b33f3fa3cfaf221163f9ec020b7d61e9c078/ios/chrome/browser/tabs/tab_model_favicon_driver_observer.h [add] https://crrev.com/17b7b33f3fa3cfaf221163f9ec020b7d61e9c078/ios/chrome/browser/tabs/tab_model_favicon_driver_observer.mm [add] https://crrev.com/17b7b33f3fa3cfaf221163f9ec020b7d61e9c078/ios/chrome/browser/tabs/tab_model_favicon_driver_observer_unittest.mm [modify] https://crrev.com/17b7b33f3fa3cfaf221163f9ec020b7d61e9c078/ios/chrome/browser/tabs/tab_model_observers_bridge.mm
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7c39cdc5d7f2512468f64baa1e883339a0a70ed commit a7c39cdc5d7f2512468f64baa1e883339a0a70ed Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Nov 13 16:06:39 2017 Allow WebStateObserver to observe N WebStates [9/N]. Convert WebFaviconDriver to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: I7f7fcec4a57c1da79012069d971123c9e4144799 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-eg Reviewed-on: https://chromium-review.googlesource.com/758863 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#515951} [modify] https://crrev.com/a7c39cdc5d7f2512468f64baa1e883339a0a70ed/components/favicon/ios/web_favicon_driver.h [modify] https://crrev.com/a7c39cdc5d7f2512468f64baa1e883339a0a70ed/components/favicon/ios/web_favicon_driver.mm
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7077e323972649928249e4ba21e8abfc4630e31 commit f7077e323972649928249e4ba21e8abfc4630e31 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Nov 13 16:26:01 2017 Allow WebStateObserver to observe N WebStates [11/N]. Convert IOSTranslateDriver to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: Iad1d53fcab9448e088a19cd75767235f9816a0b3 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/757105 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#515956} [modify] https://crrev.com/f7077e323972649928249e4ba21e8abfc4630e31/components/translate/ios/browser/ios_translate_driver.h [modify] https://crrev.com/f7077e323972649928249e4ba21e8abfc4630e31/components/translate/ios/browser/ios_translate_driver.mm
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f4a9b82da834e351b2e3615c051272b887fe482 commit 2f4a9b82da834e351b2e3615c051272b887fe482 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Nov 13 16:50:36 2017 Allow WebStateObserver to observe N WebStates [12/N]. Convert LanguageDetectionController to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: Ib3331edef26d31e0ccb48e65eed9fc4b5de84fa3 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/757106 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#515962} [modify] https://crrev.com/2f4a9b82da834e351b2e3615c051272b887fe482/components/translate/ios/browser/language_detection_controller.h [modify] https://crrev.com/2f4a9b82da834e351b2e3615c051272b887fe482/components/translate/ios/browser/language_detection_controller.mm
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4051ebd19b3fe7cd183273eb881cfa06da8bc8a9 commit 4051ebd19b3fe7cd183273eb881cfa06da8bc8a9 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Nov 13 18:12:01 2017 Allow WebStateObserver to observe N WebStates [13/N]. Convert TranslateController to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: I62146d7085ab3e230c71cab0510a1ed86aa6a162 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/757109 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#515981} [modify] https://crrev.com/4051ebd19b3fe7cd183273eb881cfa06da8bc8a9/components/translate/ios/browser/translate_controller.h [modify] https://crrev.com/4051ebd19b3fe7cd183273eb881cfa06da8bc8a9/components/translate/ios/browser/translate_controller.mm
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95e3990eb6af420c7890554b6a931b153e36691b commit 95e3990eb6af420c7890554b6a931b153e36691b Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Nov 14 11:03:46 2017 Allow WebStateObserver to observe N WebStates [14/N]. Convert AutofillTabHelper to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If3881f8241ec52fd54499c178eb77580e2404fd6 Reviewed-on: https://chromium-review.googlesource.com/757316 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#516260} [modify] https://crrev.com/95e3990eb6af420c7890554b6a931b153e36691b/ios/chrome/browser/autofill/autofill_tab_helper.mm
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9cc077c60117c3c16fce8d37b04de384200824f commit f9cc077c60117c3c16fce8d37b04de384200824f Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Nov 14 12:28:26 2017 Allow WebStateObserver to observe N WebStates [15/N]. Convert FormInputAccessoryViewTabHelper to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I74892db41e08aae6c9025d4ee7bcdd21246f3ffa Reviewed-on: https://chromium-review.googlesource.com/757336 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#516276} [modify] https://crrev.com/f9cc077c60117c3c16fce8d37b04de384200824f/ios/chrome/browser/autofill/form_input_accessory_view_tab_helper.mm
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/191f3c1566d471a2ba6073b67c282a614daa6533 commit 191f3c1566d471a2ba6073b67c282a614daa6533 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Nov 14 13:30:59 2017 Allow WebStateObserver to observe N WebStates [16/N]. Convert FormSuggestionTabHelper to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib6af771e783285a8efd6b6b640a38b76b4c7caac Reviewed-on: https://chromium-review.googlesource.com/766788 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#516286} [modify] https://crrev.com/191f3c1566d471a2ba6073b67c282a614daa6533/ios/chrome/browser/autofill/form_suggestion_tab_helper.mm
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e67a222ff4f8c09b8eef26d618250187f8a77c67 commit e67a222ff4f8c09b8eef26d618250187f8a77c67 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Nov 14 13:49:42 2017 Allow WebStateObserver to observe N WebStates [17/N]. Convert FindTabHelper to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I69071028a6f8476734d19da1eeaa92e7e9751b6d Reviewed-on: https://chromium-review.googlesource.com/766748 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#516291} [modify] https://crrev.com/e67a222ff4f8c09b8eef26d618250187f8a77c67/ios/chrome/browser/find_in_page/find_tab_helper.mm
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20c44b29e40cc155d9a439ee85fdd8fb8c8923e1 commit 20c44b29e40cc155d9a439ee85fdd8fb8c8923e1 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Nov 14 14:09:28 2017 Allow WebStateObserver to observe N WebStates [18/N]. Convert HistoryTabHelper to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0b3f3b63e599ad2327df155a75549248b8db9b1b Reviewed-on: https://chromium-review.googlesource.com/766749 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#516292} [modify] https://crrev.com/20c44b29e40cc155d9a439ee85fdd8fb8c8923e1/ios/chrome/browser/history/history_tab_helper.h [modify] https://crrev.com/20c44b29e40cc155d9a439ee85fdd8fb8c8923e1/ios/chrome/browser/history/history_tab_helper.mm
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b436fc7b6536ba5f3ef76039340df19ae2683c5a commit b436fc7b6536ba5f3ef76039340df19ae2683c5a Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Nov 14 14:37:12 2017 Allow WebStateObserver to observe N WebStates [19/N]. Convert InfoBarManagerImpl to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Remove unused method InfoBarManagerImpl::WebStateFromInfoBar as it accessed deprecated web_state() method. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I55574e425107a3306bc0ba2085d699d4008c3f44 Reviewed-on: https://chromium-review.googlesource.com/766750 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#516296} [modify] https://crrev.com/b436fc7b6536ba5f3ef76039340df19ae2683c5a/ios/chrome/browser/infobars/infobar_manager_impl.h [modify] https://crrev.com/b436fc7b6536ba5f3ef76039340df19ae2683c5a/ios/chrome/browser/infobars/infobar_manager_impl.mm
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/879e3267685c37dff9abcc921b31ad157bdcc002 commit 879e3267685c37dff9abcc921b31ad157bdcc002 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Nov 14 14:46:43 2017 Allow WebStateObserver to observe N WebStates [20/N]. Convert PasswordTabHelper to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iab720008b6da7df451da230628f3a5c75fb72da0 Reviewed-on: https://chromium-review.googlesource.com/766789 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#516299} [modify] https://crrev.com/879e3267685c37dff9abcc921b31ad157bdcc002/ios/chrome/browser/passwords/password_tab_helper.mm
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02293324e7f177e246fae2a920a58669c53593a7 commit 02293324e7f177e246fae2a920a58669c53593a7 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Nov 14 16:00:11 2017 Allow WebStateObserver to observe N WebStates [21/N]. Convert FaviconWebStateDispatcherTest to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I40a70007d5dfab9c13439daf40bf361145bb830c Reviewed-on: https://chromium-review.googlesource.com/766790 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#516312} [modify] https://crrev.com/02293324e7f177e246fae2a920a58669c53593a7/ios/chrome/browser/reading_list/favicon_web_state_dispatcher_impl_unittest.mm
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e99f912d0a5ea90d5149bd25dff05aad298eb642 commit e99f912d0a5ea90d5149bd25dff05aad298eb642 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Nov 14 16:18:46 2017 Allow WebStateObserver to observe N WebStates [22/N]. Convert ReadingListWebStateObserver to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Remove class ReadingListWebStateObserverUserDataWrapper and instead convert ReadingListWebStateObserver to be a WebStateUserData. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I726919cf9c29b7040a907f01c95f462595e30192 Reviewed-on: https://chromium-review.googlesource.com/766751 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#516319} [modify] https://crrev.com/e99f912d0a5ea90d5149bd25dff05aad298eb642/ios/chrome/browser/reading_list/reading_list_web_state_observer.h [modify] https://crrev.com/e99f912d0a5ea90d5149bd25dff05aad298eb642/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm [modify] https://crrev.com/e99f912d0a5ea90d5149bd25dff05aad298eb642/ios/chrome/browser/reading_list/reading_list_web_state_observer_unittest.mm [modify] https://crrev.com/e99f912d0a5ea90d5149bd25dff05aad298eb642/ios/chrome/browser/tabs/tab_helper_util.mm
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b9f4d8120bb85c926b6e8ebe557633b2e66e3c2 commit 9b9f4d8120bb85c926b6e8ebe557633b2e66e3c2 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Nov 15 12:49:42 2017 Fix crash in WebFaviconDriver::OnFaviconDeleted. Followup to https://chromium-review.googlesource.com/758863 that forgot to fix one use of web_state(). This fix a crash in WebFaviconDriver::OnFaviconDeleted. Bug: 775684 Change-Id: I08910c647de2595606644136b5ab080e0e9e7300 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/771651 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#516674} [modify] https://crrev.com/9b9f4d8120bb85c926b6e8ebe557633b2e66e3c2/components/favicon/ios/web_favicon_driver.mm
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90acbdae6d5bd7e385b9fa6c7f172174b4f5d319 commit 90acbdae6d5bd7e385b9fa6c7f172174b4f5d319 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Nov 15 16:17:26 2017 Allow WebStateObserver to observe N WebStates [23/N]. Convert InsecureInputTabHelper to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9d09bafb9da0813a6da3a4e5c32186dd327c7de6 Reviewed-on: https://chromium-review.googlesource.com/768412 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#516713} [modify] https://crrev.com/90acbdae6d5bd7e385b9fa6c7f172174b4f5d319/ios/chrome/browser/ssl/insecure_input_tab_helper.h [modify] https://crrev.com/90acbdae6d5bd7e385b9fa6c7f172174b4f5d319/ios/chrome/browser/ssl/insecure_input_tab_helper.mm
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5acdca09f3f3a0d2a7f985cb51ab8c739e96d289 commit 5acdca09f3f3a0d2a7f985cb51ab8c739e96d289 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Nov 15 17:35:50 2017 Allow WebStateObserver to observe N WebStates [24/N]. Convert ChromeIOSTranslateClient to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: I0884cbe0234a4a7c81f710a64e2dc644765c46a7 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768739 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#516736} [modify] https://crrev.com/5acdca09f3f3a0d2a7f985cb51ab8c739e96d289/ios/chrome/browser/translate/chrome_ios_translate_client.h [modify] https://crrev.com/5acdca09f3f3a0d2a7f985cb51ab8c739e96d289/ios/chrome/browser/translate/chrome_ios_translate_client.mm
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0dbd8f42ec26bc58cb9c7f97083f83788d327938 commit 0dbd8f42ec26bc58cb9c7f97083f83788d327938 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Nov 15 18:38:45 2017 Allow WebStateObserver to observe N WebStates [25/N]. Convert ContextualSearchController to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Remove ContextualSearchWebStateObserver and delegate as they are a subset of CRWWebStateObserver (since the method webState:navigatedWithDetails: is never implemented, thus the loaded_ member variable isn't used). Bug: 775684 Change-Id: If8d2714bf30ad69f1c50860dc0108edc83630f6f Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768807 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#516760} [modify] https://crrev.com/0dbd8f42ec26bc58cb9c7f97083f83788d327938/ios/chrome/browser/ui/contextual_search/BUILD.gn [modify] https://crrev.com/0dbd8f42ec26bc58cb9c7f97083f83788d327938/ios/chrome/browser/ui/contextual_search/contextual_search_controller.mm [delete] https://crrev.com/5e0ed4ebbda40ed2f678bb6ed36c05065bee7aa9/ios/chrome/browser/ui/contextual_search/contextual_search_web_state_observer.h [delete] https://crrev.com/5e0ed4ebbda40ed2f678bb6ed36c05065bee7aa9/ios/chrome/browser/ui/contextual_search/contextual_search_web_state_observer.mm
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e110ef5939f209aa91f56a6acc1505d51c5e7c1f commit e110ef5939f209aa91f56a6acc1505d51c5e7c1f Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Nov 16 10:29:57 2017 Allow WebStateObserver to observe N WebStates [26/N]. Convert JavaScriptDialogBlockingState to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: I5add60c72e6046400c2dc1c4a609e9f443ecb782 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768420 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517049} [modify] https://crrev.com/e110ef5939f209aa91f56a6acc1505d51c5e7c1f/ios/chrome/browser/ui/dialogs/java_script_dialog_blocking_state.h [modify] https://crrev.com/e110ef5939f209aa91f56a6acc1505d51c5e7c1f/ios/chrome/browser/ui/dialogs/java_script_dialog_blocking_state.mm
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd5153ebc7955950164a99222971ee8a37b7de8c commit dd5153ebc7955950164a99222971ee8a37b7de8c Author: Olivier Robin <olivierrobin@chromium.org> Date: Thu Nov 16 10:53:50 2017 Detach web_state from DistillerPageiOS before destructing. Follow up of https://chromium-review.googlesource.com/c/chromium/src/+/744012 Bug: 785673, 775684 Change-Id: I85e06ac43db3098ed4d297ea6ad9c242dd8ecae2 Reviewed-on: https://chromium-review.googlesource.com/774261 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517054} [modify] https://crrev.com/dd5153ebc7955950164a99222971ee8a37b7de8c/components/dom_distiller/ios/distiller_page_ios.mm
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b3bb45c1e69ac76b1f6e978b89082067315185c commit 0b3bb45c1e69ac76b1f6e978b89082067315185c Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Nov 16 10:58:43 2017 Allow WebStateObserver to observe N WebStates [27/N]. Convert TextToSpeechListener to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Remove TextToSpeechWebStateObserver and convert the TextToSpeechListener to implement CRWWebStateObserver. Bug: 775684 Change-Id: I40592a8cd9e5819168e1a65b9b0738b54d429b38 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768715 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517055} [modify] https://crrev.com/0b3bb45c1e69ac76b1f6e978b89082067315185c/ios/chrome/browser/voice/text_to_speech_listener.mm
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0872687b07bb9d41f917985dc94873b0953ec58 commit f0872687b07bb9d41f917985dc94873b0953ec58 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Nov 16 12:12:27 2017 Allow WebStateObserver to observe N WebStates [28/N]. Convert VoiceSearchNavigationTabHelper to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: I0ab524c26da8afb97753788fa36db0f5df603430 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768743 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517062} [modify] https://crrev.com/f0872687b07bb9d41f917985dc94873b0953ec58/ios/chrome/browser/voice/voice_search_navigations_tab_helper.h [modify] https://crrev.com/f0872687b07bb9d41f917985dc94873b0953ec58/ios/chrome/browser/voice/voice_search_navigations_tab_helper.mm
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3fcec660582cf6c588fde5fd5d3cf932b280606d commit 3fcec660582cf6c588fde5fd5d3cf932b280606d Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Nov 16 13:34:05 2017 Allow WebStateObserver to observe N WebStates [29/N]. Convert LoadTimingTabHelper to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: I606bc4b62a5d10f695cee9f44b723feb9111ab9c Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768717 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517074} [modify] https://crrev.com/3fcec660582cf6c588fde5fd5d3cf932b280606d/ios/chrome/browser/web/load_timing_tab_helper.h [modify] https://crrev.com/3fcec660582cf6c588fde5fd5d3cf932b280606d/ios/chrome/browser/web/load_timing_tab_helper.mm
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0bc755f52a97663ed08f506115c27ca2121b743 commit c0bc755f52a97663ed08f506115c27ca2121b743 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Nov 16 15:31:08 2017 Allow WebStateObserver to observe N WebStates [30/N]. Convert NetworkActivityIndicatorTabHelper to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: I2cfd62b17f2b9bbfae39cb0bcfddd48e9cbf2603 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768746 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517087} [modify] https://crrev.com/c0bc755f52a97663ed08f506115c27ca2121b743/ios/chrome/browser/web/network_activity_indicator_tab_helper.h [modify] https://crrev.com/c0bc755f52a97663ed08f506115c27ca2121b743/ios/chrome/browser/web/network_activity_indicator_tab_helper.mm
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2e7dbf0f4c526e85c9bcdd01c1454cf7e769dfc commit a2e7dbf0f4c526e85c9bcdd01c1454cf7e769dfc Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Nov 16 16:57:37 2017 Allow WebStateObserver to observe N WebStates [31/N]. Convert PagePlaceholderTabHelper to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: I9784be30ecab75126349d401bfe75bc3114dd703 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768815 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517108} [modify] https://crrev.com/a2e7dbf0f4c526e85c9bcdd01c1454cf7e769dfc/ios/chrome/browser/web/page_placeholder_tab_helper.mm
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db8d91790c66e2807bb6fce3d42d725bf4a0d6f0 commit db8d91790c66e2807bb6fce3d42d725bf4a0d6f0 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Nov 16 18:25:09 2017 Allow WebStateObserver to observe N WebStates [32/N]. Convert PrintTabHelper to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: I2788f302863f7f23bf35fab7a98a75ced00b17f1 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768719 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517130} [modify] https://crrev.com/db8d91790c66e2807bb6fce3d42d725bf4a0d6f0/ios/chrome/browser/web/print_tab_helper.h [modify] https://crrev.com/db8d91790c66e2807bb6fce3d42d725bf4a0d6f0/ios/chrome/browser/web/print_tab_helper.mm
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3c69812ec9a6c7c3a2204f0e696c9325c9997e1 commit e3c69812ec9a6c7c3a2204f0e696c9325c9997e1 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Nov 17 11:16:32 2017 Allow WebStateObserver to observe N WebStates [33/N]. Convert RepostFormTabHelper to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Pass the WebState to the delegate instead of using the deprecated web_state() method. Bug: 775684 Change-Id: Ia8abfc6e8222adc47c7b90cb240bb1906683618e Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768723 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517377} [modify] https://crrev.com/e3c69812ec9a6c7c3a2204f0e696c9325c9997e1/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/e3c69812ec9a6c7c3a2204f0e696c9325c9997e1/ios/chrome/browser/web/repost_form_tab_helper.h [modify] https://crrev.com/e3c69812ec9a6c7c3a2204f0e696c9325c9997e1/ios/chrome/browser/web/repost_form_tab_helper.mm [modify] https://crrev.com/e3c69812ec9a6c7c3a2204f0e696c9325c9997e1/ios/chrome/browser/web/repost_form_tab_helper_delegate.h [modify] https://crrev.com/e3c69812ec9a6c7c3a2204f0e696c9325c9997e1/ios/chrome/browser/web/repost_form_tab_helper_unittest.mm
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9626a0a76fc2d075574a20e941a394ab5c8bb802 commit 9626a0a76fc2d075574a20e941a394ab5c8bb802 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Nov 20 10:54:13 2017 Allow WebStateObserver to observe N WebStates [34/N]. Convert SadTabTabHelper to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Pass the WebState to SadTabTabHelperTestDelegate to fix the unit test (as WebStateObserver method web_state always return nullptr). Bug: 775684 Change-Id: I7908650e3612645eddf03eb7ea01f88dfba4d395 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768724 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517791} [modify] https://crrev.com/9626a0a76fc2d075574a20e941a394ab5c8bb802/ios/chrome/browser/ui/sad_tab/sad_tab_legacy_coordinator.mm [modify] https://crrev.com/9626a0a76fc2d075574a20e941a394ab5c8bb802/ios/chrome/browser/web/sad_tab_tab_helper.h [modify] https://crrev.com/9626a0a76fc2d075574a20e941a394ab5c8bb802/ios/chrome/browser/web/sad_tab_tab_helper.mm [modify] https://crrev.com/9626a0a76fc2d075574a20e941a394ab5c8bb802/ios/chrome/browser/web/sad_tab_tab_helper_delegate.h [modify] https://crrev.com/9626a0a76fc2d075574a20e941a394ab5c8bb802/ios/chrome/browser/web/sad_tab_tab_helper_unittest.mm
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef11aff0688d84898e71c7d6021f0e51109d416e commit ef11aff0688d84898e71c7d6021f0e51109d416e Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Nov 20 11:10:25 2017 Allow WebStateObserver to observe N WebStates [35/N]. Convert WebViewTranslateClient to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: Ifdf8f2ba5e113f67269d4329500d1693e772eeae Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768877 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517793} [modify] https://crrev.com/ef11aff0688d84898e71c7d6021f0e51109d416e/ios/web_view/internal/translate/web_view_translate_client.mm
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f41c7c3273b4eb09dcaa617f722bbbda977bc16e commit f41c7c3273b4eb09dcaa617f722bbbda977bc16e Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Nov 20 11:20:40 2017 Allow WebStateObserver to observe N WebStates [36/N]. Convert WebIntTest to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Also convert IntTestWebStateObserver from a member variable to a local variable since its lifetime is bound to the method call. Bug: 775684 Change-Id: I098d007c8ad3a4b211c9683aa63e90e343b5f53c Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/769011 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517796} [modify] https://crrev.com/f41c7c3273b4eb09dcaa617f722bbbda977bc16e/ios/web/test/web_int_test.h [modify] https://crrev.com/f41c7c3273b4eb09dcaa617f722bbbda977bc16e/ios/web/test/web_int_test.mm
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5a4502ebd667e8a00ce9f393edb3efddacb1e5b commit c5a4502ebd667e8a00ce9f393edb3efddacb1e5b Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Nov 20 12:59:25 2017 Allow WebStateObserver to observe N WebStates [37/N]. Convert FaviconCallbackTest to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: Icafd83b54dfb598ec6cbe22ddb2f0c35d926b945 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768692 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517808} [modify] https://crrev.com/c5a4502ebd667e8a00ce9f393edb3efddacb1e5b/ios/web/web_state/favicon_callbacks_inttest.mm
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99d94b1f5c2d9800113ead3b9baaea2f7e811cee commit 99d94b1f5c2d9800113ead3b9baaea2f7e811cee Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Nov 20 13:12:11 2017 Allow WebStateObserver to observe N WebStates [38/N]. Convert BrowserListSessionServiceWebStateListObserver to observe the active WebState directly and remove dependency on deprecated methods of WebStateObserver. Bug: 775684 Change-Id: I5c6a4478515c657d077180b6de263ac531930d4d Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/771671 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517811} [modify] https://crrev.com/99d94b1f5c2d9800113ead3b9baaea2f7e811cee/ios/chrome/browser/ui/browser_list/browser_list_session_service_impl.mm
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e296c1edc9bb04b504ad48f0ea5b7cb797b00984 commit e296c1edc9bb04b504ad48f0ea5b7cb797b00984 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Nov 20 14:05:58 2017 Allow WebStateObserver to observe N WebStates [39/N]. Convert TestRedirectObserver to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Also remove TestRedirectObserverUserDataWrapper by using WebStateUserData. Bug: 775684 Change-Id: I85e965e8c99dd5dd848082c305619aaff5b6a5ca Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/771690 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517815} [modify] https://crrev.com/e296c1edc9bb04b504ad48f0ea5b7cb797b00984/ios/web/public/test/test_redirect_observer.h [modify] https://crrev.com/e296c1edc9bb04b504ad48f0ea5b7cb797b00984/ios/web/public/test/test_redirect_observer.mm
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b275afe684a4ddf20c8b11ba80668b1bb29195ae commit b275afe684a4ddf20c8b11ba80668b1bb29195ae Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Nov 20 14:53:15 2017 Allow WebStateObserver to observe N WebStates [40/N]. Remove deprecated code from WebStateObserver. It no longer track the observed WebState and it is the responsibility of the client code to call AddObserver/RemoveObserver on the WebStates. Bug: 775684 Change-Id: I380212c35e8165fc69b3c0252f78e4a925632024 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/771712 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517820} [modify] https://crrev.com/b275afe684a4ddf20c8b11ba80668b1bb29195ae/ios/web/public/test/fakes/test_web_state.mm [modify] https://crrev.com/b275afe684a4ddf20c8b11ba80668b1bb29195ae/ios/web/public/web_state/web_state_observer.h [modify] https://crrev.com/b275afe684a4ddf20c8b11ba80668b1bb29195ae/ios/web/web_state/web_state_impl.mm [modify] https://crrev.com/b275afe684a4ddf20c8b11ba80668b1bb29195ae/ios/web/web_state/web_state_observer.mm
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe745faf6961210246f7867bf7800e8449a797b9 commit fe745faf6961210246f7867bf7800e8449a797b9 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Nov 21 10:07:17 2017 Allow WebStateObserver to observe N WebStates [41/N]. Convert FindInPageController to directly track registration with the observed WebState instead of relying on deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: Ife3b032247c8e5e7347e2697ae4ce1471eda410c Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/778845 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#518202} [modify] https://crrev.com/fe745faf6961210246f7867bf7800e8449a797b9/ios/chrome/browser/find_in_page/find_in_page_controller.mm
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f14470c6eac37b2c1602c4e231bd894f0b05eddc commit f14470c6eac37b2c1602c4e231bd894f0b05eddc Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Nov 21 17:11:56 2017 Allow WebStateObserver to observe N WebStates [42/N]. Convert FormInputAccessoryViewController to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: Ic880d84c8e0ede5ec1abe06336a47eeee36e05f7 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/778980 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#518284} [modify] https://crrev.com/f14470c6eac37b2c1602c4e231bd894f0b05eddc/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4aed90b2d7001850d3b3a3bea8e17589cf9b3339 commit 4aed90b2d7001850d3b3a3bea8e17589cf9b3339 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Nov 21 18:17:12 2017 Allow WebStateObserver to observe N WebStates [43/N]. Convert PasswordController to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: I227193a0a4040cff7a823c4e5926a3cad78650e6 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/778900 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#518308} [modify] https://crrev.com/4aed90b2d7001850d3b3a3bea8e17589cf9b3339/ios/chrome/browser/passwords/password_controller.mm
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/877b8bc29688b49e143a5490baaa3a7ffc7ad66f commit 877b8bc29688b49e143a5490baaa3a7ffc7ad66f Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Nov 22 09:09:12 2017 Allow WebStateObserver to observe N WebStates [44/N]. Convert ITunesLinksObserver to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: Ia88fe44a99ed762d46894de95e18f8ebde18dd79 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/778999 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#518578} [modify] https://crrev.com/877b8bc29688b49e143a5490baaa3a7ffc7ad66f/ios/chrome/browser/itunes_links/itunes_links_observer.mm
,
Nov 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a43850dba6cff52deffcaae42dbc16e740c7985 commit 0a43850dba6cff52deffcaae42dbc16e740c7985 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Nov 23 10:59:45 2017 Allow WebStateObserver to observe N WebStates [45/N]. Convert FormSuggestionController to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: I9b4feae405dd42697ffbaf8048e370b4bb2f537e Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/778165 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#518886} [modify] https://crrev.com/0a43850dba6cff52deffcaae42dbc16e740c7985/ios/chrome/browser/autofill/form_suggestion_controller.mm
,
Nov 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fe51b9f0b1c11ee10aca61f5af800a53ad45bf3 commit 9fe51b9f0b1c11ee10aca61f5af800a53ad45bf3 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Nov 23 11:41:34 2017 Allow WebStateObserver to observe N WebStates [46/N]. Convert ToolbarMediator to directly track the registration with the observed WebState instead of relying on deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: Ic53f5cf71496a4c1e52849c3212567b6ff934267 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/778901 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#518892} [modify] https://crrev.com/9fe51b9f0b1c11ee10aca61f5af800a53ad45bf3/ios/chrome/browser/ui/toolbar/clean/toolbar_mediator.mm
,
Nov 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/588a5825421e715b6047e3b30a903d22252a06dd commit 588a5825421e715b6047e3b30a903d22252a06dd Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Nov 23 12:43:08 2017 Allow WebStateObserver to observe N WebStates [47/N]. Convert CRWWebUIManager to directly track the registration with the observed WebState instead of relying on deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: I7b6208672cb7340cd3f96ba3e127401f41f30771 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/778885 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#518908} [modify] https://crrev.com/588a5825421e715b6047e3b30a903d22252a06dd/ios/web/webui/crw_web_ui_manager.mm
,
Nov 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de9c794dc70d5ea23a21a4489ac39c5c4b6ad0de commit de9c794dc70d5ea23a21a4489ac39c5c4b6ad0de Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Nov 23 15:30:00 2017 Allow WebStateObserver to observe N WebStates [48/N]. Convert AutofillAgent to directly track the registration with the observed WebState instead of relying on deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: I2ce63705ba687149ca8d9f9228f667c305d5c52c Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/778542 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#518944} [modify] https://crrev.com/de9c794dc70d5ea23a21a4489ac39c5c4b6ad0de/components/autofill/ios/browser/autofill_agent.mm
,
Nov 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05e93091bc4eb45c509a25a64b8b2949c1896416 commit 05e93091bc4eb45c509a25a64b8b2949c1896416 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Nov 23 17:51:16 2017 Allow WebStateObserver to observe N WebStates [49/N]. Convert ViewController to directly track the registration with the observed WebState instead of relying on deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: I9c3a110f6eb15321d60cc7a6de34e9ca30bcefe2 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/778820 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#518975} [modify] https://crrev.com/05e93091bc4eb45c509a25a64b8b2949c1896416/ios/web/shell/view_controller.mm
,
Nov 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/652dd80509de5a093fdd1fc55108ca8dd0f8df19 commit 652dd80509de5a093fdd1fc55108ca8dd0f8df19 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Nov 24 11:34:49 2017 Allow WebStateObserver to observe N WebStates [50/N]. Convert SideSwipeController to directly track the registration with the observed WebState instead of relying on deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: I5156b732b08b5e1e2f9010acc9b09e383fde13c9 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/778543 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#519086} [modify] https://crrev.com/652dd80509de5a093fdd1fc55108ca8dd0f8df19/ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm
,
Nov 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2a21f5b5cd39cb4686249b3859fa897d756ceba commit a2a21f5b5cd39cb4686249b3859fa897d756ceba Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Nov 24 13:41:03 2017 Allow WebStateObserver to observe N WebStates [51/N]. Convert NTPHomeMediator to directly track the registration with the observed WebState instead of relying on deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: I71f07ab233631fe754f8f384f5afefa3fa49d42a Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/779002 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#519099} [modify] https://crrev.com/a2a21f5b5cd39cb4686249b3859fa897d756ceba/ios/chrome/browser/content_suggestions/ntp_home_mediator.mm
,
Nov 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b1b2fa2f70e6f30ea7f5eb8a19fb194311ad2da commit 3b1b2fa2f70e6f30ea7f5eb8a19fb194311ad2da Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Nov 24 14:41:25 2017 Allow WebStateObserver to observe N WebStates [52/N]. Convert Tab to directly track the registration with the observed WebState instead of relying on deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: I1c9deb1c00b3542b144e992e9d13ac98185fd1e6 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/778821 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#519110} [modify] https://crrev.com/3b1b2fa2f70e6f30ea7f5eb8a19fb194311ad2da/ios/chrome/browser/tabs/tab.mm
,
Nov 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eea8890347206ee13f2855d1e77cc250e5726c89 commit eea8890347206ee13f2855d1e77cc250e5726c89 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Nov 24 15:31:26 2017 Allow WebStateObserver to observe N WebStates [53/N]. Convert PaymentRequestManager to directly track the registration with the observed WebState instead of relying on deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: I2dad708fd3ea3eec123d643b6066df462c4857f7 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/778822 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#519117} [modify] https://crrev.com/eea8890347206ee13f2855d1e77cc250e5726c89/ios/chrome/browser/ui/payments/payment_request_manager.mm
,
Nov 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec2216ae09e309b874ec698a2beb427395f4073b commit ec2216ae09e309b874ec698a2beb427395f4073b Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Nov 24 15:41:40 2017 Allow WebStateObserver to observe N WebStates [54/N]. Convert WebStateObserverBridgeTest to directly track the registration with the observed WebState instead of relying on deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: Ic6580f7eee66dd36e9b685a090f54c1d5fac3beb Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/778886 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#519121} [modify] https://crrev.com/ec2216ae09e309b874ec698a2beb427395f4073b/ios/web/web_state/web_state_observer_bridge_unittest.mm
,
Nov 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33cd2fbf37fbdd15cdb3af548925d004da1cadb1 commit 33cd2fbf37fbdd15cdb3af548925d004da1cadb1 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Nov 24 16:00:10 2017 Allow WebStateObserver to observe N WebStates [55/N]. Convert CWVWebView to directly track the registration with the observed WebState instead of relying on deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: If91d93d7728c2af8921c23ba07ac4c7c8f9a86c0 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/779003 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#519124} [modify] https://crrev.com/33cd2fbf37fbdd15cdb3af548925d004da1cadb1/ios/web_view/internal/cwv_web_view.mm
,
Dec 4 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/90cc3c9ec24e171a16c012c08de0b4df0dd3da6d commit 90cc3c9ec24e171a16c012c08de0b4df0dd3da6d Author: Sylvain Defresne <sdefresne@google.com> Date: Mon Dec 04 09:05:02 2017
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3a93cfd21d907ce5b766dec83eb6008976c4e18 commit f3a93cfd21d907ce5b766dec83eb6008976c4e18 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Dec 04 10:41:58 2017 Allow WebStateObserver to observe N WebStates [57/N]. Convert CWVAutofillController to directly track the registration with the observed WebState instead of relying on deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: I2efecc5c102271721fa4b47d4bc50a6bd63568f5 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/789077 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#521306} [modify] https://crrev.com/f3a93cfd21d907ce5b766dec83eb6008976c4e18/ios/web_view/internal/autofill/cwv_autofill_controller.mm
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/345379834d2b99dfd3885657f7c1b2edc56b69ca commit 345379834d2b99dfd3885657f7c1b2edc56b69ca Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Dec 04 11:39:24 2017 Allow WebStateObserver to observe N WebStates [58/58]. Remove deprecated methods from WebStateObserverBridge as they are now unused. Bug: 775684 Change-Id: I7c6cf9ef3dff9fa2e88851c9eecdd2242e5f6286 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/779004 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#521316} [modify] https://crrev.com/345379834d2b99dfd3885657f7c1b2edc56b69ca/ios/web/public/web_state/web_state_observer_bridge.h [modify] https://crrev.com/345379834d2b99dfd3885657f7c1b2edc56b69ca/ios/web/web_state/web_state_observer_bridge.mm
,
Dec 4 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by eugene...@chromium.org
, Oct 17 2017Labels: -Type-Bug Type-Task