Cros SplitView - Crash when trying to open unsnappable window with one snapped. |
||||
Issue description(1) Open a couple windows, at least one unsnappable window. (2) Enter overview. (3) Snap a window left (or right). (4) Click the unsnappable window overview window. What is the expected result? Exit splitview and activate unsnappable window (android does this) What happens instead? crash
,
Oct 18 2017
Yep, expected behavior is like Android. I believe it should also give a toast that it does not support split screen, right Ben?
,
Oct 18 2017
re #2 Yes, the toast is in the other bug.
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e01fbc91326fc13322d4aa5d94b1c74a1f8eae6 commit 6e01fbc91326fc13322d4aa5d94b1c74a1f8eae6 Author: Sammie Quon <sammiequon@google.com> Date: Thu Oct 19 19:15:53 2017 splitview: Fix crash when trying to open an unsnappable window in splitv. Behaviour matches android now. Test: ash_unittests SplitViewWindowSelectorTest.SelectUnsnappableWindowInSplitView Bug: 775682 Change-Id: I9e3a6c321ea2c871b1cc7d438f8b70228030a2a1 Reviewed-on: https://chromium-review.googlesource.com/724212 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#510154} [modify] https://crrev.com/6e01fbc91326fc13322d4aa5d94b1c74a1f8eae6/ash/wm/overview/overview_window_drag_controller.cc [modify] https://crrev.com/6e01fbc91326fc13322d4aa5d94b1c74a1f8eae6/ash/wm/overview/window_selector.h [modify] https://crrev.com/6e01fbc91326fc13322d4aa5d94b1c74a1f8eae6/ash/wm/overview/window_selector_unittest.cc
,
Oct 19 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sammiequon@chromium.org
, Oct 17 2017