As part of the effort to deprecate UtilityProcessMojoClient, PaymentManifestParser should be changed to use SafeJSONParser. At that point it does not need to be mojofied anymore and can be simplified a bit.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49f808f31020a684d59f2fcc76e120aa5847126d commit 49f808f31020a684d59f2fcc76e120aa5847126d Author: Jay Civelli <jcivelli@google.com> Date: Mon Oct 23 22:13:24 2017 Changing payment manifest parsing to use the SafeJsonParser. As part of the effort to move process launching to the service manager, changing payment manifest parsing to use SafeJsonParser instead of using UtilityProcessMojoClient. The JSON parsing of the manifest, which is the sensitive operation, is now the only operation done "safely". On Android it also means that parsing is done in the browser process in Java. That makes the previous behavior of starting the utility process in advance unneeded as utility process start-up is relatively fast on non Android platforms. PaymentManifestParser does not have to be exposed as a Mojo interface anymore since parsing happens in the browser process on the parsed JSON data. PaymentManifestParserHost is merged into PaymentManifestParser. ParsePaymentManifestParser now stores the client callbacks in the bound callbacks it provides to SafeJsonParser. This removes the need for bookkeeping the client calllbacks in ParsePaymentManifestParser. Some tests have been removed that were not relevant anymore with these changes, mostly that dealt with spurious messages sent from the utility process (which can't happen anymore with the OnceCallbacks provided to SafeJsonParser) and with starting the utility process in advance. Bug: 775679 Tbr: sky@chromium.com Change-Id: I121eee0705c940574b7b9f2aeeb0fef89b5e9a2c Reviewed-on: https://chromium-review.googlesource.com/724169 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#510937} [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/chrome/android/BUILD.gn [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentManifestVerifier.java [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentManifestWebDataService.java [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentManifestParserTest.java [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/chrome/android/junit/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinderTest.java [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/chrome/android/junit/src/org/chromium/chrome/browser/payments/PaymentManifestVerifierTest.java [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/chrome/browser/android/payments/service_worker_payment_app_bridge.cc [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/chrome/browser/payments/android/payment_manifest_web_data_service_android.cc [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/chrome/browser/payments/android/payment_manifest_web_data_service_android.h [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/chrome/browser/payments/manifest_verifier_browsertest.cc [add] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/chrome/browser/payments/payment_manifest_parser_browsertest.cc [delete] https://crrev.com/d2a713e4264a275054b53b35397585355474d455/chrome/browser/payments/payment_manifest_parser_host_browsertest.cc [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/chrome/test/BUILD.gn [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/chrome/utility/BUILD.gn [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/chrome/utility/chrome_content_utility_client.cc [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/BUILD.gn [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/DEPS [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/android/BUILD.gn [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/android/java/src/org/chromium/components/payments/PaymentManifestParser.java [add] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/android/java/src/org/chromium/components/payments/WebAppManifestSection.java [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/android/payment_manifest_parser_android.cc [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/android/payment_manifest_parser_android.h [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/manifest_verifier.cc [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/manifest_verifier.h [delete] https://crrev.com/d2a713e4264a275054b53b35397585355474d455/components/payments/content/payment_manifest_parser_host.cc [delete] https://crrev.com/d2a713e4264a275054b53b35397585355474d455/components/payments/content/payment_manifest_parser_host.h [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/payment_manifest_web_data_service.cc [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/payment_manifest_web_data_service.h [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/payment_request_state.cc [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/utility/BUILD.gn [add] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/utility/OWNERS [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/utility/payment_manifest_parser.cc [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/utility/payment_manifest_parser.h [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/utility/payment_manifest_parser_unittest.cc [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/utility/payment_method_manifest_parser_fuzzer.cc [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/utility/payment_web_app_manifest_parser_fuzzer.cc [add] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/web_app_manifest_section.cc [add] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/web_app_manifest_section.h [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/web_app_manifest_section_table.cc [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/web_app_manifest_section_table.h [modify] https://crrev.com/49f808f31020a684d59f2fcc76e120aa5847126d/components/payments/content/web_app_manifest_section_table_unittest.cc [delete] https://crrev.com/d2a713e4264a275054b53b35397585355474d455/components/payments/mojom/BUILD.gn [delete] https://crrev.com/d2a713e4264a275054b53b35397585355474d455/components/payments/mojom/OWNERS [delete] https://crrev.com/d2a713e4264a275054b53b35397585355474d455/components/payments/mojom/payment_manifest_parser.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa0190573142a5380c2e780c65a0fad2f3d5f129 commit aa0190573142a5380c2e780c65a0fad2f3d5f129 Author: Min Qin <qinmin@chromium.org> Date: Tue Oct 24 00:43:25 2017 Revert "Changing payment manifest parsing to use the SafeJsonParser." This reverts commit 49f808f31020a684d59f2fcc76e120aa5847126d. Reason for revert: Breaks Mojo-linux bot Original change's description: > Changing payment manifest parsing to use the SafeJsonParser. > > As part of the effort to move process launching to the service manager, > changing payment manifest parsing to use SafeJsonParser instead of > using UtilityProcessMojoClient. > > The JSON parsing of the manifest, which is the sensitive operation, is > now the only operation done "safely". On Android it also means that > parsing is done in the browser process in Java. That makes the previous > behavior of starting the utility process in advance unneeded as utility > process start-up is relatively fast on non Android platforms. > > PaymentManifestParser does not have to be exposed as a Mojo interface > anymore since parsing happens in the browser process on the parsed JSON > data. PaymentManifestParserHost is merged into PaymentManifestParser. > > ParsePaymentManifestParser now stores the client callbacks in the bound > callbacks it provides to SafeJsonParser. This removes the need for > bookkeeping the client calllbacks in ParsePaymentManifestParser. > > Some tests have been removed that were not relevant anymore with these > changes, mostly that dealt with spurious messages sent from the utility > process (which can't happen anymore with the OnceCallbacks provided to > SafeJsonParser) and with starting the utility process in advance. > > Bug: 775679 > Tbr: sky@chromium.com > Change-Id: I121eee0705c940574b7b9f2aeeb0fef89b5e9a2c > Reviewed-on: https://chromium-review.googlesource.com/724169 > Commit-Queue: Jay Civelli <jcivelli@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#510937} TBR=sky@chromium.org,palmer@chromium.org,rouslan@chromium.org,jcivelli@chromium.org Change-Id: I195cb3bb8b6432f6f25cb5d4b39939a1575f0e45 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775679 Reviewed-on: https://chromium-review.googlesource.com/733741 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#510969} [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/chrome/android/BUILD.gn [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentManifestVerifier.java [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentManifestWebDataService.java [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentManifestParserTest.java [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/chrome/android/junit/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinderTest.java [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/chrome/android/junit/src/org/chromium/chrome/browser/payments/PaymentManifestVerifierTest.java [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/chrome/browser/android/payments/service_worker_payment_app_bridge.cc [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/chrome/browser/payments/android/payment_manifest_web_data_service_android.cc [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/chrome/browser/payments/android/payment_manifest_web_data_service_android.h [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/chrome/browser/payments/manifest_verifier_browsertest.cc [delete] https://crrev.com/37cf0cb3af472677441e6b41071686bb9f1fbe0d/chrome/browser/payments/payment_manifest_parser_browsertest.cc [add] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/chrome/browser/payments/payment_manifest_parser_host_browsertest.cc [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/chrome/test/BUILD.gn [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/chrome/utility/BUILD.gn [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/chrome/utility/chrome_content_utility_client.cc [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/BUILD.gn [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/DEPS [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/android/BUILD.gn [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/android/java/src/org/chromium/components/payments/PaymentManifestParser.java [delete] https://crrev.com/37cf0cb3af472677441e6b41071686bb9f1fbe0d/components/payments/content/android/java/src/org/chromium/components/payments/WebAppManifestSection.java [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/android/payment_manifest_parser_android.cc [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/android/payment_manifest_parser_android.h [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/manifest_verifier.cc [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/manifest_verifier.h [add] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/payment_manifest_parser_host.cc [add] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/payment_manifest_parser_host.h [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/payment_manifest_web_data_service.cc [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/payment_manifest_web_data_service.h [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/payment_request_state.cc [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/utility/BUILD.gn [delete] https://crrev.com/37cf0cb3af472677441e6b41071686bb9f1fbe0d/components/payments/content/utility/OWNERS [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/utility/payment_manifest_parser.cc [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/utility/payment_manifest_parser.h [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/utility/payment_manifest_parser_unittest.cc [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/utility/payment_method_manifest_parser_fuzzer.cc [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/utility/payment_web_app_manifest_parser_fuzzer.cc [delete] https://crrev.com/37cf0cb3af472677441e6b41071686bb9f1fbe0d/components/payments/content/web_app_manifest_section.cc [delete] https://crrev.com/37cf0cb3af472677441e6b41071686bb9f1fbe0d/components/payments/content/web_app_manifest_section.h [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/web_app_manifest_section_table.cc [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/web_app_manifest_section_table.h [modify] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/content/web_app_manifest_section_table_unittest.cc [add] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/mojom/BUILD.gn [add] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/mojom/OWNERS [add] https://crrev.com/aa0190573142a5380c2e780c65a0fad2f3d5f129/components/payments/mojom/payment_manifest_parser.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7d22b487ea75a9cc9a6d570d048faa88722470b commit a7d22b487ea75a9cc9a6d570d048faa88722470b Author: Jay Civelli <jcivelli@google.com> Date: Tue Oct 24 18:38:07 2017 Relanding "Changing payment manifest parsing to use the SafeJsonParser" The initial CL broke the mojo linux bot which is a FYI bot and will be fixed independently. This reverts commit aa0190573142a5380c2e780c65a0fad2f3d5f129. Bug: 775679 Tbr: rouslan@chromium.org, palmer@chromium.org, sky@chromium.org Change-Id: Iefc5ebba6043d181c8b1410215c84af341f35871 Reviewed-on: https://chromium-review.googlesource.com/735119 Reviewed-by: Jay Civelli <jcivelli@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#511215} [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/chrome/android/BUILD.gn [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentManifestVerifier.java [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentManifestWebDataService.java [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentManifestParserTest.java [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/chrome/android/junit/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinderTest.java [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/chrome/android/junit/src/org/chromium/chrome/browser/payments/PaymentManifestVerifierTest.java [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/chrome/browser/android/payments/service_worker_payment_app_bridge.cc [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/chrome/browser/payments/android/payment_manifest_web_data_service_android.cc [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/chrome/browser/payments/android/payment_manifest_web_data_service_android.h [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/chrome/browser/payments/manifest_verifier_browsertest.cc [add] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/chrome/browser/payments/payment_manifest_parser_browsertest.cc [delete] https://crrev.com/c47b1f13138b9f12b01da22ab11a82a8cf639bcc/chrome/browser/payments/payment_manifest_parser_host_browsertest.cc [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/chrome/test/BUILD.gn [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/chrome/utility/BUILD.gn [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/chrome/utility/chrome_content_utility_client.cc [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/BUILD.gn [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/DEPS [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/android/BUILD.gn [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/android/java/src/org/chromium/components/payments/PaymentManifestParser.java [add] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/android/java/src/org/chromium/components/payments/WebAppManifestSection.java [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/android/payment_manifest_parser_android.cc [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/android/payment_manifest_parser_android.h [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/manifest_verifier.cc [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/manifest_verifier.h [delete] https://crrev.com/c47b1f13138b9f12b01da22ab11a82a8cf639bcc/components/payments/content/payment_manifest_parser_host.cc [delete] https://crrev.com/c47b1f13138b9f12b01da22ab11a82a8cf639bcc/components/payments/content/payment_manifest_parser_host.h [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/payment_manifest_web_data_service.cc [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/payment_manifest_web_data_service.h [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/payment_request_state.cc [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/utility/BUILD.gn [add] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/utility/OWNERS [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/utility/payment_manifest_parser.cc [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/utility/payment_manifest_parser.h [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/utility/payment_manifest_parser_unittest.cc [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/utility/payment_method_manifest_parser_fuzzer.cc [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/utility/payment_web_app_manifest_parser_fuzzer.cc [add] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/web_app_manifest_section.cc [add] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/web_app_manifest_section.h [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/web_app_manifest_section_table.cc [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/web_app_manifest_section_table.h [modify] https://crrev.com/a7d22b487ea75a9cc9a6d570d048faa88722470b/components/payments/content/web_app_manifest_section_table_unittest.cc [delete] https://crrev.com/c47b1f13138b9f12b01da22ab11a82a8cf639bcc/components/payments/mojom/BUILD.gn [delete] https://crrev.com/c47b1f13138b9f12b01da22ab11a82a8cf639bcc/components/payments/mojom/OWNERS [delete] https://crrev.com/c47b1f13138b9f12b01da22ab11a82a8cf639bcc/components/payments/mojom/payment_manifest_parser.mojom
Comment 1 by jcivelli@chromium.org
, Oct 17 2017