New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775677 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment

Deprecate UtilityProcessHost

Project Member Reported by jcivelli@chromium.org, Oct 17 2017

Issue description

As part of the effort to move child process starting to the service manager, we should deprecate UtilityProcessHost and the related UtilityProcessMojoClient.
Instead callers should connect to a service through the service manager.

 
Blockedon: 775679

Comment 2 by roc...@chromium.org, Oct 18 2017

Cc: jam@chromium.org roc...@chromium.org
 Issue 656722  has been merged into this issue.
Blockedon: 782928
Blockedon: 785383
Blockedon: 786613
Blockedon: 790024
Also remove UtilityProcessHostClient.
Blockedon: 799220
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd2d7f91cb38d3c1cad9b1867a840712bb95214a

commit fd2d7f91cb38d3c1cad9b1867a840712bb95214a
Author: Jay Civelli <jcivelli@google.com>
Date: Fri Jan 26 21:51:39 2018

Removed dependency to UtilityProcessHost from MashServiceRegistryTest.

As part of the effort to move UtilityProcessHost to the ServiceManager,
removing a reference to UtilityProcessHost from
MashServiceRegistryTest.

Bug:  775677 
Change-Id: I7da48a0f58d46205c3ec2e7143a22e96981cba37
Reviewed-on: https://chromium-review.googlesource.com/886839
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532066}
[modify] https://crrev.com/fd2d7f91cb38d3c1cad9b1867a840712bb95214a/chrome/browser/mash_service_registry_browsertest.cc
[modify] https://crrev.com/fd2d7f91cb38d3c1cad9b1867a840712bb95214a/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/fd2d7f91cb38d3c1cad9b1867a840712bb95214a/content/browser/service_manager/service_manager_context.h
[modify] https://crrev.com/fd2d7f91cb38d3c1cad9b1867a840712bb95214a/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/fd2d7f91cb38d3c1cad9b1867a840712bb95214a/content/public/test/browser_test_utils.h

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2639b101dab8fcef9821bb1b4a68488726a86e65

commit 2639b101dab8fcef9821bb1b4a68488726a86e65
Author: Jay Civelli <jcivelli@google.com>
Date: Tue Mar 13 05:09:16 2018

Removing UtilityProcessMojoClient

Removing UtilityProcessMojoClient now that it is not used anymore.
As a result UtilityProcessHost::SetExposedDir() is removed as well as
its actual implementation in the sandbox code.

Tbr: bradnelson@chromium.org
Bug:  775677 
Change-Id: I4147a2482c51132afa7a43927d6351e63169cb06
Reviewed-on: https://chromium-review.googlesource.com/937962
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542735}
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/components/nacl/loader/nacl_main_platform_delegate_mac.mm
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/content/browser/sandbox_parameters_mac.mm
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/content/browser/utility_process_host_impl.cc
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/content/browser/utility_process_host_impl.h
[delete] https://crrev.com/a75606f0da03cd529fc5dd5d415047cef793e02e/content/browser/utility_process_mojo_client_browsertest.cc
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/content/common/sandbox_init_mac.cc
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/content/common/sandbox_mac_unittest_helper.mm
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/content/public/browser/BUILD.gn
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/content/public/browser/utility_process_host.h
[delete] https://crrev.com/a75606f0da03cd529fc5dd5d415047cef793e02e/content/public/browser/utility_process_mojo_client.h
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/content/public/common/content_switches.cc
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/content/public/common/content_switches.h
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/content/public/common/sandbox_init.h
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/content/test/BUILD.gn
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/services/service_manager/sandbox/mac/common.sb
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/services/service_manager/sandbox/mac/common_v2.sb
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/services/service_manager/sandbox/mac/package_sb_file.py
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/services/service_manager/sandbox/mac/sandbox_mac.h
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/services/service_manager/sandbox/mac/sandbox_mac.mm
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/services/service_manager/sandbox/mac/utility.sb
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/services/service_manager/sandbox/sandbox.cc
[modify] https://crrev.com/2639b101dab8fcef9821bb1b4a68488726a86e65/services/service_manager/sandbox/sandbox.h

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14aced2aea8e21a9021118d3e42fcfe81779c019

commit 14aced2aea8e21a9021118d3e42fcfe81779c019
Author: Jay Civelli <jcivelli@google.com>
Date: Wed Mar 14 23:44:33 2018

Make UtilityProcessHost non public

Removes UtilityProcessHost from content/public and renames
UtilityprocessHostImpl to UtilityProcessHost.
Now that all use cases of UtilityProcessHost have been replaced by
using services (but for the PowerMonitor browser tests), this will
prevent further forking of process bypassing the service manager.

Bug:  775677 
Change-Id: I2107271a54e4ab3141102a5c4fbcce4ea21915dd
Reviewed-on: https://chromium-review.googlesource.com/961496
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543238}
[modify] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc
[modify] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/content/app/content_main_runner.cc
[modify] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/content/browser/BUILD.gn
[modify] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/content/browser/browser_main_loop.cc
[modify] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/content/browser/mojo_sandbox_browsertest.cc
[modify] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/content/browser/power_monitor_browsertest.cc
[modify] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/content/browser/service_manager/service_manager_context.cc
[rename] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/content/browser/utility_process_host.cc
[rename] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/content/browser/utility_process_host.h
[rename] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/content/browser/utility_process_host_browsertest.cc
[rename] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/content/browser/utility_process_host_client.h
[modify] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/content/public/browser/BUILD.gn
[delete] https://crrev.com/faa0d04d8a0e8c7939ba5a7c581b2813a576d7e0/content/public/browser/utility_process_host.h
[modify] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/content/public/test/content_test_suite_base.cc
[modify] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/content/test/BUILD.gn
[modify] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/content/utility/utility_thread_impl.cc
[modify] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/ipc/README.md

Status: Fixed (was: Untriaged)
UtilityProcessMojoClient was removed and UtilityProcessHost was moved out of content/public/.

Sign in to add a comment