rebuild is slow after git cl patch |
||
Issue descriptionThe first build after "git cl patch" takes about as long as a build from scratch, even if the patch is trivial and I had just built before patching. It seems as if "git cl patch" does something to touch a large number of files in the working copy, like checking out the base revision of the patch as an intermediate step. This shouldn't be necessary, because the end state is that the patch is cherry-picked onto the HEAD I started with. Could "git cl patch" be smarter about this? I think it would make a big difference in productivity.
,
Nov 2 2017
"git cl patch" just does "git fetch && git cherry-pick", and should only touch exactly the files you patch in. However, "git cl patch --force" does a "git fetch && git reset --hard", and therefore likely touches basically the entire checkout. Are you sure you're seeing slow rebuilds even after a non-force patch?
,
Nov 2 2017
Hm, I wasn't using --force... but I'm unable to repro now. Maybe it was something weird about that specific patch. |
||
►
Sign in to add a comment |
||
Comment 1 by phajdan.jr@chromium.org
, Oct 18 2017