Transparent title when dragging overview window. |
|||||||
Issue descriptionWhat steps will reproduce the problem? (1) Enable dragging overview items by turning on splitview. (2) Open a couple windows, enter tablet mode. (3) Drag one of the windows around. What happens? The title is semi transparent, so if you drag it over another item which has a white background, you cannot see the title. Not sure if this a regression, I believe dragging was not enabled for overview until splitview so maybe this was just not designed to be dragged originally.
,
Oct 19 2017
This sounds like a good solution to me.
,
Oct 23 2017
Sammie, could you take a look at it?
,
Oct 24 2017
,
Oct 24 2017
Sorry to chime in late to this bug. Because the text is white and the background is transparent white, I don't see a simple solution with going opaque. I know that Sebastien wanted to change the visuals of overview (most likely creating floating labels above the previews, with no title bar). In the short term, the status quo is non-ideal, but probably ok.
,
Oct 24 2017
The background is transparent white but its always against some blackish gray so its more closer to transparent black. The fix i made (which i will revert) was just to make it black on drag. My two cents.
,
Oct 24 2017
+Sebastien in-case he has an opinion here.
,
Nov 7 2017
,
Jan 10 2018
,
Jan 29 2018
sgabriel@ - I may have missed something, but i do not think the mocks cover this case right?
,
Jan 30 2018
It is. Please refer to the motion spec. https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html The changes are: - Title bar are fully transparent - You cannot grab the title bar anymore - Only the thumbnail is draggable - When the thumbnail is dragged, Title bar fades away - When a thumbnail is dragged, all close button fade away
,
Jan 30 2018
I see, a couple questions. 1) Can you still select the app by click and release the title? 2) Right now you can exit overview by clicking anywhere, will this be the case for the title?
,
Jan 30 2018
Great points. 1) this sounds good, just disable drag 2) no, title are still a clickable area (no feedback however), as defined in #1
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00dd90932cc0d14fba4eee67ac00357ae6a75228 commit 00dd90932cc0d14fba4eee67ac00357ae6a75228 Author: Sammie Quon <sammiequon@google.com> Date: Tue Feb 06 20:03:20 2018 overview: Hide close button and title bar on overview item dragged. Hide both for the item currently dragged. Only hide the close button for the rest of the items. Spec: https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html Window selection and deselection Test: ash_unittests WindowSelectorTest.WindowItemTitleCloseVisibilityOnDrag Bug: 782320, 775655 Change-Id: I7e06a0154a9afdb391966109517b1aed419083e4 Reviewed-on: https://chromium-review.googlesource.com/893212 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#534764} [modify] https://crrev.com/00dd90932cc0d14fba4eee67ac00357ae6a75228/ash/wm/overview/window_grid.cc [modify] https://crrev.com/00dd90932cc0d14fba4eee67ac00357ae6a75228/ash/wm/overview/window_grid.h [modify] https://crrev.com/00dd90932cc0d14fba4eee67ac00357ae6a75228/ash/wm/overview/window_selector.cc [modify] https://crrev.com/00dd90932cc0d14fba4eee67ac00357ae6a75228/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/00dd90932cc0d14fba4eee67ac00357ae6a75228/ash/wm/overview/window_selector_item.h [modify] https://crrev.com/00dd90932cc0d14fba4eee67ac00357ae6a75228/ash/wm/overview/window_selector_unittest.cc
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbc21da64b686ca3f460fdb58d00c32846688ada commit cbc21da64b686ca3f460fdb58d00c32846688ada Author: Sammie Quon <sammiequon@google.com> Date: Thu Feb 22 01:37:31 2018 overview: Disable drag for taps on title bar. Do not allow dragging/snapping window if the tap event originated on the overview item title. Press and release still will open the associated window. Also fix a bug with title bar not reshowing after long press. And remove a unneeded function parameter. Test: SplitViewWindowSelectorTest.EventsOnOverviewTitleBar Bug: 775655 Change-Id: Ie1339a88374f1e03f7c3362f8bf531c197db9c80 Reviewed-on: https://chromium-review.googlesource.com/911849 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#538302} [modify] https://crrev.com/cbc21da64b686ca3f460fdb58d00c32846688ada/ash/wm/overview/window_grid.cc [modify] https://crrev.com/cbc21da64b686ca3f460fdb58d00c32846688ada/ash/wm/overview/window_grid.h [modify] https://crrev.com/cbc21da64b686ca3f460fdb58d00c32846688ada/ash/wm/overview/window_selector.cc [modify] https://crrev.com/cbc21da64b686ca3f460fdb58d00c32846688ada/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/cbc21da64b686ca3f460fdb58d00c32846688ada/ash/wm/overview/window_selector_item.h [modify] https://crrev.com/cbc21da64b686ca3f460fdb58d00c32846688ada/ash/wm/overview/window_selector_unittest.cc
,
Feb 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by x...@chromium.org
, Oct 17 2017Cc: zork@chromium.org mccanny@chromium.org