New issue
Advanced search Search tips

Issue 775643 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Clean up the metrics that were used for the experiment of not compositing small scrollers

Project Member Reported by yigu@chromium.org, Oct 17 2017

Issue description

After running the experiment  issue 728267 , we found that not compositing small scrollers would not have significant gpu memory savings. Removing relevant metrics from the code base. 
 

Comment 1 by yigu@chromium.org, Oct 17 2017

Labels: Type-Task
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82cec2156af52a57c86067c46b926e885b0bef21

commit 82cec2156af52a57c86067c46b926e885b0bef21
Author: Yi Gu <yigu@chromium.org>
Date: Wed Oct 18 21:53:38 2017

Remove UMA metric Event.Scroll.ScrollerSize.OnLoad

We do not need the metric since the experiment of not compositing small
scrollers is done. See crbug.com/684631.

Bug:  775643 
Change-Id: Ieff65345931a35cb278d25a7d574944585907304
Reviewed-on: https://chromium-review.googlesource.com/723675
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509886}
[modify] https://crrev.com/82cec2156af52a57c86067c46b926e885b0bef21/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/82cec2156af52a57c86067c46b926e885b0bef21/third_party/WebKit/Source/core/page/scrolling/ScrollMetricsTest.cpp
[modify] https://crrev.com/82cec2156af52a57c86067c46b926e885b0bef21/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf1ce6b9e9cffee8a73f4cf3bc8658d0de2e7924

commit bf1ce6b9e9cffee8a73f4cf3bc8658d0de2e7924
Author: Yi Gu <yigu@chromium.org>
Date: Thu Oct 19 16:26:20 2017

Remove the feature SkipCompositingSmallScrollers

We do not need the feature any more since the experiment of not
compositing small scrollers is done. See crbug.com/684631.

Bug:  775643 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9f0d6c82ffd4d3813630b74ed20f4d44d7fd166f
Reviewed-on: https://chromium-review.googlesource.com/723982
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510102}
[modify] https://crrev.com/bf1ce6b9e9cffee8a73f4cf3bc8658d0de2e7924/content/child/runtime_features.cc
[modify] https://crrev.com/bf1ce6b9e9cffee8a73f4cf3bc8658d0de2e7924/content/public/common/content_features.cc
[modify] https://crrev.com/bf1ce6b9e9cffee8a73f4cf3bc8658d0de2e7924/content/public/common/content_features.h
[modify] https://crrev.com/bf1ce6b9e9cffee8a73f4cf3bc8658d0de2e7924/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/bf1ce6b9e9cffee8a73f4cf3bc8658d0de2e7924/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp
[modify] https://crrev.com/bf1ce6b9e9cffee8a73f4cf3bc8658d0de2e7924/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/bf1ce6b9e9cffee8a73f4cf3bc8658d0de2e7924/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/bf1ce6b9e9cffee8a73f4cf3bc8658d0de2e7924/third_party/WebKit/Source/platform/testing/RuntimeEnabledFeaturesTestHelpers.h
[modify] https://crrev.com/bf1ce6b9e9cffee8a73f4cf3bc8658d0de2e7924/third_party/WebKit/public/platform/WebRuntimeFeatures.h

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56a02911046cf9a7e548290899ac26b0d2bb6009

commit 56a02911046cf9a7e548290899ac26b0d2bb6009
Author: Yi Gu <yigu@chromium.org>
Date: Mon Oct 23 16:02:15 2017

Remove feature from field trial testing config

Bug:  775643 , 776929
Change-Id: I9d7bdefc91ad4151ee1ec01fcc98551a1d439613
Reviewed-on: https://chromium-review.googlesource.com/732071
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510806}
[modify] https://crrev.com/56a02911046cf9a7e548290899ac26b0d2bb6009/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3c92b5963257e19dbc255ed9426d42160b051f2

commit c3c92b5963257e19dbc255ed9426d42160b051f2
Author: Yi Gu <yigu@chromium.org>
Date: Mon Oct 23 18:43:20 2017

Remove UMA metric Event.Scroll.ScrollerSize.OnScroll

We no longer need the metric since the experiment of not compositing
small scrollers is done. See crbug.com/684631.

Bug:  775643 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I689f26f1355f01238f3ac8f0121bca59e9be3956
Reviewed-on: https://chromium-review.googlesource.com/728702
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510861}
[modify] https://crrev.com/c3c92b5963257e19dbc255ed9426d42160b051f2/build/check_gn_headers_whitelist.txt
[modify] https://crrev.com/c3c92b5963257e19dbc255ed9426d42160b051f2/cc/input/scroller_size_metrics.h
[modify] https://crrev.com/c3c92b5963257e19dbc255ed9426d42160b051f2/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/c3c92b5963257e19dbc255ed9426d42160b051f2/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/c3c92b5963257e19dbc255ed9426d42160b051f2/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/c3c92b5963257e19dbc255ed9426d42160b051f2/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/c3c92b5963257e19dbc255ed9426d42160b051f2/third_party/WebKit/Source/core/input/ScrollManager.h
[modify] https://crrev.com/c3c92b5963257e19dbc255ed9426d42160b051f2/third_party/WebKit/Source/core/page/scrolling/ScrollMetricsTest.cpp
[delete] https://crrev.com/232d3d00928f78b5bacbeb5f5441292c47a8dd33/third_party/WebKit/Source/platform/scroll/ScrollerSizeMetrics.h
[modify] https://crrev.com/c3c92b5963257e19dbc255ed9426d42160b051f2/tools/metrics/histograms/histograms.xml

Comment 6 by yigu@chromium.org, Oct 23 2017

Status: Fixed (was: Started)

Sign in to add a comment