Extend v8.runtime_stats.top_25 to cover more test cases & rename it v8.realworld_perf |
|||||||||
Issue descriptionWe should extend v8.runtime_stats.top_25 to cover all interesting v8 metrics on real world wesbsites that v8 team maintain. The metrics would be runtime callstats & V8 GC metrics. As we do this, v8.runtime_stats.top_25 should also be renamed to v8.realworld_perf to better reflect what this benchmark cover. V8 folks: can you find someone to drive this?
,
Oct 17 2017
,
Nov 27 2017
,
Nov 28 2017
,
Nov 30 2017
Updating this bug from today's discussion: 1. Enable GCmetric and maybe also EQT metrics on this pageset. 2. Move to RuntimeStatsTotal metric and have report both the startup time (based on the load UE bucket) and the overall time. 3. Have different pagesets for mobile and for desktop. So we will have two pagesets and two benchmarks (one for mobile and one for desktop). We might have some common pages in both of them to measure relative performance on mobile and desktop. Also, we need to check what is failing on windows and enable the benchmark on windows. There is another bug tracking it, so I guess this item need not be a part of this bug.
,
Nov 30 2017
,
Nov 30 2017
Item 2 is tracked here: crbug.com/688342. I will start working on this next week.
,
Dec 13 2017
,
Dec 14 2017
,
Dec 14 2017
,
Feb 20 2018
Discussed this offline with Hablich. He recommended me to reassign this bug to Camillo
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a3a03b675fc955454427ddd6a3685f761bc277a commit 8a3a03b675fc955454427ddd6a3685f761bc277a Author: Ulan Degenbaev <ulan@chromium.org> Date: Tue Mar 27 03:28:00 2018 Remove v8.detached_context_age_in_gc benchmark. Blink document leak detector has similar coverage. Bug: chromium:775635 Change-Id: I871ee0e8337dde3b326dab75d4d3af9ebb47ebe7 Reviewed-on: https://chromium-review.googlesource.com/980875 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#545967} [modify] https://crrev.com/8a3a03b675fc955454427ddd6a3685f761bc277a/testing/buildbot/chromium.perf.json [modify] https://crrev.com/8a3a03b675fc955454427ddd6a3685f761bc277a/tools/perf/benchmark.csv [modify] https://crrev.com/8a3a03b675fc955454427ddd6a3685f761bc277a/tools/perf/benchmarks/v8.py [delete] https://crrev.com/bebfc29b18c73a0f0a76e55c74314c5716905f07/tools/perf/measurements/v8_detached_context_age_in_gc.py [delete] https://crrev.com/bebfc29b18c73a0f0a76e55c74314c5716905f07/tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py [delete] https://crrev.com/bebfc29b18c73a0f0a76e55c74314c5716905f07/tools/perf/page_sets/page_reload_cases.py |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by nedngu...@google.com
, Oct 17 2017