New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 775634 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 762165
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

smoothness.top_25_smooth failing on Win 7 x64 Perf

Project Member Reported by zh...@chromium.org, Oct 17 2017

Issue description

smoothness.top_25_smooth failing on Win 7 x64 Perf

Builders failed on: 
- Win 7 x64 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20x64%20Perf



 

Comment 1 by zh...@chromium.org, Oct 17 2017

Traceback (most recent call last):
  File "c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\story_runner.py", line 104, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "c:\b\s\w\ir\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\page\shared_page_state.py", line 324, in RunStory
    self._current_page.Run(self)
  File "c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\page\__init__.py", line 114, in Run
    shared_state.page_test.RunNavigateSteps(self, current_tab)
  File "c:\b\s\w\ir\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\page\legacy_page_test.py", line 152, in RunNavigateSteps
    page.RunNavigateSteps(action_runner)
  File "c:\b\s\w\ir\tools\perf\page_sets\top_pages.py", line 118, in RunNavigateSteps
    self.credentials_path)
  File "c:\b\s\w\ir\tools\perf\page_sets\login_helpers\google_login.py", line 76, in LoginGoogleAccount
    action_runner.WaitForElement(text='My Account')
  File "c:\b\s\w\ir\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\actions\action_runner.py", line 290, in WaitForElement
    timeout_in_seconds=timeout_in_seconds))
  File "c:\b\s\w\ir\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\actions\action_runner.py", line 63, in _RunAction
    action.RunAction(self._tab)
  File "c:\b\s\w\ir\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\actions\wait.py", line 22, in RunAction
    wait=True, timeout_in_seconds=self.timeout_in_seconds)
  File "c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\actions\page_action.py", line 127, in EvaluateCallbackWithElement
    tab.WaitForJavaScriptCondition(code, timeout=timeout_in_seconds)
  File "c:\b\s\w\ir\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\browser\web_contents.py", line 239, in WaitForJavaScriptCondition
    return self._inspector_backend.WaitForJavaScriptCondition(*args, **kwargs)
  File "c:\b\s\w\ir\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\backends\chrome_inspector\inspector_backend.py", line 302, in WaitForJavaScriptCondition
    e.message + '\n' + debug_message)
TimeoutException: Timed out while waiting 60s for IsJavaScriptExpressionTrue.

Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 17 2017

Cc: wkorman@chromium.org
Owner: wkorman@chromium.org
Status: Assigned (was: Available)

=== Auto-CCing suspected CL author wkorman@chromium.org ===

Hi wkorman@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Test failure found with culprit

Suspected Commit
  Author : Walter Korman
  Commit : e093016b4d1d7291575365277c3105ae165fe75e
  Date   : Sat Sep 02 00:50:28 2017
  Subject: Update Top Pages story login logic for Google and Facebook.

Bisect Details
  Configuration: win_x64_perf_bisect
  Benchmark    : smoothness.top_25_smooth
  Metric       : first_gesture_scroll_update_latency/http___www.youtube.com

Revision             Exit Code      N
chromium@499289      0 +- N/A       5      good
chromium@499330      0 +- N/A       5      good
chromium@499351      0 +- N/A       5      good
chromium@499356      0 +- N/A       5      good
chromium@499357      1 +- N/A       5      bad       <--
chromium@499358      1 +- N/A       5      bad
chromium@499359      1 +- N/A       5      bad
chromium@499361      1 +- N/A       5      bad
chromium@499371      1 +- N/A       5      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...www.youtube.com smoothness.top_25_smooth

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8965456165219869168


For feedback, file a bug with component Speed>Bisection
Cc: nedngu...@google.com
Components: Tests>Telemetry
There was a revert of my change created but abandoned here:

https://chromium-review.googlesource.com/c/chromium/src/+/669481

Since then I know Victor has re-recorded some page sets. Has this one already been done?

I will look more closely soon but wanted to get feedback in meantime.

Comment 5 by vmi...@chromium.org, Oct 17 2017

Google sites were re-recorded at https://chromium-review.googlesource.com/c/chromium/src/+/670064.  I thought they worked after that, but it looks like they're all failing now.
It looks like they are all stuck at the login screen:
https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/profiler-file-id_1-2017-10-20_11-05-2515748.png

Any update on this?
Mergedinto: 762165
Status: Duplicate (was: Assigned)
This seems like a subset dupe of  issue 762165  for which vmiura@ re-recorded previously. Duping to that bug.

We could potentially consider moving the involved page set to use static pages rather than wprgo.

Sign in to add a comment