Incognito and theme colors for new download progress indicator |
|||||||||||||
Issue descriptionI notice that the new progress indicator doesn't have different colors for incognito or custom themes. How should it handle them?
,
Oct 17 2017
Alan, how are icons handled for incognito & custom themes? Should the new progress indicator be white or a light grey?
,
Oct 26 2017
New colors in the attachments. LMK if you have any questions. https://drive.google.com/corp/drive/folders/0BxMIIGI80eU-TVI4a2MxNml2ajQ
,
Nov 6 2017
bettes@: Could the specs point to to colors in the MD palette in the specs instead of just providing hex codes? There are already names for many of them in the codebase, and I think we try to use them whenever possible instead of having one-off colors in different places. Something like "Blue 500 (#4285F4) 0.2a" would be perfect. It also looks like the background for the complete state is listed as a color with alpha for incognito, and a different color entirely with no alpha for a normal theme. I'm guessing that one can also be represented as the checkmark color w/ 0.2 alpha? Last question — it looks like all of the colors do match colors in the palette except for the checkmark color (#009054). Does that one have a name?
,
Nov 6 2017
Er, pretend I didn't say "the specs" twice in the first sentence :). One more "last" question: these colors aren't the same as the ones at <https://material.io/guidelines/style/color.html>. Is there a list somewhere?
,
Nov 6 2017
CL: https://chromium-review.googlesource.com/c/chromium/src/+/754725 Since bettes@: is OOO: - I went with the standard MD colors for both states (green/blue, 300/700). - The spec is out of sync with helenepark@'s current design, where the arrow is blue 500. I'm keeping it at blue 500 for both dark and light themes, guessing that it provides the right contrast in both directions.
,
Nov 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa7c664d93192f921cf2c6211905acdf66851991 commit fa7c664d93192f921cf2c6211905acdf66851991 Author: Sidney San Martín <sdy@chromium.org> Date: Mon Nov 06 15:21:05 2017 New MD download shelf progress indicator colors for dark themes. Bug: 775618 Change-Id: I9ea94b2c97e53cca7fbf44d79bb5a8100e882bc1 Reviewed-on: https://chromium-review.googlesource.com/754725 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#514133} [modify] https://crrev.com/fa7c664d93192f921cf2c6211905acdf66851991/chrome/browser/ui/cocoa/download/md_download_item_progress_indicator.mm
,
Nov 6 2017
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by sdy@chromium.org
, Oct 17 2017