New issue
Advanced search Search tips

Issue 775615 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 62400



Sign in to add a comment

pdfium_xfa_fuzzer.cc:17:20: error: use of undeclared identifier 'DOCTYPE_PDF'

Project Member Reported by mmoroz@chromium.org, Oct 17 2017

Issue description

Looks like some recent changes removed some "#include" statement, libFuzzer buildbots are failing: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.fyi%2FLibfuzzer_Upload_Linux_ASan%2F6262%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout
 
Blockedon: 62400
Owner: rharrison@chromium.org
Status: Assigned (was: Untriaged)
Yup, that is me. I am currently refactoring how that API works. I will fix it once https://pdfium-review.googlesource.com/c/pdfium/+/16210 has landed and the DEPS roll picks it up.
Status: Started (was: Assigned)

Comment 4 by mmoroz@chromium.org, Oct 17 2017

Thanks for the update Ryan. Is there any way we can speed up the fix? We have the Fuzzathon going on, and people are adding / improving fuzz targets, so we cannot just sit and wait with broken builds for a while :(

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7acf34ac83f7d3de53a32bad59fdcb5892db3ac9

commit 7acf34ac83f7d3de53a32bad59fdcb5892db3ac9
Author: Max Moroz <mmoroz@chromium.org>
Date: Wed Oct 18 02:12:45 2017

Temporary fix pdfium_xfa_fuzzer in order to unblock other fuzzing builds.

TBR=metzman@chromium.org, ochang@chromium.org, rharrison@chromium.org

Bug:  775615 
Change-Id: I2aaa15cfcde324974ca9352169aa595fc571f5e1
Reviewed-on: https://chromium-review.googlesource.com/724732
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509655}
[modify] https://crrev.com/7acf34ac83f7d3de53a32bad59fdcb5892db3ac9/pdf/pdfium/fuzzers/pdfium_xfa_fuzzer.cc

Thanks for the patch Max, sorry about not handling this yesterday. I don't think I grok'd that this was blocking all the builds, I was thinking it was only blocking the XFA one.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83f632ba6258bdecb6e6a5ef7d07d42ee6a7ebca

commit 83f632ba6258bdecb6e6a5ef7d07d42ee6a7ebca
Author: Ryan Harrison <rharrison@chromium.org>
Date: Wed Oct 18 19:37:28 2017

Change XFA fuzzer to use new API for detecting XFA forms

Includes a manual roll of PDFium in DEPS to 
854d71c1420eb80ec79755a6cdf829f3f39aead7, to pick up the new API.

BUG= chromium:775615 

Change-Id: I186a7f385eb50c59718dabc1407d49564cf3547a
Reviewed-on: https://chromium-review.googlesource.com/724021
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509839}
[modify] https://crrev.com/83f632ba6258bdecb6e6a5ef7d07d42ee6a7ebca/DEPS
[modify] https://crrev.com/83f632ba6258bdecb6e6a5ef7d07d42ee6a7ebca/pdf/pdfium/fuzzers/pdfium_xfa_fuzzer.cc

Status: Fixed (was: Started)

Sign in to add a comment